Maniphest T191960

MediaWikiTestCase::hideDeprecated() does not reset between tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Apr 11 2018, 9:30 AM

Description

In the test suite, when one uses hideDeprecated(), the deprecated warning will be ignored for the rest of the test run. That can cause an unexpected deprecated warning when the tests are being run in a different order

I have hit that in REL1_30 which has WatchedItem methods deprecated (T182381). The suite has two tests cases:

WatchedItemIntegrationTest	hides deprecated
WatchedItemUnitTest	does NOT hide them

On CI they are executed in that order, hence the deprecated methods are already hidden when WatchedItemUnitTest is run. On my local machine, WatchedItemUnitTest got to run first and thus raised warnings failling the test run.

The fix was to copy paste the hideDeprecated() notice to WatchedItemUnitTest: https://gerrit.wikimedia.org/r/#/c/423469/

I guess whenever we use hideDeprecated(), we should make sure we reset the deprecation list. Possibly in MediaWikiTestCase::tearDown() by invoking MWDebug::clearLog() (though that also clear the log).

hideDeprecated has been introduced in a108dbfe8f7f20f22d6513838022d50bbdc17165.

Details

	Subject	Repo	Branch	Lines +/-
	Ensure disabled deprecation warnings are re-enabled before next test	mediawiki/core	master	+2 -5
	OutputPageTest: Don't rely on side effects of previous tests	mediawiki/core	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMWa108dbfe8f7f: Reverted r92489 and added/use hideDeprecated() to MW test framework
T182381: Remove Deprecated WatchedItem methods and constants

Event Timeline

hashar created this task.Apr 11 2018, 9:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2018, 9:30 AM

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jun 15 2018, 12:53 PM

Jdforrester-WMF subscribed.Sep 20 2018, 5:15 PM

Change 461977 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Ensure disabled deprecation warnings are re-enabled before next test

https://gerrit.wikimedia.org/r/461977

gerritbot added a project: Patch-For-Review.Sep 24 2018, 9:18 PM

Change 462718 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] OutputPageTest: Don't rely on side effects of previous tests

https://gerrit.wikimedia.org/r/462718

Change 462718 merged by jenkins-bot:
[mediawiki/core@master] OutputPageTest: Don't rely on side effects of previous tests

https://gerrit.wikimedia.org/r/462718

Jdforrester-WMF closed this task as Resolved.Sep 25 2018, 4:55 PM

Jdforrester-WMF assigned this task to cscott.

Jdforrester-WMF removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Sep 25 2018, 5:00 PM

Change 461977 merged by jenkins-bot:
[mediawiki/core@master] Ensure disabled deprecation warnings are re-enabled before next test