Kafka-based JobQueue doesn't use PHP serialization as there's a general move towards eliminating it from the codebase (T161647), so the TranslationsUpdateJob has to use JSON-serialization and instantiate any classes it was PHP-serializing when executing.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Pchelolo | T157088 [EPIC] Develop a JobQueue backend based on EventBus | |||
| Resolved | • Pchelolo | T190327 FY17/18 Q4 Program 8 Services Goal: Complete the JobQueue transition to EventBus | |||
| Resolved | • Nikerabbit | T192107 Unable to mark pages for translation in Meta | |||
| Resolved | • Nikerabbit | T192111 Make TranslationsUpdateJob JSON-serializable |
Event Timeline
Comment Actions
Change 428917 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Refactor TranslationUpdateJob to use only primitive types for parameters
Comment Actions
Change 428917 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Refactor TranslationUpdateJob to use only primitive types for parameters
Comment Actions
Reopening until this code is live in production. @Nikerabbit could you perhaps SWAT it today or Monday to speed up the process? Thnx!
Comment Actions
Sorry, this slipped my mind yesterday. How important is it to speed this up? My concern is that the patch might not be simple nor low risk (nor easy to confirm) as required for SWAT deployments.
Comment Actions
We'd need this ASAP. Once it is deployed on the wikis, it should be monitored for a while. If it turns out that it needs to be reverted, it can be done outside of SWAT windows.
Comment Actions
Change 431744 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@wmf/1.32.0-wmf.2] Refactor TranslationUpdateJob to use only primitive types for parameters
Comment Actions
Change 431744 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.32.0-wmf.2] Refactor TranslationUpdateJob to use only primitive types for parameters
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-05-08T13:42:22Z] <zfilipin@tin> Synchronized php-1.32.0-wmf.2/extensions/Translate: SWAT: [[gerrit:431744|Refactor TranslationUpdateJob to use only primitive types for parameters (T192111)]] (duration: 01m 11s)
Comment Actions
@mobrovac Done.
The job is broken on test.wikipedia.org for unrelated reason. On MediaWiki.org I re-marked one page for testing purposes and it worked: https://www.mediawiki.org/w/index.php?title=At-ease/de&diff=2776172&oldid=2595342&diffmode=source (+no errors in LogStash).
Comment Actions
Thank you @Nikerabbit ! Resolving for now, let's reopen it if we see them start failing.