Page MenuHomePhabricator
Create Task
Maniphest T194162

Add code to read from change_tag_def instead of change_tag.ct_tag
Closed, ResolvedPublic
Actions

Description

As part of the migration to normalize change tags in the database, we will need to add code to read from the new change_tag_def table instead of change_tag’s ct_tag column (hidden behind $wgChangeTagsSchemaMigrationStage = MIGRATION_WRITE_BOTH for now).

This needs some work:

Details

SubjectRepoBranchLines +/-
Join decomposition on change_tag and change_tag_def when filteringmediawiki/coremaster+18 -6
Code to read from change_tag_def table instead of valid_tagmediawiki/coremaster+114 -10
Update API tests to comply with the new backend for change tagsmediawiki/coremaster+132 -0
API: Use ct_tag_id in queries when applicablemediawiki/coremaster+102 -8
Add code to read from ct_tag_id in ChangeTagsmediawiki/coremaster+50 -11
Add option to read from ct_tag_id instead of ct_tagmediawiki/extensions/ContentTranslationmaster+34 -4
Make FlaggedRevs read from the new backend for change tagmediawiki/extensions/FlaggedRevsmaster+47 -3
Read from the new column of change_tagmediawiki/extensions/OAuthmaster+19 -1
Turning change_tag_def store to a servicemediawiki/coremaster+32 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 8 2018, 2:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2018, 2:20 PM
Lucas_Werkmeister_WMDE mentioned this in T185355: Normalize change tag schema.May 8 2018, 2:27 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite.Jun 5 2018, 1:36 PM
gerritbot subscribed.Jun 21 2018, 7:00 AM

Change 441340 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Turning change_tag_def store to a service

https://gerrit.wikimedia.org/r/441340

gerritbot added a project: Patch-For-Review.Jun 21 2018, 7:00 AM
gerritbot added a comment.Jun 21 2018, 8:09 AM

Change 441340 merged by jenkins-bot:
[mediawiki/core@master] Turning change_tag_def store to a service

https://gerrit.wikimedia.org/r/441340

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 2:01 PM
• Vvjjkkii renamed this task from Add code to read from change_tag_def instead of change_tag.ct_tag to xddaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from xddaaaaaaa to Add code to read from change_tag_def instead of change_tag.ct_tag.Jul 1 2018, 3:32 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 3 2018, 2:21 AM
Krinkle removed a project: MediaWiki-libs-Rdbms.Jul 28 2018, 10:39 PM
matej_suchanek removed a project: Patch-For-Review.Jul 29 2018, 8:44 AM
Ladsgroup claimed this task.Aug 11 2018, 6:31 PM
Ladsgroup removed projects: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Wikidata-Ministry-Of-Magic-Tech-Debt, Wikidata-Ministry-Of-Magic.
Ladsgroup updated the task description. (Show Details)
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 11 2018, 6:31 PM
gerritbot added a comment.Aug 11 2018, 6:35 PM

Change 452052 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Add code to read from ct_tag_id in ChangeTags

https://gerrit.wikimedia.org/r/452052

gerritbot added a project: Patch-For-Review.Aug 11 2018, 6:35 PM
gerritbot added a comment.Aug 11 2018, 8:03 PM

Change 452063 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/OAuth@master] Read from the new column of change_tag

https://gerrit.wikimedia.org/r/452063

gerritbot added a comment.Aug 17 2018, 5:50 PM

Change 452063 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Read from the new column of change_tag

https://gerrit.wikimedia.org/r/452063

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 17 2018, 6:00 PM
Ladsgroup updated the task description. (Show Details)Aug 17 2018, 9:11 PM
matej_suchanek updated the task description. (Show Details)Aug 18 2018, 2:50 PM
Ladsgroup updated the task description. (Show Details)Aug 22 2018, 6:34 PM
gerritbot added a comment.Aug 28 2018, 5:56 PM

Change 455878 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ContentTranslation@master] Add option to read from ct_tag_id instead of ct_tag

https://gerrit.wikimedia.org/r/455878

Ladsgroup updated the task description. (Show Details)Aug 28 2018, 6:05 PM
Ladsgroup updated the task description. (Show Details)
gerritbot added a comment.Aug 28 2018, 7:27 PM

Change 455903 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/FlaggedRevs@master] Make FlaggedRevs read from the new backend for change tag

https://gerrit.wikimedia.org/r/455903

Ladsgroup added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Aug 28 2018, 10:27 PM
gerritbot added a comment.Aug 28 2018, 11:27 PM

Change 455878 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Add option to read from ct_tag_id instead of ct_tag

https://gerrit.wikimedia.org/r/455878

gerritbot added a comment.Aug 28 2018, 11:38 PM

Change 455903 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Make FlaggedRevs read from the new backend for change tag

https://gerrit.wikimedia.org/r/455903

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)); removed MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 29 2018, 12:00 AM
Ladsgroup updated the task description. (Show Details)Aug 29 2018, 8:00 PM

I removed AbuseFilter as it doesn't read from ct_tag column thus it's not our concern here.

gerritbot added a comment.Aug 29 2018, 9:49 PM

Change 452052 merged by jenkins-bot:
[mediawiki/core@master] Add code to read from ct_tag_id in ChangeTags

https://gerrit.wikimedia.org/r/452052

Ladsgroup updated the task description. (Show Details)Aug 30 2018, 12:51 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Sep 4 2018, 7:00 PM

Change 457970 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Join decomposition on change_tag and change_tag_def when filtering

https://gerrit.wikimedia.org/r/457970

gerritbot added a comment.Sep 4 2018, 7:18 PM

Change 457974 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Add code to read from change_tag_def in API queries

https://gerrit.wikimedia.org/r/457974

gerritbot added a comment.Sep 4 2018, 7:51 PM

Change 457978 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Update API tests to comply with the new backend for change tags

https://gerrit.wikimedia.org/r/457978

gerritbot added a comment.Sep 4 2018, 8:11 PM

Change 457970 merged by jenkins-bot:
[mediawiki/core@master] Join decomposition on change_tag and change_tag_def when filtering

https://gerrit.wikimedia.org/r/457970

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 4 2018, 9:00 PM
gerritbot added a comment.Sep 6 2018, 7:25 PM

Change 457978 merged by jenkins-bot:
[mediawiki/core@master] Update API tests to comply with the new backend for change tags

https://gerrit.wikimedia.org/r/457978

gerritbot added a comment.Sep 6 2018, 7:25 PM

Change 457974 merged by jenkins-bot:
[mediawiki/core@master] API: Use ct_tag_id in queries when applicable

https://gerrit.wikimedia.org/r/457974

Ladsgroup closed this task as Resolved.Sep 7 2018, 9:20 AM
Ladsgroup moved this task from Doing to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Ladsgroup removed a project: Patch-For-Review.
Ladsgroup updated the task description. (Show Details)
gerritbot added a comment.Sep 11 2018, 8:12 AM

Change 459688 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Code to read from change_tag_def table instead of valid_tag

https://gerrit.wikimedia.org/r/459688

gerritbot added a project: Patch-For-Review.Sep 11 2018, 8:12 AM
gerritbot added a comment.Sep 24 2018, 5:19 PM

Change 459688 merged by jenkins-bot:
[mediawiki/core@master] Code to read from change_tag_def table instead of valid_tag

https://gerrit.wikimedia.org/r/459688

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)); removed MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 24 2018, 6:00 PM
Addshore removed a project: Wikidata-Campsite.Nov 1 2018, 11:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits