Page MenuHomePhabricator
Create Task
Maniphest T194229

Fatal: Class GlobalPreferences\GlobalPreferencesForm may not inherit from interface (PreferencesForm)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Seen in en.beta

Details

SubjectRepoBranchLines +/-
Add GlobalPreferences to extension-gateintegration/configmaster+2 -0
Temporarily disable GlobalPreferences in betaoperations/mediawiki-configmaster+1 -1
Inherit from PreferencesFormLegacymediawiki/extensions/GlobalPreferencesmaster+2 -2
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedMooeypooT186842 Convert Special:GlobalPreferences to OOUI
ResolvedPRODUCTION ERRORMaxSemT194229 Fatal: Class GlobalPreferences\GlobalPreferencesForm may not inherit from interface (PreferencesForm)
· · ·

Event Timeline

MaxSem created this task.May 9 2018, 12:29 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptMay 9 2018, 12:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.May 9 2018, 12:31 AM

Change 432022 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[operations/mediawiki-config@master] Temporarily disable GlobalPreferences in beta

https://gerrit.wikimedia.org/r/432022

gerritbot added a project: Patch-For-Review.May 9 2018, 12:31 AM

Change 432022 merged by jenkins-bot:
[operations/mediawiki-config@master] Temporarily disable GlobalPreferences in beta

https://gerrit.wikimedia.org/r/432022

MaxSem added a comment.May 9 2018, 2:15 AM

Broken by https://gerrit.wikimedia.org/r/#/c/398071/

gerritbot added a comment.May 9 2018, 8:48 AM

Change 432045 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/GlobalPreferences@master] Inherit from PreferencesFormLegacy

https://gerrit.wikimedia.org/r/432045

Esanders subscribed.EditedMay 9 2018, 8:55 AM

GlobalPreferences will need to re-implement in OOUI eventually (T186842), but in the mean time it can just fall back to using PreferencesFormLegacy.

gerritbot added a comment.May 9 2018, 7:32 PM

Change 432045 merged by MaxSem:
[mediawiki/extensions/GlobalPreferences@master] Inherit from PreferencesFormLegacy

https://gerrit.wikimedia.org/r/432045

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 9 2018, 8:00 PM
gerritbot added a comment.May 9 2018, 8:16 PM

Change 432165 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[integration/config@master] Add GlobalPreferences to extension-gate

https://gerrit.wikimedia.org/r/432165

matmarex added a parent task: T186842: Convert Special:GlobalPreferences to OOUI.May 9 2018, 8:53 PM
gerritbot added a comment.May 10 2018, 10:55 PM

Change 432165 merged by jenkins-bot:
[integration/config@master] Add GlobalPreferences to extension-gate

https://gerrit.wikimedia.org/r/432165

• Niharika subscribed.May 15 2018, 6:38 PM

Anything left to do here?

MaxSem closed this task as Resolved.May 15 2018, 6:41 PM
MaxSem claimed this task.

We still need to decide upon https://gerrit.wikimedia.org/r/#/c/432213/ and any followup changes to GP it might require, but the immediate problem is resolved.

• Niharika moved this task from New & TBD Tickets to Archive on the Community-Tech board.May 15 2018, 6:46 PM
• Vvjjkkii renamed this task from Fatal: Class GlobalPreferences\GlobalPreferencesForm may not inherit from interface (PreferencesForm) to 2bdaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed MaxSem as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 2bdaaaaaaa to Fatal: Class GlobalPreferences\GlobalPreferencesForm may not inherit from interface (PreferencesForm).Jul 1 2018, 3:06 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to MaxSem.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL