Page MenuHomePhabricator
Create Task
Maniphest T194503

Special:EditWatchlist TOC navigation doesn't work since OOUI conversion: <legend> elements have no "id" parameters
Closed, ResolvedPublic
Actions

Description

Chrome Version 66.0.3359.139 (Official Build) (64-bit)
MacOS High Sierra version 10.13.4 (17E202)
Vector skin

When I navigate to https://en.wikipedia.org/wiki/Special:EditWatchlist, I get what looks like a correct TOC

Screen Shot 2018-05-11 at 9.29.16 AM.png (2×1 px, 739 KB)
, but the links don't work. The anchor tags are generated in the TOC, but the matching anchors (#editwatchlist-ns0, etc) don't exist on the page.

TOC HTML:

<div id="toc" class="toc"><div class="toctitle" lang="en" dir="ltr"><h2>Contents</h2><span class="toctoggle">&nbsp;[<a role="button" tabindex="0" class="togglelink">hide</a>]&nbsp;</span></div>

<ul>
<li class="toclevel-1"><a href="#editwatchlist-ns0"><span class="tocnumber">1</span> <span class="toctext">(Article)</span></a></li>

<li class="toclevel-1"><a href="#editwatchlist-ns2"><span class="tocnumber">2</span> <span class="toctext">User</span></a></li>

<li class="toclevel-1"><a href="#editwatchlist-ns4"><span class="tocnumber">3</span> <span class="toctext">Wikipedia</span></a></li>

<li class="toclevel-1"><a href="#editwatchlist-ns10"><span class="tocnumber">4</span> <span class="toctext">Template</span></a></li>

<li class="toclevel-1"><a href="#editwatchlist-ns118"><span class="tocnumber">5</span> <span class="toctext">Draft</span></a></li>
</ul>
</div>

Header HTML (no id anywhere):

<legend class="oo-ui-fieldsetLayout-header">
  <span class="oo-ui-iconElement-icon"></span>
  <span class="oo-ui-labelElement-label">(Main)</span>
</legend>

Details

SubjectRepoBranchLines +/-
Restore section IDs on Special:EditWatchlistmediawiki/coremaster+6 -0
Revert "Use OOUI form for edit watchlist"mediawiki/coremaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

RoySmith created this task.May 11 2018, 1:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2018, 1:33 PM
Aklapper added a project: MediaWiki-Watchlist.May 11 2018, 1:47 PM
matej_suchanek merged a task: T194567: Special:EditWatchlist TOC links don't work since OOUI conversion.May 12 2018, 8:33 AM
matej_suchanek added a project: Regression.
matej_suchanek added subscribers: JJMC89, RP88, Jdlrobson and 2 others.
Aklapper renamed this task from Special:EditWatchlist TOC navigation doesn't work to Special:EditWatchlist TOC navigation doesn't work since OOUI conversion.May 12 2018, 3:14 PM
Multichill subscribed.May 17 2018, 10:52 AM

Confirmed on both Wikidata and the Dutch Wikipedia using Firefox.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)May 17 2018, 10:53 AM
Aklapper renamed this task from Special:EditWatchlist TOC navigation doesn't work since OOUI conversion to Special:EditWatchlist TOC navigation doesn't work since OOUI conversion: <legend> elements have no "id" parameters.May 30 2018, 12:33 PM
Aklapper triaged this task as High priority.
Aklapper merged a task: T195961: Links in the TOC on "view and edit watchlist" don't work: Sections have no anchor target IDs.
Aklapper added a subscriber: xSavitar.
gerritbot subscribed.Jun 3 2018, 9:00 PM

Change 437142 had a related patch set uploaded (by JJMC89; owner: JJMC89):
[mediawiki/core@master] Revert "Use OOUI form for edit watchlist"

https://gerrit.wikimedia.org/r/437142

gerritbot added a project: Patch-For-Review.Jun 3 2018, 9:00 PM
gerritbot added a comment.Jun 4 2018, 4:39 PM

Change 437142 abandoned by Esanders:
Revert "Use OOUI form for edit watchlist"

https://gerrit.wikimedia.org/r/437142

gerritbot added a comment.Jun 4 2018, 4:50 PM

Change 437290 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Restore section IDs on Special:EditWatchlist

https://gerrit.wikimedia.org/r/437290

matmarex subscribed.Jun 4 2018, 6:17 PM

@JJMC89 Thanks for tracking down the buggy commit! It seems that no one involved in the original change watches the MediaWiki-Watchlist project, so we missed this bug report initially :(

gerritbot added a comment.Jun 4 2018, 6:26 PM

Change 437290 merged by jenkins-bot:
[mediawiki/core@master] Restore section IDs on Special:EditWatchlist

https://gerrit.wikimedia.org/r/437290

matmarex closed this task as Resolved.Jun 4 2018, 6:27 PM
matmarex assigned this task to Esanders.
matmarex removed a project: Patch-For-Review.

The fix will be deployed to Wikimedia wikis this week, 5-7 June, per the usual schedule. You should be able to test it on https://en.wikipedia.beta.wmflabs.org in a few minutes.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 4 2018, 7:00 PM
• Vvjjkkii renamed this task from Special:EditWatchlist TOC navigation doesn't work since OOUI conversion: <legend> elements have no "id" parameters to g4caaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Esanders as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from g4caaaaaaa to Special:EditWatchlist TOC navigation doesn't work since OOUI conversion: <legend> elements have no "id" parameters.Jul 2 2018, 3:14 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Esanders.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL