Maniphest T194900

Undefined variable: nonce in ResourceLoaderClientHtml.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	• mmodell
	May 17 2018, 7:46 PM

Description

Error Message

Notice: Undefined variable: nonce in /srv/mediawiki/php-1.32.0-wmf.4/includes/resourceloader/ResourceLoaderClientHtml.php on line 338

Stack Trace

Notes

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Initial support for Content Security Policy, disabled by default"	mediawiki/core	wmf/1.32.0-wmf.4	+46 -1 K

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• mmodell	T191051 1.32.0-wmf.5 deployment blockers
		Resolved	PRODUCTION ERROR	Krinkle	T194900 Undefined variable: nonce in ResourceLoaderClientHtml.php

Event Timeline

• mmodell created this task.May 17 2018, 7:46 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptMay 17 2018, 7:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• mmodell triaged this task as Unbreak Now! priority.May 17 2018, 7:47 PM

• mmodell added a parent task: T191050: 1.32.0-wmf.4 deployment blockers.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMay 17 2018, 7:47 PM

Change 433673 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@wmf/1.32.0-wmf.4] Revert "Initial support for Content Security Policy, disabled by default"

https://gerrit.wikimedia.org/r/433673

gerritbot added a project: Patch-For-Review.May 17 2018, 8:58 PM

Probably caused by $wgOut->getRlClient()->getHeadHtml(), in TimedMediaHandler specifically

https://github.com/wikimedia/mediawiki-extensions-TimedMediaHandler/blob/master/TimedMediaIframeOutput.php#L93

And patch by @Krinkle for cleaning up passing/handling of $nonce in https://gerrit.wikimedia.org/r/#/c/433622/

Change 433673 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.4] Revert "Initial support for Content Security Policy, disabled by default"

https://gerrit.wikimedia.org/r/433673

Lucas_Werkmeister_WMDE subscribed.May 17 2018, 9:29 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-17T22:53:15Z] <twentyafterfour> deploying https://gerrit.wikimedia.org/r/#/c/433673/ refs T194900 T191050

Stashbot mentioned this in T191050: 1.32.0-wmf.4 deployment blockers.May 17 2018, 10:53 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-17T23:22:01Z] <twentyafterfour@tin> Synchronized php-1.32.0-wmf.4/: sync https://gerrit.wikimedia.org/r/#/c/433673/ refs T194900 (duration: 09m 54s)

Would recommend to keep this task open until either master is fixed with a follow-up, or until the revert is merged in master as well.

Lowering priority, given the problematic commit was reverted in-branch, unblocking the train.

/cc @Bawolff @Legoktm

Krinkle lowered the priority of this task from Unbreak Now! to High.May 18 2018, 12:49 AM

Krinkle mentioned this in T194899: Undefined variable: userAgent in ApiCSPReport.php.

@Krinkle: ~~Unfortunately reverting didn't eliminate the errors. Train still blocked.~~

Correction: I didn't actually deploy the change correctly, trying again now.

Mentioned in SAL (#wikimedia-releng) [2018-05-18T01:26:49Z] <twentyafterfour> syncing wmf.4 again to deploy https://gerrit.wikimedia.org/r/#/c/433673/ refs T194900 T191050

Mentioned in SAL (#wikimedia-operations) [2018-05-18T01:27:00Z] <twentyafterfour> syncing wmf.4 again to deploy https://gerrit.wikimedia.org/r/#/c/433673/ refs T194900 T191050

Liuxinyu970226 unsubscribed.May 18 2018, 11:19 AM

Reedy removed a parent task: T191050: 1.32.0-wmf.4 deployment blockers.May 18 2018, 3:39 PM

Reedy added a parent task: T191051: 1.32.0-wmf.5 deployment blockers.

Krinkle removed a project: Patch-For-Review.May 19 2018, 11:34 PM

Fixed in master by https://gerrit.wikimedia.org/r/#/c/433622/.

• mmodell awarded a token.May 22 2018, 8:32 PM

• Vvjjkkii renamed this task from Undefined variable: nonce in ResourceLoaderClientHtml.php to ftcaaaaaaa.Jul 1 2018, 1:09 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Krinkle as the assignee of this task.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from ftcaaaaaaa to Undefined variable: nonce in ResourceLoaderClientHtml.php.Jul 2 2018, 6:37 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to Krinkle.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM

Undefined variable: nonce in ResourceLoaderClientHtml.phpClosed, ResolvedPublicPRODUCTION ERRORActions