Maniphest T195343

JADE submodule on tin is dirty
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 23 2018, 7:46 AM

Description

legoktm@tin:/srv/mediawiki-staging/php-1.32.0-wmf.4/extensions/JADE$ git status
HEAD detached at 1a26fc8
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	deleted:    tests/data/invalid_judgment_bad_json.json

no changes added to commit (use "git add" and/or "git commit -a")

Why is this file deleted? cc @mmodell

Details

	Subject	Repo	Branch	Lines +/-
	Don't use *.json for intentionally invalid JSON file	mediawiki/extensions/JADE	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned In: rEJADed24cacc22e8: Don't use *.json for intentionally invalid JSON file
Mentioned Here: T188914: scap fails on .eslintrc.json: invalid JSON

Event Timeline

Legoktm triaged this task as High priority.May 23 2018, 7:46 AM

Legoktm created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2018, 7:46 AM

Addshore subscribed.May 23 2018, 7:47 AM

Paladox updated the task description. (Show Details)May 23 2018, 7:47 AM

Paladox edited subscribers, added: • mmodell; removed: 20after4.

scap does lint json. That file is a test file which causes an invalid syntax error on purpose.

See also T188914

Change 437294 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/JADE@master] Don't use *.json for intentionally invalid JSON file

https://gerrit.wikimedia.org/r/437294

gerritbot added a project: Patch-For-Review.Jun 4 2018, 5:28 PM

I think scap's behavior is correct. We should never deploy invalid JSON files. In this case this isn't supposed to be used as JSON, so we can just rename it.

Legoktm mentioned this in rEJADed24cacc22e8: Don't use *.json for intentionally invalid JSON file.Jun 4 2018, 6:05 PM