Page MenuHomePhabricator

Migrate Special:ItemDisambiguation to use elastic
Open, Stalled, HighPublic

Description

https://gerrit.wikimedia.org/r/#/c/435079/ does this job for now but it's not nice and needs lots of clean up as pointed out in the patch.

Event Timeline

Ladsgroup triaged this task as High priority.May 28 2018, 10:34 AM
Ladsgroup created this task.

It’s not clear to me what the scope of this task is. As far as I can tell, the task title (migrate to use elastic) is actually fulfilled right now, but the comments in the patch point out several issues, and I’m not sure which ones of them should be part of this issue.

  • Special:ItemDisambiguation now does a prefix search, is case insensitive, and also supports searching for entity IDs instead of labels. I assume we want to revert all three of those changes? That could be done with a post-processing step after the main search.
  • The special page now uses a class from the API namespace (Wikibase\Repo\Api\EntitySearchHelper), which is a bit smelly – perhaps that class should move somewhere else. But is that part of this task?
  • Do we need to keep this special page at all, or should we investigate its uses and potentially remove it completely?
  • The gerrit comments also mention list=wbsearch in the API, is that related to this task?

It’s not clear to me what the scope of this task is. As far as I can tell, the task title (migrate to use elastic) is actually fulfilled right now, but the comments in the patch point out several issues, and I’m not sure which ones of them should be part of this issue.

  • Special:ItemDisambiguation now does a prefix search, is case insensitive, and also supports searching for entity IDs instead of labels. I assume we want to revert all three of those changes? That could be done with a post-processing step after the main search.

Yes.

  • The special page now uses a class from the API namespace (Wikibase\Repo\Api\EntitySearchHelper), which is a bit smelly – perhaps that class should move somewhere else. But is that part of this task?
  • Do we need to keep this special page at all, or should we investigate its uses and potentially remove it completely?

The huge amount of requests to it seem to come through installations of https://github.com/asciimoo/searx - especially framabee - in order to display infobox-like panels on search result pages. We should definitely continue to support this. Question is if this should go through Special:ItemDisambiguation or use some other mechanism.

  • The gerrit comments also mention list=wbsearch in the API, is that related to this task?
  • The gerrit comments also mention list=wbsearch in the API, is that related to this task?

If I understand correctly, that shouldn’t be a problem after all.

Question is if this should go through Special:ItemDisambiguation or use some other mechanism.

They should use action=wbsearchentities (like https://www.wikidata.org/w/api.php?action=wbsearchentities&search=abc&language=en) instead of hitting the special page.

Vvjjkkii renamed this task from Migrate Special:ItemDisambiguation to use elastic to o5baaaaaaa.Jul 1 2018, 1:07 AM
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
1339861mzb renamed this task from o5baaaaaaa to Migrate Special:ItemDisambiguation to use elastic.Jul 1 2018, 6:24 AM
1339861mzb changed the task status from Open to Stalled.Jul 1 2018, 6:26 AM
1339861mzb updated the task description. (Show Details)