Page MenuHomePhabricator
Create Task
Maniphest T197179

Deprecate OOUI HTMLFormField "notices" in favor of "inline help"
Closed, ResolvedPublic
Actions

Description

We should deprecate the parameters 'notice-message', 'notice-messages' and 'notice' for HTMLFormField, as well as the getNotices() method, and instead implement a boolean 'help-inline' parameter corresponding to the new OOUI FieldLayout 'helpInline' config option (T185752).

The notices were implement as a workaround for bad design of OOUI FieldLayout's help messages (T104423).

It seems that only user is CentralAuth's Special:GlobalRenameRequest, implemented in https://gerrit.wikimedia.org/r/291595 (T104299).

image.png (980×1 px, 135 KB)

Details

SubjectRepoBranchLines +/-
HTMLForm: Remove parameters 'notice', 'notice-messages', 'notice-message'mediawiki/coremaster+4 -50
HTMLForm: Deprecate parameters 'notice', 'notice-messages', 'notice-message'mediawiki/coremaster+26 -7
SpecialGlobalRenameRequest: Change 'notice-message' to 'help-message'mediawiki/extensions/CentralAuthmaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex triaged this task as Low priority.Jun 13 2018, 8:02 PM
matmarex created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 13 2018, 8:02 PM
Esanders mentioned this in T197004: Move inline help after field when align=top.Jun 19 2018, 9:19 PM
• Vvjjkkii renamed this task from Deprecate OOUI HTMLFormField "notices" in favor of "inline help" to 41aaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii removed matmarex as the assignee of this task.
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 41aaaaaaaa to Deprecate OOUI HTMLFormField "notices" in favor of "inline help".Jul 2 2018, 9:27 AM
CommunityTechBot assigned this task to matmarex.
CommunityTechBot lowered the priority of this task from High to Low.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
matmarex added a subtask: T197004: Move inline help after field when align=top.Jul 16 2018, 3:49 PM
Jdforrester-WMF closed subtask T197004: Move inline help after field when align=top as Resolved.Aug 16 2018, 9:04 PM
matmarex added a subscriber: Esanders.Aug 16 2018, 10:30 PM

instead implement a boolean 'help-inline' parameter corresponding to the new OOUI FieldLayout 'helpInline' config option

This is happening in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/439925 (it also defaults to true).

gerritbot subscribed.Aug 17 2018, 9:22 PM

Change 453486 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] HTMLForm: Deprecate parameters 'notice', 'notice-messages', 'notice-message'

https://gerrit.wikimedia.org/r/453486

gerritbot added a project: Patch-For-Review.Aug 17 2018, 9:22 PM

Change 453487 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] HTMLForm: Remove parameters 'notice', 'notice-messages', 'notice-message'

https://gerrit.wikimedia.org/r/453487

gerritbot added a comment.Aug 17 2018, 9:26 PM

Change 453488 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/CentralAuth@master] SpecialGlobalRenameRequest: Change 'notice-message' to 'help-message'

https://gerrit.wikimedia.org/r/453488

matmarex added a comment.Aug 17 2018, 9:27 PM

Changes to Special:GlobalRenameRequest:

BeforeAfter
image.png (980×1 px, 124 KB)
image.png (980×1 px, 122 KB)
gerritbot added a comment.Aug 17 2018, 9:48 PM

Change 453488 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] SpecialGlobalRenameRequest: Change 'notice-message' to 'help-message'

https://gerrit.wikimedia.org/r/453488

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 17 2018, 10:00 PM
gerritbot added a comment.Aug 29 2018, 8:42 PM

Change 453486 merged by jenkins-bot:
[mediawiki/core@master] HTMLForm: Deprecate parameters 'notice', 'notice-messages', 'notice-message'

https://gerrit.wikimedia.org/r/453486

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)); removed MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 29 2018, 9:00 PM
Jdforrester-WMF removed a project: Patch-For-Review.Aug 29 2018, 10:33 PM
Jdforrester-WMF subscribed.

Now deprecated; should we close this as Resolved, or do you want to actually wait for "Removed" to be the state, despite the task title? :-)

matmarex closed this task as Resolved.Aug 30 2018, 9:34 PM
gerritbot added a comment.Oct 24 2018, 5:14 PM

Change 453487 merged by jenkins-bot:
[mediawiki/core@master] HTMLForm: Remove parameters 'notice', 'notice-messages', 'notice-message'

https://gerrit.wikimedia.org/r/453487

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 24 2018, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL