Page MenuHomePhabricator
Create Task
Maniphest T197262

PHP Fatal Error: Class undefined: PageTriageMarkAsReviewedPresentationModel
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Noticed this in 1.32.0-wmf.8

#0 /srv/mediawiki/php-1.32.0-wmf.8/extensions/Echo/includes/formatters/EventPresentationModel.php(99): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.32.0-wmf.8/extensions/Echo/includes/formatters/EchoEventFormatter.php(58): EchoEventPresentationModel::factory(EchoEvent, LanguageEn, User)
#2 /srv/mediawiki/php-1.32.0-wmf.8/extensions/Echo/includes/DataOutputFormatter.php(171): EchoEventFormatter->format(EchoEvent)
#3 /srv/mediawiki/php-1.32.0-wmf.8/extensions/Echo/includes/DataOutputFormatter.php(136): EchoDataOutputFormatter::formatNotification(EchoEvent, User, string, LanguageEn)
#4 /srv/mediawiki/php-1.32.0-wmf.8/extensions/Echo/includes/api/ApiEchoNotifications.php(265): EchoDataOutputFormatter::formatOutput(EchoNotification, string, User, LanguageEn)
#5 /srv/mediawiki/php-1.32.0-wmf.8/extensions/Echo/includes/api/ApiEchoNotifications.php(105): ApiEchoNotifications->getPropList(User, array, array, integer, NULL, string, NULL, boolean, boolean)
#6 /srv/mediawiki/php-1.32.0-wmf.8/extensions/Echo/includes/api/ApiEchoNotifications.php(36): ApiEchoNotifications->getLocalNotifications(array)
#7 /srv/mediawiki/php-1.32.0-wmf.8/includes/api/ApiQuery.php(249): ApiEchoNotifications->execute()
#8 /srv/mediawiki/php-1.32.0-wmf.8/includes/api/ApiMain.php(1581): ApiQuery->execute()
#9 /srv/mediawiki/php-1.32.0-wmf.8/includes/api/ApiMain.php(535): ApiMain->executeAction()
#10 /srv/mediawiki/php-1.32.0-wmf.8/includes/api/ApiMain.php(506): ApiMain->executeActionWithErrorHandling()
#11 /srv/mediawiki/php-1.32.0-wmf.8/api.php(83): ApiMain->execute()
#12 /srv/mediawiki/w/api.php(3): include(string)
#13 {main}

Details

SubjectRepoBranchLines +/-
Fix event presentation class namesmediawiki/extensions/PageTriagewmf/1.32.0-wmf.999+6 -3
Fix event presentation class namesmediawiki/extensions/PageTriagewmf/1.32.0-wmf.8+6 -3
Fix event presentation class namesmediawiki/extensions/PageTriagemaster+6 -3
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Jun 14 2018, 7:27 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 14 2018, 7:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thcipriani triaged this task as High priority.Jun 14 2018, 7:44 PM

this is spamming the error logs quite a bit, not quite to the level of rollback for 1.32.0-wmf.8, but it's close.

matmarex subscribed.Jun 14 2018, 7:52 PM

Probably caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/437660 rEPTRf255e663ac49: Namespace classes and give each its own file?

matmarex added a subscriber: MusikAnimal.Jun 14 2018, 7:53 PM
MaxSem claimed this task.Jun 14 2018, 8:11 PM
MaxSem added a project: Community-Tech-Sprint.
gerritbot subscribed.Jun 14 2018, 8:13 PM

Change 440399 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/PageTriage@master] Fix event presentation class names

https://gerrit.wikimedia.org/r/440399

gerritbot added a project: Patch-For-Review.Jun 14 2018, 8:13 PM
gerritbot added a comment.Jun 14 2018, 8:46 PM

Change 440399 merged by MaxSem:
[mediawiki/extensions/PageTriage@master] Fix event presentation class names

https://gerrit.wikimedia.org/r/440399

gerritbot added a comment.Jun 14 2018, 9:27 PM

Change 440474 had a related patch set uploaded (by Thcipriani; owner: MaxSem):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.8] Fix event presentation class names

https://gerrit.wikimedia.org/r/440474

gerritbot added a comment.Jun 14 2018, 9:31 PM

Change 440475 had a related patch set uploaded (by Thcipriani; owner: MaxSem):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.999] Fix event presentation class names

https://gerrit.wikimedia.org/r/440475

gerritbot added a comment.Jun 14 2018, 9:34 PM

Change 440474 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.8] Fix event presentation class names

https://gerrit.wikimedia.org/r/440474

Stashbot subscribed.Jun 14 2018, 9:44 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-14T21:44:05Z] <thcipriani@deploy1001> Synchronized php-1.32.0-wmf.8/extensions/PageTriage/includes/Hooks.php: [[gerrit:440474|Fix event presentation class names]] T197262 (duration: 00m 52s)

gerritbot added a comment.Jun 14 2018, 9:46 PM

Change 440475 merged by MaxSem:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.999] Fix event presentation class names

https://gerrit.wikimedia.org/r/440475

MaxSem closed this task as Resolved.Jun 14 2018, 9:55 PM
MaxSem moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.
Stashbot added a comment.Jun 14 2018, 9:56 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-14T21:56:56Z] <thcipriani@deploy1001> Synchronized php-1.32.0-wmf.999/extensions/PageTriage/includes/Hooks.php: [[gerrit:440475|Fix event presentation class names]] T197262 (duration: 00m 57s)

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 30 2018, 12:00 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).
• Vvjjkkii renamed this task from PHP Fatal Error: Class undefined: PageTriageMarkAsReviewedPresentationModel to tzaaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed MaxSem as the assignee of this task.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: MaxSem; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from tzaaaaaaaa to PHP Fatal Error: Class undefined: PageTriageMarkAsReviewedPresentationModel.Jul 2 2018, 7:23 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to MaxSem.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: MaxSem.
Niharika moved this task from Q1 2018-19 to Archive on the Community-Tech-Sprint board.Jul 3 2018, 7:38 PM
Niharika edited projects, added Community-Tech; removed Community-Tech-Sprint.Jul 9 2018, 5:30 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 9 2018, 5:30 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL