Maniphest T197581

Cannot access user contributions of user without user page on mobile
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Cirdan
	Jun 18 2018, 10:13 AM

Description

In the mobile diff, a click on the user name usually leads to their mobile user page, where one finds a link to their contributions. For users without a user page (aka red link), however, the mobile website launches into the editor instead of displaying the user page. Going back a step in the browser returns to the diff.

As far as I can see, for these user accounts there is no way to reach the user contributions by clicking a link. Instead, one has to manually go to the Special:Contributions URL.

Replication instructions

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/349080
Click user name
Click contributions

Actual: User cannot navigate to contributions

Acceptance criteria

Screen Shot 2018-06-18 at 4.41.18 PM.png (349×496 px, 29 KB)

The user on a diff page should link to the user page in view mode NOT edit mode

e.g. https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=User:Mr_Selenium

QA steps

Follow the replication steps. The editor should not load when the username is clicked on.
IT may help to compare this behaviour to https://en.m.wikipedia.org/wiki/Special:MobileDiff/349080 to understand how this worked before.

Details

	Subject	Repo	Branch	Lines +/-
	Username on mobile diff should never point to editor	mediawiki/extensions/MobileFrontend	master	+6 -1

Customize query in gerrit

Related Objects

Mentioned In: T222911: Should red links to user pages link to "view" mode rather than "edit" mode?
T204078: Cannot access user contributions of user without user page on mobile by following a red link on a talk page
T201339: Cannot access user contributions when following red link to user page on mobile

Event Timeline

Cirdan created this task.Jun 18 2018, 10:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2018, 10:13 AM

Nope. That's a new one! Thanks for the report!

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jun 18 2018, 11:41 PM

ovasileva triaged this task as Medium priority.Jun 19 2018, 3:10 PM

Change 441145 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Username on mobile diff should never point to editor

https://gerrit.wikimedia.org/r/441145

gerritbot added a project: Patch-For-Review.Jun 19 2018, 11:36 PM

Jdlrobson updated the task description. (Show Details)Jun 19 2018, 11:36 PM

Jdlrobson updated the task description. (Show Details)

Ammarpad subscribed.Jun 20 2018, 2:29 PM

Change 441145 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Username on mobile diff should never point to editor

https://gerrit.wikimedia.org/r/441145

A patch got merged to fix this. Please take a look when you have time to confirm that this behaviour is the correct behaviour

this is working as intended, moving to QA

• alexhollender_WMF reassigned this task from • alexhollender_WMF to ABorbaWMF.Jun 26 2018, 9:04 PM

• alexhollender_WMF moved this task from Needs Design Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.

• alexhollender_WMF subscribed.

ovasileva added a project: User-notice.Jun 27 2018, 2:40 PM

ovasileva set the point value for this task to 1.Jun 27 2018, 5:10 PM

Looks good to me on Beta
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/349080
Clicking on contributions now goes to the expected location

looks good

When will this go into production? Week after next (no new MediaWiki version next week)?

merged on Tue 26 so will be cut in the branch next tuesday (3rd July), so this should go into 1.32.0-wmf.12.
Looks like 1.32.0-wmf.12 is scheduled for July 10th if things go to plan. There are no deploys next week, but bear in mind this weeks train was rolled back so may take a little longer.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 5:02 PM

• Vvjjkkii renamed this task from Cannot access user contributions of user without user page on mobile to yqaaaaaaaa.Jul 1 2018, 1:03 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed ABorbaWMF as the assignee of this task.

• Vvjjkkii raised the priority of this task from Low to High.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii edited subscribers, added: ABorbaWMF; removed: gerritbot, Aklapper.

CommunityTechBot renamed this task from yqaaaaaaaa to Cannot access user contributions of user without user page on mobile.Jul 2 2018, 5:00 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to ABorbaWMF.

CommunityTechBot lowered the priority of this task from High to Low.

CommunityTechBot set the point value for this task to 1.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: ABorbaWMF.

Cirdan added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 2 2018, 9:59 AM

Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Jul 5 2018, 8:59 PM

Liuxinyu970226 awarded a token.Jul 9 2018, 4:09 AM

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jul 12 2018, 4:40 AM

Cirdan mentioned this in T201339: Cannot access user contributions when following red link to user page on mobile.Aug 6 2018, 6:09 PM

MBinder_WMF moved this task from Triaged but Future to Readers-Web-Kanbanana-Board-2018-19-Q1 on the Web-Team-Backlog board.Aug 23 2018, 12:00 AM

MBinder_WMF edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.

Cirdan mentioned this in T204078: Cannot access user contributions of user without user page on mobile by following a red link on a talk page.Sep 11 2018, 6:03 PM

RandomDSdevel awarded a token.Oct 1 2018, 1:05 AM

Cirdan mentioned this in T222911: Should red links to user pages link to "view" mode rather than "edit" mode?.May 9 2019, 4:57 PM

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM

	F22358231: Screen Shot 2018-06-18 at 4.41.18 PM.png
	Jun 18 2018, 11:41 PM

	F22901464: image.png
	Jun 28 2018, 1:09 AM

	F22900197: image.png
	Jun 28 2018, 1:09 AM

	F22899840: image.png
	Jun 28 2018, 1:09 AM

	F22900070: image.png
	Jun 28 2018, 1:09 AM

Cannot access user contributions of user without user page on mobileClosed, ResolvedPublic1 Estimated Story PointsActions