Page MenuHomePhabricator

Cross-post comments on Gerrit to Phabricator
Closed, DeclinedPublic

Description

Problem
A lot of users (Product Owners, Designers, Community Members, etc.) do not use or watch Gerrit, but they do use Phabricator.

Developers will sometimes ask product, design, or community related questions on Gerrit which have to be answered on Phabricator. Since the users that need to see the question do not use Gerrit, the comment has to manually be copied over (See: T132220#4128619 & T132220#4130623).

Solution
It would be really helpful if comments from Gerrit were cross-posted to Phabricator.

If possible, it would be awesome if it posted under the appropriate user's account. and if that's not possible, I think it should be under the @gerritbot account and reference the Phabricator user and quote the comment with a url to the specific comment (i.e. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/422063#message-5fd9f2eb16d390c89b9df0a181fce48e78a3155e)

Event Timeline

Gerrit is for comments related to reviewing specific code. Phabricator Maniphest is for commenting on tasks.
One idea was to move from Gerrit to Phabricator Differential in T191182. This is not planned anymore.

GerritBot already does cross-post those comments which include a code review decision on Gerrit to Phabricator.
This task is missing a use case that explains why duplicating content everywhere so people receive even more notifications that they won't read helps.
Proposing to decline this task.

dbarratt updated the task description. (Show Details)
dbarratt updated the task description. (Show Details)

Gerrit is for comments related to reviewing specific code. Phabricator Maniphest is for commenting on tasks.
One idea was to move from Gerrit to Phabricator Differential in T191182. This is not planned anymore.

GerritBot already does cross-post those comments which include a code review decision on Gerrit to Phabricator.
This task is missing a use case that explains why duplicating content everywhere so people receive even more notifications that they won't read helps.
Proposing to decline this task.

I updated the task description. The problem is that Gerrit is basically only used by developers, and Phabricator is used by everyone. But the conversations on Gerrit will sometimes move into a realm that developers ought not be the decision makers on. Of course at this point the developers have had a whole conversation about it and then need to bring other people up to speed.

As far as the notifications go, personally, I would just turn off Gerrit notifications. I don't have a problem with Gerrit, but I think it's somewhat problematic that it is effectively a developer-only space.

I don't see how the proposed technical action (flooding Phab tasks with lots of maybe or maybe not helpful comments in Gerrit) is a solution to the social problem that people sometimes discuss certain things in a place that's not the most suited place.

I don't see how the proposed technical action (flooding Phab tasks with lots of maybe or maybe not helpful comments in Gerrit) is a solution to the social problem that people sometimes discuss certain things in a place that's not the most suited place.

I'm always open to alternatives. :)

we could certainly exclude "Patch Set" upload comments as well as anything by jenkins-bot (or any other automated messages). That would leave us with actual comments/code reviews.

If it were posted under the @gerritbot account (and quoted) people could easily filter out notifications from @gerritbot.

Migrating from gerrit to Differential was the appropriate solution to this problem. Perhaps some non-developers can show support in T191182: Stop using Differential for code review. I seem to be the only one who is against it.

Vvjjkkii renamed this task from Cross-post comments on Gerrit to Phabricator to bmaaaaaaaa.Jul 1 2018, 1:02 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
Tacsipacsi renamed this task from bmaaaaaaaa to Cross-post comments on Gerrit to Phabricator.Jul 1 2018, 9:58 AM
Tacsipacsi raised the priority of this task from High to Needs Triage.
Tacsipacsi updated the task description. (Show Details)
Tacsipacsi added subscribers: gerritbot, Aklapper, Tacsipacsi.