Page MenuHomePhabricator
Create Task
Maniphest T197759

Preview shows categories in alphabetical order instead of original one
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Find an article with several categories.
  2. Open it for editing in NWE.
  3. Change something.
  4. Preview.

Expected:
The categories should be shown in source order.

Actual:
The categories are shown in alphabetical order.

Details

SubjectRepoBranchLines +/-
init.mw.ArticleTarget: make sure renderCategories preserves ordermediawiki/extensions/VisualEditormaster+7 -1
init.mw.ArticleTarget: sort categories correctly in renderCategoriesmediawiki/extensions/VisualEditormaster+0 -13
Customize query in gerrit

Event Timeline

Schnark created this task.Jun 20 2018, 7:40 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 20 2018, 7:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders added a subscriber: DLynch.Jun 20 2018, 11:12 AM
• Deskana added a project: Parsoid.Jun 28 2018, 2:43 PM
• Deskana subscribed.

A problem with the preview HTML, i.e. Parsoid?

• Vvjjkkii renamed this task from Preview shows categories in alphabetical order instead of original one to 0laaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 0laaaaaaaa to Preview shows categories in alphabetical order instead of original one.Jul 2 2018, 9:47 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
ssastry subscribed.Jul 9 2018, 3:45 AM
In T197759#4322052, @Deskana wrote:

A problem with the preview HTML, i.e. Parsoid?

I don't think so. Parsoid preserves source order.

[subbu@earth:~/work/wmf/parsoid] echo "a [[Category:Foo]] [[Category:Bar]]" | parse.js --normalize=parsoid

<p>a</p>
<link rel="mw:PageProp/Category" href="./Category:Foo"/> <link rel="mw:PageProp/Category" href="./Category:Bar"/>

See the output order when fed HTML.

[subbu@earth:~/work/wmf/parsoid] echo "a [[Category:Foo]] [[Category:Bar]]" | parse.js --normalize=parsoid | parse.js --html2wt

a
[[Category:Foo]] 
[[Category:Bar]]
ssastry removed a project: Parsoid.Jul 9 2018, 3:45 AM
Schnark added a comment.Jul 9 2018, 7:17 AM

Indeed, ve.init.mw.ArticleTarget.prototype.renderCategories does the sorting, and actually seems to do so on purpose, though I don't really understand why (since the hidden cat flag is determined async, the categories might be in random order after the promises are all done, but sorting according to either the sortkey or the category name just doesn't make sense).

gerritbot subscribed.Jul 9 2018, 2:26 PM

Change 444599 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] init.mw.ArticleTarget: sort categories correctly in renderCategories

https://gerrit.wikimedia.org/r/444599

gerritbot added a project: Patch-For-Review.Jul 9 2018, 2:26 PM
DLynch claimed this task.Jul 9 2018, 2:27 PM
DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.
DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Jul 9 2018, 5:50 PM

Change 444599 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] init.mw.ArticleTarget: sort categories correctly in renderCategories

https://gerrit.wikimedia.org/r/444599

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 9 2018, 6:00 PM
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.Jul 9 2018, 7:45 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Jul 10 2018, 5:24 PM

Change 444920 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] init.mw.ArticleTarget: make sure renderCategories preserves order

https://gerrit.wikimedia.org/r/444920

gerritbot added a project: Patch-For-Review.Jul 10 2018, 5:24 PM
gerritbot added a comment.Jul 10 2018, 8:03 PM

Change 444920 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] init.mw.ArticleTarget: make sure renderCategories preserves order

https://gerrit.wikimedia.org/r/444920

Jdforrester-WMF removed a project: Patch-For-Review.Jul 10 2018, 8:12 PM
Ryasmeen added a project: Verified.Jul 10 2018, 11:17 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 11 2018, 12:01 AM
• Deskana closed this task as Resolved.Jul 12 2018, 2:53 PM
• Deskana triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits