Maniphest T197771

Couple errors with Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Jun 20 2018, 9:38 AM

Description

Doing a check experimental on WikibaseLexeme triggers quibble-composer-mysql-php70-docker which fails a couple PHPUnit tests.

Debug logs: P7271 and P7272

1) Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::testAddedStatementsWithLexmesAsTargetDisplayLemma
Hamcrest\AssertionError: Expected: is valid html piece having child (with tag name "ins" and having child (with tag name "a" and having text contents "foo"))
     but: valid html piece having no children (with tag name "ins" and having child (with tag name "a" and having text contents "foo")) 
Actual html:
<tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">property / <a title="Property:P1" href="/index.php/Property:P1">P1</a></td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span><a title="Lexeme:L1" href="/index.php/Lexeme:L1">L1</a> <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span></span></ins></div></td></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">property / <a title="Property:P1" href="/index.php/Property:P1">P1</a>: <a title="Lexeme:L1" href="/index.php/Lexeme:L1">L1</a> <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span> / rank</td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span>Normal rank</span></ins></div></td></tr>

gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:115
gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:52
gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest.php:28
gtests/phpunit/HamcrestPHPUnitIntegration.php:31
gextensions/WikibaseLexeme/tests/phpunit/mediawiki/Diff/LexemeDiffVisualizerIntegrationTest.php:109
gtests/phpunit/MediaWikiTestCase.php:469
gmaintenance/doMaintenance.php:94

2) Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::testAddedStatementsOnFormsTargettingFormsAreDisplayedAsLinks
Hamcrest\AssertionError: Expected: is valid html piece having child (with tag name "ins" and having child (with tag name "a" and having text contents "baz"))
     but: valid html piece having no children (with tag name "ins" and having child (with tag name "a" and having text contents "baz")) 
Actual html:
<tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Form / property / <a title="Property:P1" href="/index.php/Property:P1">P1</a></td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span><a title="Lexeme:L1" href="/index.php/Lexeme:L1">L1-F1</a> <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span></span></ins></div></td></tr><tr><td colspan="2" class="diff-lineno"></td><td colspan="2" class="diff-lineno">Form / property / <a title="Property:P1" href="/index.php/Property:P1">P1</a>: <a title="Lexeme:L1" href="/index.php/Lexeme:L1">L1-F1</a> <span class="error wb-format-error">The value's type "wikibase-entityid" does not match property's type "string".</span> / rank</td></tr><tr><td colspan="2">&nbsp;</td><td class="diff-marker">+</td><td class="diff-addedline"><div><ins class="diffchange diffchange-inline"><span>Normal rank</span></ins></div></td></tr>

gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:115
gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest/MatcherAssert.php:52
gvendor/hamcrest/hamcrest-php/hamcrest/Hamcrest.php:28
gtests/phpunit/HamcrestPHPUnitIntegration.php:31
gextensions/WikibaseLexeme/tests/phpunit/mediawiki/Diff/LexemeDiffVisualizerIntegrationTest.php:440
gtests/phpunit/MediaWikiTestCase.php:469
gmaintenance/doMaintenance.php:94

Dummy change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/435980
Failed build: https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php70-docker/2297/

Note in both case they show: The value's type "wikibase-entityid" does not match property's type "string".

Details

	Subject	Repo	Branch	Lines +/-
	Get rid of Reflection hack used to override factory member	mediawiki/extensions/WikibaseLexeme	master	+71 -34

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T190097 Migrate all CI jobs from Nodepool, deprecate its use
Resolved	hashar	T183512 [EPIC] Migrate Mediawiki jobs from Nodepool to Docker
Resolved	Addshore	T200508 Run WikibaseLexeme tests with Wikibase CI
Resolved	Addshore	T201336 Use Quibble for WikibaseLexeme CI
Resolved	Addshore	T197771 Couple errors with Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest

Event Timeline

hashar created this task.Jun 20 2018, 9:38 AM

hashar updated the task description. (Show Details)Jun 20 2018, 9:45 AM

hashar added a parent task: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 25 2018, 12:42 PM

hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.

hashar mentioned this in rEWLEfebbd17a36a1: Update patch set 3.Jun 28 2018, 11:51 AM

Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Jun 29 2018, 9:29 AM

Lydia_Pintscher added a subscriber: WMDE-leszek.

Addshore added subscribers: Tarrow, Addshore.Jun 29 2018, 11:50 AM

• Vvjjkkii renamed this task from Couple errors with Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest to olaaaaaaaa.Jul 1 2018, 1:02 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

CommunityTechBot renamed this task from olaaaaaaaa to Couple errors with Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest.Jul 2 2018, 9:55 AM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Addshore triaged this task as Medium priority.Aug 6 2018, 4:28 PM

Addshore mentioned this in T200508: Run WikibaseLexeme tests with Wikibase CI.

Addshore added a parent task: T200508: Run WikibaseLexeme tests with Wikibase CI.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/450054/ is related

Change 450054 had a related patch set uploaded (by Addshore; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Get rid of Reflection hack used to override factory member

https://gerrit.wikimedia.org/r/450054

gerritbot added a project: Patch-For-Review.Aug 6 2018, 4:49 PM

Addshore mentioned this in rEWLE014a236498dd: Get rid of Reflection hack used to override factory member.Aug 6 2018, 4:51 PM

Addshore mentioned this in rEWLEb929bb6d45ef: Get rid of Reflection hack used to override factory member.Aug 6 2018, 4:56 PM

Addshore mentioned this in rEWLE9d996c2f4729: Get rid of Reflection hack used to override factory member.Aug 6 2018, 5:53 PM

Addshore added a parent task: T201336: Use Quibble for WikibaseLexeme CI.Aug 6 2018, 5:55 PM

Addshore removed a parent task: T200508: Run WikibaseLexeme tests with Wikibase CI.

Addshore removed a parent task: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.

Change 450054 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Get rid of Reflection hack used to override factory member

https://gerrit.wikimedia.org/r/450054