Page MenuHomePhabricator
Create Task
Maniphest T198140

Prevent updateInputSize() in mw.rcfilters.ui.FilterTagMultiselectWidget
Closed, ResolvedPublic
Actions

Description

  • Causes a forced reflow because of the height measurement in updateIfHeightChanged in response to item removals, even though (we think) no items were actually removed
  • Verify ‘resize’ event (from updateIfHeightChanged) is not listened to
  • And/or address event-based cause (updateInputSize called for 0-item removals?)

Details

SubjectRepoBranchLines +/-
RCFilters: Only attempt to remove tag if we can find an item for itmediawiki/corewmf/1.32.0-wmf.10+8 -2
RCFilters: Only attempt to remove tag if we can find an item for itmediawiki/coremaster+8 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh triaged this task as Medium priority.Jun 25 2018, 7:55 PM
kostajh created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2018, 7:55 PM
JTannerWMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Jun 26 2018, 6:04 PM
JTannerWMF moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot subscribed.Jun 26 2018, 8:25 PM

Change 442197 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] RC Filters: Only attempt to remove tag if we can find an item for it

https://gerrit.wikimedia.org/r/442197

gerritbot added a project: Patch-For-Review.Jun 26 2018, 8:25 PM
gerritbot added a comment.Jun 27 2018, 12:34 AM

Change 442197 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Only attempt to remove tag if we can find an item for it

https://gerrit.wikimedia.org/r/442197

Catrope moved this task from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 27 2018, 12:57 AM
gerritbot added a comment.Jun 27 2018, 10:50 PM

Change 442745 had a related patch set uploaded (by Catrope; owner: Kosta Harlan):
[mediawiki/core@wmf/1.32.0-wmf.10] RCFilters: Only attempt to remove tag if we can find an item for it

https://gerrit.wikimedia.org/r/442745

gerritbot added a comment.Jun 27 2018, 11:44 PM

Change 442745 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.10] RCFilters: Only attempt to remove tag if we can find an item for it

https://gerrit.wikimedia.org/r/442745

Stashbot mentioned this in T197168: Fix slow Watchlist load and interaction times.Jun 28 2018, 12:32 AM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-06-28T00:32:49Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.10/includes: Watchlist perf patches for SWAT, part 1 (T197168, T198140, T198142) (duration: 01m 13s)

Stashbot mentioned this in T198142: Speed up lazy-building of menu.Jun 28 2018, 12:32 AM

Mentioned in SAL (#wikimedia-operations) [2018-06-28T00:33:57Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.10/resources: Watchlist perf patches for SWAT, part 2 (T197168, T198140, T198142) (duration: 00m 57s)

Etonkovidova closed this task as Resolved.Jun 29 2018, 7:32 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 6:01 PM
• Vvjjkkii renamed this task from Prevent updateInputSize() in mw.rcfilters.ui.FilterTagMultiselectWidget to fbaaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed kostajh as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
JJMC89 renamed this task from fbaaaaaaaa to Prevent updateInputSize() in mw.rcfilters.ui.FilterTagMultiselectWidget.Jul 1 2018, 4:08 AM
JJMC89 closed this task as Resolved.
JJMC89 assigned this task to kostajh.
JJMC89 lowered the priority of this task from High to Medium.
JJMC89 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
JJMC89 updated the task description. (Show Details)
CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 5 2018, 7:07 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 5 2018, 7:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL