Maniphest T198372

Make sure people understand which template prevents them to moving a file to Commons
Open, MediumPublic
Actions

Assigned To

None

Authored By

	JStrodt_WMDE
	Jun 28 2018, 7:18 AM

Description

Motivation

both fail with The file cannot be imported, because it is marked as Vorlage:NoCommons. Wikimedia Commons does not allow such files., but they actually fail because of the bild-pd-alt-100 template that pulls the NoCommons template in. That is not very intuitive. Unfortunately, at this point the FileImporter cannot distinguish if a template was pulled in or existent in pure wiki text.

Task
Make it possible for people to understand why their file was not moved, e.g. by linking to the config file and showing a list of all possible options

Related Objects

Mentioned Here: T194132: Parse the file info wikitext to forbid files with a wrong licence

Event Timeline

JStrodt_WMDE created this task.Jun 28 2018, 7:18 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2018, 7:18 AM

JStrodt_WMDE added a project: Move-Files-To-Commons.Jun 28 2018, 7:18 AM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJun 28 2018, 7:18 AM

I can reproduce the steps:

The source page contains bild-pd-alt-100, which is a bad template according to https://www.mediawiki.org/wiki/Extension:FileImporter/Data/de.wikipedia.
The bild-pd-alt-100 template indirectly includes the NoCommons template, which is also a bad template.
Our validator finds both. Which one is found first is effectively random.
Currently only the first bad template is reported. In the examples this is the NoCommons template, which does not appear directly in the wikitext, leading to some confusion.

Proposed solution:

List all bad templates, not only the first found.
Note we can not differentiate between direct and indirect template inclusions.

I changed the description (and title) from "What is this bug?" to "Prevent the confusion". We have not completely defined the solution yet, which is why I am setting it to stalled now.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptSep 10 2019, 10:21 PM

Reiterating what Lea_WMDE said, this is tricky because we don't want to encourage users to go back to the source wiki and simply remove a forbidden template. The presence of these templates will normally mean that the file shouldn't be imported as it is, and is an informational message, not one to be worked-around.

We think we currently show the template name. This should be discussed, maybe we want to remove it.

The frequency is very low relative to other errors.

real68er awarded a token.Jun 10 2020, 5:46 AM

real68er subscribed.

thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Nov 2 2020, 7:55 AM

In T198372#4393145, @Lea_WMDE wrote:

We have not completely defined the solution yet, which is why I am setting it to stalled now.

The previous comments don't explain who or what (task?) exactly this task is stalled on ("If a report is waiting for further input (e.g. from its reporter or a third party) and can currently not be acted on"). Hence resetting task status, as tasks should not be stalled (and then potentially forgotten) for years for unclear reasons.

(Smallprint, as general orientation for task management:
If you wanted to express that nobody is currently working on this task, then the assignee should be removed and/or priority could be lowered instead.
If work on this task is blocked by another task, then that other task should be added via Edit Related Tasks... → Edit Subtasks.
If this task is stalled on an upstream project, then the Upstream tag should be added.
If this task requires info from the task reporter, then there should be instructions which info is needed.
If this task needs retesting, then the TestMe tag should be added.
If this task is out of scope and nobody should ever work on this, or nobody else managed to reproduce the situation described here, then it should have the "Declined" status.
If the task is valid but should not appear on some team's workboard, then the team project tag should be removed while the task has another active project tag.)

I think the best solution is to add text to [[:de:Vorlage:Bild-PD-alt-100]] or [[:de:Vorlage:NoCommons]] telling the user what to do. That way we do not have to make the code more complex and it is a wiki problem that needs to be fixed on wiki.

I just checked the code it seems that this issue was fixed in T194132: Parse the file info wikitext to forbid files with a wrong licence. In the error message added there we show the blocking template / category.

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Nov 12 2020, 11:20 AM

I think what was written in the comment T198372#4380653 still applies. With T194132 we list only the first reason why a file can not be imported. But we neither list all of the templates and categories, nor can we distinguish between direct and indirect template usages. I.e. the task asking for "which template" is still unresolved, as far as I'm aware of.

In T198372#6620285, @thiemowmde wrote:

I think what was written in the comment T198372#4380653 still applies. With T194132 we list only the first reason why a file can not be imported. But we neither list all of the templates and categories, nor can we distinguish between direct and indirect template usages. I.e. the task asking for "which template" is still unresolved, as far as I'm aware of.

Ah sorry, my bad. You're right. These cases remain a mystery to the user. - Yes, we should keep the ticket open to cover these missing pieces.

Make sure people understand which template prevents them to moving a file to CommonsOpen, MediumPublicActions

Description

Related Objects

Event Timeline

Make sure people understand which template prevents them to moving a file to Commons
Open, MediumPublic
Actions