Page MenuHomePhabricator
Create Task
Maniphest T199334

Temporarily add config and use it to use change_tag_def table instead of change_tag table for Special:Tags
Closed, ResolvedPublic
Actions

Description

Special:Tags is one of the slowest special pages as a consequence of the change_tag table not being normalized. We can wait until the migration is completely done or deviate a little bit from the migration plan and introduce another (also temporarily) config variable to read from change_tag_def table when we are at MIGRATION_WRITE_BOTH state and the maintenance script has been ran. This is such a low-hanging and big fruit that I failed to resist the temptation and suggested it to our PM and she agreed we can do it. Basically, it fixes a user-facing issue while the backend migration is still in progress.

Details

SubjectRepoBranchLines +/-
Enable reading from change_tag_def everywhereoperations/mediawiki-configmaster+1 -7
Enable reading from the new backend for Special:Tags in several large wikisoperations/mediawiki-configmaster+4 -0
Enable new backend for Special:Tags in fawikisourceoperations/mediawiki-configmaster+5 -0
labs: Set $wgTagStatisticsNewTable to trueoperations/mediawiki-configmaster+4 -0
Add config to use change_tag_def table for Special:Tagsmediawiki/coremaster+94 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Jul 11 2018, 2:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2018, 2:44 PM
gerritbot subscribed.Jul 11 2018, 2:45 PM

Change 445179 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Add config to use change_tag_def table for Special:Tags

https://gerrit.wikimedia.org/r/445179

gerritbot added a project: Patch-For-Review.Jul 11 2018, 2:45 PM
Ladsgroup updated the task description. (Show Details)Jul 11 2018, 2:46 PM
Ladsgroup moved this task from Incoming to Peer Review on the Wikidata-Campsite board.
gerritbot added a comment.Jul 11 2018, 10:13 PM

Change 445179 merged by jenkins-bot:
[mediawiki/core@master] Add config to use change_tag_def table for Special:Tags

https://gerrit.wikimedia.org/r/445179

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 11 2018, 11:00 PM
• Jonas moved this task from Peer Review to Done on the Wikidata-Campsite board.Jul 12 2018, 10:01 AM
Ladsgroup moved this task from Done to Test (Verification) on the Wikidata-Campsite board.Jul 12 2018, 10:22 AM
gerritbot added a comment.Jul 13 2018, 10:14 AM

Change 445586 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/mediawiki-config@master] labs: Set $wgTagStatisticsNewTable to true

https://gerrit.wikimedia.org/r/445586

gerritbot added a comment.Jul 13 2018, 10:20 AM

Change 445586 merged by jenkins-bot:
[operations/mediawiki-config@master] labs: Set $wgTagStatisticsNewTable to true

https://gerrit.wikimedia.org/r/445586

gerritbot added a comment.Jul 18 2018, 12:05 PM

Change 446579 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/mediawiki-config@master] Enable new backend for Special:Tags in fawikisource

https://gerrit.wikimedia.org/r/446579

gerritbot added a comment.Jul 18 2018, 4:08 PM

Change 446579 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable new backend for Special:Tags in fawikisource

https://gerrit.wikimedia.org/r/446579

Stashbot subscribed.Jul 18 2018, 4:28 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-18T16:28:33Z] <catrope@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Enable new backend for Special:Tags on fawikisource (T199334) (duration: 00m 54s)

gerritbot added a comment.Jul 25 2018, 4:37 PM

Change 447834 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/mediawiki-config@master] Enable reading from the new backend for Special:Tags in several large wikis

https://gerrit.wikimedia.org/r/447834

gerritbot added a comment.Jul 25 2018, 4:41 PM

Change 447834 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable reading from the new backend for Special:Tags in several large wikis

https://gerrit.wikimedia.org/r/447834

Stashbot added a comment.Jul 25 2018, 4:49 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-25T16:49:13Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:447834|Enable reading from the new backend for Special:Tags in several large wikis (T199334)]] (duration: 00m 56s)

Ladsgroup mentioned this in T91535: Performance issues with tags.Jul 25 2018, 5:07 PM
Lydia_Pintscher closed this task as Resolved.Jul 26 2018, 3:37 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite board.
gerritbot added a comment.Jul 30 2018, 9:54 AM

Change 449137 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/mediawiki-config@master] Enable reading from change_tag_def everywhere

https://gerrit.wikimedia.org/r/449137

gerritbot added a comment.Jul 30 2018, 11:04 AM

Change 449137 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable reading from change_tag_def everywhere

https://gerrit.wikimedia.org/r/449137

Stashbot added a comment.Jul 30 2018, 11:12 AM

Mentioned in SAL (#wikimedia-operations) [2018-07-30T11:12:05Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:449137|Enable reading from change_tag_def everywhere (T199334)]] (duration: 00m 55s)

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits