Page MenuHomePhabricator
Create Task
Maniphest T200011

`ERROR: Cannot find module '../../../../Wikibase/repo/tests/selenium` when running WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker Jenkins job
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker Jenkins job does this:

git clone WikibaseLexeme
npm install
npm run selenium-daily

It fails because WikibaseLexeme repository assumes Wikibase repository will be available at a specific location.

Failures:

ERROR: Cannot find module '../../../Wikibase/repo/tests/selenium/wikibase.api'
ERROR: Cannot find module '../../../../Wikibase/repo/tests/selenium/pagesections/mixinbuilder'
ERROR: Cannot find module '../../../../Wikibase/repo/tests/selenium/wikibase.api'

If code from Wikibase is required to run WikibaseLexeme, then the code should be extracted to a library, like wdio-mediawiki, or by creating wdio-wikibase.

Steps

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove transitional codeLucas Werkmeister (WMDE)mediawiki/extensions/WikibaseLexememaster+9 -47
package.json wdio-wikibase": "^0.2.0"Addshoremediawiki/extensions/WikibaseLexememaster+1 -1
Export all JS files to the wdio-wikibase npm package.WMDE-leszekmediawiki/extensions/Wikibasemaster+1 -4
Add wdio-wikibase to npm dev depsAddshoremediawiki/extensions/WikibaseLexememaster+1 -3
Remove legacy location for wdio-wikibase filesAddshoremediawiki/extensions/WikibaseLexememaster+18 -45
Make wdio-wikibase package be in wmde orgAddshoremediawiki/extensions/Wikibasemaster+1 -1
Adjust for wdio-wikibase extractionGreta WMDEmediawiki/extensions/WikibaseLexememaster+826 -15
Extract wdio-wikibase packageGreta WMDEmediawiki/extensions/Wikibasemaster+28 -8
Add empty wdio-wikibase npm packageGreta WMDEmediawiki/extensions/Wikibasemaster+26 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• zeljkofilipin created this task.Jul 19 2018, 2:08 PM
• zeljkofilipin added a parent task: T194252: Configure the CI job that runs WikibaseLexeme's browser tests against beta wikidata.
• zeljkofilipin mentioned this in T194252: Configure the CI job that runs WikibaseLexeme's browser tests against beta wikidata.
• zeljkofilipin added a subscriber: WMDE-leszek.
• zeljkofilipin mentioned this in T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.Jul 19 2018, 2:12 PM
Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Aug 2 2018, 12:27 PM
Addshore subscribed.Aug 8 2018, 9:35 AM

The WikibaseLexeme extension can't function without the Wikibase extension loaded anyway, so the browser tests would never pass anyway.

Are we sure we can't just keep this cross extension dependency for the modules?

Addshore triaged this task as Low priority.Aug 8 2018, 9:36 AM
WMDE-leszek added a comment.Aug 8 2018, 9:51 AM

What you say @Addshore is all correct. But hardcoding the directory structure (and name) like done now is a bit evil.

• zeljkofilipin added a comment.Aug 8 2018, 10:07 AM
In T200011#4487750, @Addshore wrote:

The WikibaseLexeme extension can't function without the Wikibase extension loaded anyway, so the browser tests would never pass anyway.

The Jenkins job (running daily, targeting beta cluster) just clones a repository, runs npm install and npm run selenium-daily. It does not install mediawiki locally, it targets a wiki at beta cluster. So, selenium tests would pass if WikibaseLexeme did not use files from Wikibase directly, but instead used an NPM library.

• zeljkofilipin added a comment.Aug 8 2018, 10:08 AM
In T200011#4487774, @WMDE-leszek wrote:

hardcoding the directory structure (and name) like done now is a bit evil.

Agreed. Even if you decide you don't care about running tests targeting beta cluster, hard-coding paths to files from another repository is a code smell.

• zeljkofilipin awarded a token.Aug 8 2018, 10:10 AM
Lucas_Werkmeister_WMDE raised the priority of this task from Low to Medium.Nov 14 2018, 7:27 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite.
Lucas_Werkmeister_WMDE subscribed.

A failing daily CI job should be higher priority than “low”, in my opinion. Fixing this doesn’t sound too difficult, just a bit cumbersome (split off a new NPM package), so let’s try to pick it up soon.

Addshore moved this task from Incoming to Needs Work on the Wikidata-Campsite board.Nov 14 2018, 10:33 PM
Addshore moved this task from Needs Work to Ready to estimate on the Wikidata-Campsite board.Dec 4 2018, 9:25 AM
Addshore updated the task description. (Show Details)Dec 4 2018, 2:48 PM
Addshore set the point value for this task to 8.
Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Addshore edited projects, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed: Wikidata-Campsite.
WMDE-leszek updated the task description. (Show Details)Dec 4 2018, 2:58 PM
Addshore updated the task description. (Show Details)Dec 4 2018, 3:09 PM
Addshore updated the task description. (Show Details)
• Greta_Doci_WMDE updated the task description. (Show Details)Dec 4 2018, 4:20 PM
Addshore assigned this task to • Greta_Doci_WMDE.Dec 6 2018, 10:40 AM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore updated the task description. (Show Details)
gerritbot subscribed.Dec 6 2018, 2:19 PM

Change 478017 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi):
[mediawiki/extensions/Wikibase@master] Extract wdio-wikibase package

https://gerrit.wikimedia.org/r/478017

gerritbot added a project: Patch-For-Review.Dec 6 2018, 2:19 PM
• Greta_Doci_WMDE updated the task description. (Show Details)Dec 10 2018, 11:16 AM
Lucas_Werkmeister_WMDE mentioned this in T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages.Dec 10 2018, 5:43 PM
gerritbot added a comment.Dec 13 2018, 4:28 PM

Change 479470 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi):
[mediawiki/extensions/Wikibase@master] Add empty wdio-wikibase npm package

https://gerrit.wikimedia.org/r/479470

gerritbot added a comment.Dec 13 2018, 4:28 PM

Change 479471 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi):
[mediawiki/extensions/WikibaseLexeme@master] Adjust for wdio-wikibase extraction

https://gerrit.wikimedia.org/r/479471

Diffusion mentioned this in rEWLEca9b4c131de9: Adjust for wdio-wikibase extraction.Dec 13 2018, 4:28 PM
Diffusion mentioned this in rEWLEec4782e87e21: Adjust for wdio-wikibase extraction.Dec 13 2018, 5:32 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLE4f1984300d4b: Adjust for wdio-wikibase extraction.Dec 13 2018, 5:39 PM
gerritbot added a comment.Dec 17 2018, 1:01 PM

Change 479470 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add empty wdio-wikibase npm package

https://gerrit.wikimedia.org/r/479470

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 17 2018, 2:01 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Dec 19 2018, 12:47 PM
Addshore reassigned this task from • Greta_Doci_WMDE to Tarrow.Dec 20 2018, 11:07 AM
Addshore added a subscriber: • Greta_Doci_WMDE.
Addshore mentioned this in T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.Jan 4 2019, 2:58 PM
Addshore mentioned this in rEWLE3124863fa55c: Adjust for wdio-wikibase extraction.Jan 4 2019, 3:13 PM
gerritbot added a comment.Jan 4 2019, 3:58 PM

Change 482314 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Remove legacy location for wdio-wikibase files

https://gerrit.wikimedia.org/r/482314

Addshore mentioned this in rEWLEaa88178d194c: Remove legacy location for wdio-wikibase files.Jan 4 2019, 4:00 PM
gerritbot added a comment.Jan 4 2019, 4:11 PM

Change 479471 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Adjust for wdio-wikibase extraction

https://gerrit.wikimedia.org/r/479471

gerritbot added a comment.Jan 4 2019, 4:20 PM

Change 478017 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Extract wdio-wikibase package

https://gerrit.wikimedia.org/r/478017

Addshore updated the task description. (Show Details)Jan 4 2019, 4:21 PM
Addshore added a comment.Jan 4 2019, 4:30 PM

Step #1 completed, this still needs to be submitted to npm as a package though so that Lexeme can install it as part of its setup :) (thats #2)

gerritbot added a comment.Jan 4 2019, 4:46 PM

Change 482323 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Make wdio-wikibase package be in wmde org

https://gerrit.wikimedia.org/r/482323

Addshore updated the task description. (Show Details)Jan 4 2019, 4:59 PM
gerritbot added a comment.Jan 4 2019, 5:00 PM

Change 482323 abandoned by Addshore:
Make wdio-wikibase package be in wmde org

Reason:
not needed

https://gerrit.wikimedia.org/r/482323

ReleaseTaggerBot edited projects, added: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Jan 4 2019, 5:00 PM
gerritbot added a comment.Jan 4 2019, 5:01 PM

Change 482326 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Add wdio-wikibase to npm dev deps

https://gerrit.wikimedia.org/r/482326

Addshore added a comment.Jan 4 2019, 5:03 PM

Once https://gerrit.wikimedia.org/r/482326 is merged we can try the daily job again.

Addshore mentioned this in rEWLEe712941f0605: Add wdio-wikibase to npm dev deps.Jan 4 2019, 5:04 PM
Addshore claimed this task.Jan 4 2019, 5:04 PM
Addshore added a subscriber: Tarrow.
Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 4 2019, 5:04 PM
gerritbot added a comment.Jan 4 2019, 5:08 PM

Change 482314 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove legacy location for wdio-wikibase files

https://gerrit.wikimedia.org/r/482314

gerritbot added a comment.Jan 4 2019, 5:23 PM

Change 482326 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add wdio-wikibase to npm dev deps

https://gerrit.wikimedia.org/r/482326

Addshore added a comment.Jan 4 2019, 5:25 PM

Testing with https://integration.wikimedia.org/ci/view/Selenium/job/selenium-daily-beta-WikibaseLexeme/131/

Addshore added a comment.Jan 4 2019, 5:47 PM

Failed still, with:

17:26:49 ERROR: Cannot find module '../../../../Wikibase/repo/tests/selenium/wdio-wikibase/pagesections/mixinbuilder'

but the package did correctly install at the npm install step..

will resume on Monday....

gerritbot added a comment.Jan 7 2019, 11:15 AM

Change 482616 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Export all JS files to the wdio-wikibase npm package.

https://gerrit.wikimedia.org/r/482616

gerritbot added a comment.Jan 7 2019, 11:54 AM

Change 482616 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Export all JS files to the wdio-wikibase npm package.

https://gerrit.wikimedia.org/r/482616

gerritbot added a comment.Jan 7 2019, 12:34 PM

Change 482632 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] package.json wdio-wikibase": "^0.2.0"

https://gerrit.wikimedia.org/r/482632

Addshore mentioned this in rEWLE087e96ac1e9b: package.json wdio-wikibase": "^0.2.0".Jan 7 2019, 12:39 PM
gerritbot added a comment.Jan 7 2019, 1:10 PM

Change 482632 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] package.json wdio-wikibase": "^0.2.0"

https://gerrit.wikimedia.org/r/482632

Addshore closed this task as Resolved.Jan 7 2019, 1:18 PM
Addshore moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Tests fail, but this ticket is fixed

https://integration.wikimedia.org/ci/view/Selenium/job/selenium-daily-beta-WikibaseLexeme/135/console

hashar subscribed.Jan 7 2019, 1:26 PM

Thanks for the implementation of wdio-wikibase :)

WMDE-leszek updated the task description. (Show Details)Jan 7 2019, 3:42 PM
gerritbot added a comment.Jan 28 2019, 12:09 PM

Change 486852 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove transitional code

https://gerrit.wikimedia.org/r/486852

Lucas_Werkmeister_WMDE mentioned this in rEWLEafd299f8e924: Remove transitional code.Jan 28 2019, 12:12 PM
jijiki mentioned this in rEWLEab42e7e76378: Remove transitional code.Mar 18 2019, 4:35 PM
jijiki mentioned this in rEWLE6c11221d4d76: package.json wdio-wikibase": "^0.2.0".
jijiki mentioned this in rEWLE4bbe4bd54596: Remove legacy location for wdio-wikibase files.
jijiki mentioned this in rEWLE24ea3205fe92: Add wdio-wikibase to npm dev deps.
gerritbot added a comment.Aug 1 2019, 1:58 PM

Change 486852 had a related patch set uploaded (by Michael Große; owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove transitional code

https://gerrit.wikimedia.org/r/486852

gerritbot added a comment.Aug 5 2019, 1:40 PM

Change 486852 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove transitional code

https://gerrit.wikimedia.org/r/486852

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 5 2019, 2:00 PM
ReleaseTaggerBot edited projects, added: MW-1.34-notes (1.34.0-wmf.19; 2019-08-20); removed: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 6 2019, 6:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits