Page MenuHomePhabricator

Wide images cross the translation column border
Closed, ResolvedPublic

Description

Translation: Gp41 from en to es

Event Timeline

santhosh created this task.Jul 25 2018, 9:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2018, 9:18 AM
Arrbee moved this task from Needs Triage to CX2 on the ContentTranslation board.Aug 6 2018, 10:15 AM
santhosh claimed this task.Aug 8 2018, 5:41 AM

Change 451233 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Avoid wide section overflow hidden

https://gerrit.wikimedia.org/r/451233

santhosh triaged this task as Normal priority.Aug 8 2018, 5:41 AM
santhosh moved this task from Backlog to In Review on the Language-2018-July-September board.

Change 451233 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Avoid wide section overflow hidden

https://gerrit.wikimedia.org/r/451233

Petar.petkovic renamed this task from Wide images crosses the translation column border to Wide images cross the translation column border.Aug 14 2018, 10:19 AM

This problem has been ongoing for quite some time, which is indicated by number of duplicates describing overflowing content.

Patch is merged now, but there may be some points to be discussed. Not sure if there alternatives to displaying horizontal scrollbar, but Design tag was added to one of the duplicates T190574, which maybe indicates this problem will need more careful thought.

Problems with current state:

  • VE node/template highlight does not account for horizontal scrollbar which causes following cases:
  • Part of image is missing (along with caption) for en:Nuclear_drip_line

  • Horizontal scroll displayed for narrow image

  • Double scroll bar issue from T191754 seems to be reintroduced (on Chrome 68). This is what I used to see before the patch for this ticket.

Etonkovidova added a comment.EditedAug 14 2018, 10:02 PM

Just another case:

  • The description of the image is cut off:

Before the fix the image was overflowing the source article canvas

I re-checked the following articles for the issuesin display

  • Gp41 from en to es - the issue that has been fixed.
Petar.petkovic removed a subscriber: gerritbot.