Page MenuHomePhabricator
Create Task
Maniphest T200751

Review and deploy SecureLinkFixer extension
Closed, ResolvedPublic
Actions

Description

What else?

Details

SubjectRepoBranchLines +/-
Enable SecureLinkFixer everywhereoperations/mediawiki-configmaster+1 -5
Add SecureLinkFixer to extension-listoperations/mediawiki-configmaster+1 -0
extension-list: Add SecureLinkFixer and TheWikipediaLibraryoperations/mediawiki-configmaster+2 -0
Enable SecureLinkFixer on group0 wikisoperations/mediawiki-configmaster+1 -0
Start branching SecureLinkFixermediawiki/tools/releasemaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Jul 31 2018, 1:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2018, 1:51 AM
Legoktm added a subtask: T200755: Security review for SecureLinkFixer extension.Jul 31 2018, 2:05 AM
Legoktm updated the task description. (Show Details)Jul 31 2018, 2:46 AM
CCicalese_WMF moved this task from Backlog to Ready on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Aug 7 2018, 12:17 AM
CCicalese_WMF edited projects, added Platform Team Legacy (Designing); removed Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).Oct 1 2018, 1:45 PM
CCicalese_WMF moved this task from Inbox to Blocked Externally on the Platform Team Legacy (Designing) board.Oct 1 2018, 1:57 PM
CCicalese_WMF added a project: Platform Engineering.Oct 2 2018, 2:16 PM
CCicalese_WMF moved this task from Inbox to Needs Cleaning - Security, stability, performance, and scalability (TEC1) on the Platform Engineering board.Oct 3 2018, 2:14 PM
CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)); removed Platform Engineering.
CCicalese_WMF edited projects, added Platform Team Workboards (Blocked Externally); removed Platform Team Legacy (Designing).Oct 14 2018, 3:50 PM
Reedy closed subtask T200755: Security review for SecureLinkFixer extension as Resolved.Dec 7 2018, 1:23 PM
WDoranWMF removed a project: Platform Team Workboards (Blocked Externally).Jul 5 2019, 7:11 PM
Legoktm closed subtask T200758: Performance review for SecureLinkFixer extension as Resolved.Jul 18 2019, 5:32 AM
Legoktm updated the task description. (Show Details)Jul 18 2019, 5:41 AM
gerritbot added a comment.Jul 18 2019, 5:59 AM

Change 524089 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/release@master] Start branching SecureLinkFixer

https://gerrit.wikimedia.org/r/524089

gerritbot added a project: Patch-For-Review.Jul 18 2019, 5:59 AM
Legoktm claimed this task.Jul 18 2019, 6:07 AM
Legoktm mentioned this in T200745: Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list.
Legoktm updated the task description. (Show Details)Jul 18 2019, 6:28 AM

I created https://www.mediawiki.org/wiki/Help:Extension:SecureLinkFixer for user-facing documentation, but I couldn't really think of anything else to add. Please edit/improve!

gerritbot added a comment.Jul 18 2019, 3:13 PM

Change 524089 merged by jenkins-bot:
[mediawiki/tools/release@master] Start branching SecureLinkFixer

https://gerrit.wikimedia.org/r/524089

Jdforrester-WMF moved this task from Backlog to Deployed on Beta Cluster on the Wikimedia-extension-review-queue board.Jul 18 2019, 3:30 PM
gerritbot added a comment.Jul 18 2019, 3:34 PM

Change 524251 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] extension-list: Add SecureLinkFixer and TheWikipediaLibrary

https://gerrit.wikimedia.org/r/524251

Jdforrester-WMF closed subtask T228374: Deploy SecureLinkFixer to beta cluster as Resolved.Jul 18 2019, 7:34 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF updated the task description. (Show Details)
Legoktm added a subscriber: greg.Jul 18 2019, 11:18 PM

Assuming nothing goes wrong with beta cluster, I'm thinking about production deployment to testwikis on July 22/23, and then deployment everywhere the following week, July 30/31 (I won't be available that Monday). @greg, would that be all right?

gerritbot added a comment.Jul 23 2019, 9:01 PM

Change 525157 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[operations/mediawiki-config@master] Enable SecureLinkFixer on group0 wikis

https://gerrit.wikimedia.org/r/525157

gerritbot added a project: Patch-For-Review.Jul 23 2019, 9:01 PM
Legoktm added a comment.Jul 23 2019, 9:05 PM
In T200751#5348417, @Legoktm wrote:

Assuming nothing goes wrong with beta cluster, I'm thinking about production deployment to testwikis on July 22/23,

I've put up a patch for deployment to group0 wikis (which is larger than just the testwikis fwiw), pending approval still.

greg added a comment.Jul 24 2019, 5:54 PM
In T200751#5348417, @Legoktm wrote:

Assuming nothing goes wrong with beta cluster, I'm thinking about production deployment to testwikis on July 22/23, and then deployment everywhere the following week, July 30/31 (I won't be available that Monday). @greg, would that be all right?

bah, sorry, I missed this ping :(

Yeah, that sounds like a good plan, godspeed!

gerritbot added a comment.Jul 24 2019, 7:04 PM

Change 525157 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable SecureLinkFixer on group0 wikis

https://gerrit.wikimedia.org/r/525157

Stashbot added a comment.Jul 24 2019, 7:08 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-24T19:08:34Z] <legoktm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Enable SecureLinkFixer on group0 wikis - T200751 (duration: 00m 55s)

gerritbot added a comment.Jul 24 2019, 7:25 PM

Change 525346 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[operations/mediawiki-config@master] Add SecureLinkFixer to extension-list

https://gerrit.wikimedia.org/r/525346

gerritbot added a comment.Jul 24 2019, 7:25 PM

Change 525347 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[operations/mediawiki-config@master] Enable SecureLinkFixer everywhere

https://gerrit.wikimedia.org/r/525347

gerritbot added a comment.Jul 25 2019, 3:22 PM

Change 524251 merged by jenkins-bot:
[operations/mediawiki-config@master] extension-list: Add SecureLinkFixer and TheWikipediaLibrary

https://gerrit.wikimedia.org/r/524251

gerritbot added a comment.Jul 25 2019, 3:25 PM

Change 525346 abandoned by Jforrester:
Add SecureLinkFixer to extension-list

Reason:
I've merged and deployed the original version of this. :-)

https://gerrit.wikimedia.org/r/525346

Legoktm added a comment.Jul 30 2019, 3:54 AM

Full deployment scheduled for 8am PDT tomorrow (July 30).

gerritbot added a comment.Jul 30 2019, 3:04 PM

Change 525347 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable SecureLinkFixer everywhere

https://gerrit.wikimedia.org/r/525347

Stashbot added a comment.Jul 30 2019, 3:06 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-30T15:06:33Z] <legoktm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Enable SecureLinkFixer everywhere (T200751) (duration: 00m 47s)

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2019, 3:10 PM
Legoktm closed this task as Resolved.Jul 30 2019, 3:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits