Page MenuHomePhabricator

ParserIntegrationTest::testParse (Only variables should be assigned by reference)
Closed, ResolvedPublic

Description

Something is causing test failures in ParserFunctions that seem to block merges for Translate, see: https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php70-docker/562/console:

There were 6 errors:

1) ParserIntegrationTest::testParse with data set "funcsParserTests.txt: Preserve tags in #switch default value" ('[details omitted]')
Only variables should be assigned by reference

/workspace/src/extensions/ParserFunctions/includes/ExtParserFunctions.php:182
/workspace/src/includes/parser/Parser.php:3444
/workspace/src/includes/parser/Parser.php:3148
/workspace/src/includes/parser/Preprocessor_DOM.php:1279
/workspace/src/includes/parser/Parser.php:2962
/workspace/src/includes/parser/Parser.php:1306
/workspace/src/includes/parser/Parser.php:455
/workspace/src/tests/parser/ParserTestRunner.php:899
/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:52
/workspace/src/maintenance/doMaintenance.php:94

Event Timeline

Nikerabbit triaged this task as Unbreak Now! priority.Jul 31 2018, 9:51 AM

No recent changes in ParserFunctions extension. It could either be a change in core, unrelated extension or in the test environment.

Legoktm added a subscriber: Legoktm.

I don't understand why this didn't fail CI on the core change...

Change 449504 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ParserFunctions@master] Remove & from $mwDefault variable assignment

https://gerrit.wikimedia.org/r/449504

Thanks @Legoktm . I wish Phab had a feature that would allow you to search Tasks by time; it would help with finding recently opened tasks, and avoiding to create duplicates.

Change 449504 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Remove & from $mwDefault variable assignment

https://gerrit.wikimedia.org/r/449504

I wish Phab had a feature that would allow you to search Tasks by time; it would help with finding recently opened tasks, and avoiding to create duplicates.

@Huji: It has.

@Aklapper when I go to https://phabricator.wikimedia.org/search/query/advanced/ I don't see any of the fields that would allow dates (like "Created After"). Am I doing something wrong?

@Legoktm it seems like your patch fixed this issue. Marking as resolved.

Change 449634 had a related patch set uploaded (by Brion VIBBER; owner: Legoktm):
[mediawiki/extensions/ParserFunctions@wmf/1.32.0-wmf.15] Remove & from $mwDefault variable assignment

https://gerrit.wikimedia.org/r/449634

Change 449634 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@wmf/1.32.0-wmf.15] Remove & from $mwDefault variable assignment

https://gerrit.wikimedia.org/r/449634

Mentioned in SAL (#wikimedia-operations) [2018-08-01T00:08:59Z] <thcipriani@deploy1001> Synchronized php-1.32.0-wmf.15/extensions/ParserFunctions/includes/ExtParserFunctions.php: SWAT: [[gerrit:449634|Remove & from $mwDefault variable assignment]] T200772 (duration: 00m 57s)

@Huji: Re: T200772#4467175 - That's not the page mentioned. See the docs and please use the corresponding talk page for questions about Phab itself. Thanks!