Page MenuHomePhabricator

Running Echo as dependency of PageTriage fails unit tests
Closed, ResolvedPublic

Description

PageTriage is using some classes from Echo extension, but when adding Echo as dependency the unit tests from Echo failing:

1) NotificationsTest::testUserRightsNotif
Exception: Invalid argument to MediaWiki\Extension\PageTriage\PageTriageUtil::doesPageNeedTriage

/workspace/src/extensions/PageTriage/includes/PageTriageUtil.php:37
/workspace/src/extensions/PageTriage/includes/Hooks.php:914
/workspace/src/includes/Hooks.php:174
/workspace/src/includes/Hooks.php:202
/workspace/src/extensions/ORES/includes/Hooks/RecentChangeSaveHookHandler.php:104
/workspace/src/extensions/ORES/includes/Hooks/RecentChangeSaveHookHandler.php:69
/workspace/src/includes/Hooks.php:174
/workspace/src/includes/Hooks.php:202
/workspace/src/includes/changes/RecentChange.php:443
/workspace/src/includes/logging/LogEntry.php:784
/workspace/src/includes/deferred/MWCallableUpdate.php:34
/workspace/src/includes/deferred/DeferredUpdates.php:268
/workspace/src/includes/deferred/DeferredUpdates.php:214
/workspace/src/includes/deferred/DeferredUpdates.php:134
/workspace/src/includes/deferred/DeferredUpdates.php:307
/workspace/src/includes/deferred/DeferredUpdates.php:100
/workspace/src/includes/deferred/DeferredUpdates.php:117
/workspace/src/includes/logging/LogEntry.php:794
/workspace/src/includes/specials/SpecialUserrights.php:461
/workspace/src/includes/specials/SpecialUserrights.php:401
/workspace/src/extensions/Echo/tests/phpunit/NotificationsTest.php:46
/workspace/src/tests/phpunit/MediaWikiTestCase.php:475
/workspace/src/maintenance/doMaintenance.php:94

Same failure at some location for EducationProgram which is a dependency of Echo

Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 13 2018, 9:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
SBisson claimed this task.Aug 13 2018, 1:53 PM
SBisson edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
SBisson moved this task from Incoming to In Progress on the Growth-Team (Current Sprint) board.

Change 452363 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Copyvio@master] Unset external hooks to test in isolation

https://gerrit.wikimedia.org/r/452363

Change 452364 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Check for irrelevant rc_types first in hooks

https://gerrit.wikimedia.org/r/452364

Change 452363 merged by jenkins-bot:
[mediawiki/extensions/Copyvio@master] Unset external hooks to test in isolation

https://gerrit.wikimedia.org/r/452363

Change 452364 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Check for irrelevant rc_types first in hooks

https://gerrit.wikimedia.org/r/452364

Change 452617 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] Revert "Drop Echo dependency for PageTriage, causes tests to fail"

https://gerrit.wikimedia.org/r/452617

Change 452851 had a related patch set uploaded (by Catrope; owner: Sbisson):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.16] Check for irrelevant rc_types first in hooks

https://gerrit.wikimedia.org/r/452851

Change 452851 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.16] Check for irrelevant rc_types first in hooks

https://gerrit.wikimedia.org/r/452851

Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2018-08-15T00:12:14Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.16/extensions/PageTriage/: SWAT: PageTriage fixes (T199357, T201812, T201560, T201373, T201253) (duration: 00m 51s)

Change 452617 merged by jenkins-bot:
[integration/config@master] Revert "Drop Echo dependency for PageTriage, causes tests to fail"

https://gerrit.wikimedia.org/r/452617