Page MenuHomePhabricator
Create Task
Maniphest T201812

Running Echo as dependency of PageTriage fails unit tests
Closed, ResolvedPublic
Actions

Description

PageTriage is using some classes from Echo extension, but when adding Echo as dependency the unit tests from Echo failing:

1) NotificationsTest::testUserRightsNotif
Exception: Invalid argument to MediaWiki\Extension\PageTriage\PageTriageUtil::doesPageNeedTriage

/workspace/src/extensions/PageTriage/includes/PageTriageUtil.php:37
/workspace/src/extensions/PageTriage/includes/Hooks.php:914
/workspace/src/includes/Hooks.php:174
/workspace/src/includes/Hooks.php:202
/workspace/src/extensions/ORES/includes/Hooks/RecentChangeSaveHookHandler.php:104
/workspace/src/extensions/ORES/includes/Hooks/RecentChangeSaveHookHandler.php:69
/workspace/src/includes/Hooks.php:174
/workspace/src/includes/Hooks.php:202
/workspace/src/includes/changes/RecentChange.php:443
/workspace/src/includes/logging/LogEntry.php:784
/workspace/src/includes/deferred/MWCallableUpdate.php:34
/workspace/src/includes/deferred/DeferredUpdates.php:268
/workspace/src/includes/deferred/DeferredUpdates.php:214
/workspace/src/includes/deferred/DeferredUpdates.php:134
/workspace/src/includes/deferred/DeferredUpdates.php:307
/workspace/src/includes/deferred/DeferredUpdates.php:100
/workspace/src/includes/deferred/DeferredUpdates.php:117
/workspace/src/includes/logging/LogEntry.php:794
/workspace/src/includes/specials/SpecialUserrights.php:461
/workspace/src/includes/specials/SpecialUserrights.php:401
/workspace/src/extensions/Echo/tests/phpunit/NotificationsTest.php:46
/workspace/src/tests/phpunit/MediaWikiTestCase.php:475
/workspace/src/maintenance/doMaintenance.php:94

Same failure at some location for EducationProgram which is a dependency of Echo

Details

SubjectRepoBranchLines +/-
Revert "Drop Echo dependency for PageTriage, causes tests to fail"integration/configmaster+1 -1
Check for irrelevant rc_types first in hooksmediawiki/extensions/PageTriagewmf/1.32.0-wmf.16+2 -2
Check for irrelevant rc_types first in hooksmediawiki/extensions/PageTriagemaster+4 -4
Unset external hooks to test in isolationmediawiki/extensions/Copyviomaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Aug 13 2018, 9:15 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 13 2018, 9:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
SBisson claimed this task.Aug 13 2018, 1:53 PM
SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
SBisson moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot subscribed.Aug 13 2018, 1:53 PM

Change 452363 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Copyvio@master] Unset external hooks to test in isolation

https://gerrit.wikimedia.org/r/452363

gerritbot added a project: Patch-For-Review.Aug 13 2018, 1:53 PM
SBisson mentioned this in rECPV3f6e54a19902: Unset external hooks to test in isolation.Aug 13 2018, 1:54 PM
gerritbot added a comment.Aug 13 2018, 1:55 PM

Change 452364 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Check for irrelevant rc_types first in hooks

https://gerrit.wikimedia.org/r/452364

SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 13 2018, 1:56 PM
Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 13 2018, 6:20 PM
gerritbot added a comment.Aug 13 2018, 6:46 PM

Change 452363 merged by jenkins-bot:
[mediawiki/extensions/Copyvio@master] Unset external hooks to test in isolation

https://gerrit.wikimedia.org/r/452363

gerritbot added a comment.Aug 13 2018, 6:46 PM

Change 452364 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Check for irrelevant rc_types first in hooks

https://gerrit.wikimedia.org/r/452364

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 13 2018, 7:00 PM
gerritbot added a comment.Aug 14 2018, 7:31 AM

Change 452617 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] Revert "Drop Echo dependency for PageTriage, causes tests to fail"

https://gerrit.wikimedia.org/r/452617

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:54 PM
gerritbot added a comment.Aug 14 2018, 10:37 PM

Change 452851 had a related patch set uploaded (by Catrope; owner: Sbisson):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.16] Check for irrelevant rc_types first in hooks

https://gerrit.wikimedia.org/r/452851

gerritbot added a comment.Aug 14 2018, 11:34 PM

Change 452851 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.16] Check for irrelevant rc_types first in hooks

https://gerrit.wikimedia.org/r/452851

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)); removed MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 15 2018, 12:00 AM
Stashbot mentioned this in T199357: New Pages Feed: score draftquality on most recent revision.Aug 15 2018, 12:12 AM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-08-15T00:12:14Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.16/extensions/PageTriage/: SWAT: PageTriage fixes (T199357, T201812, T201560, T201373, T201253) (duration: 00m 51s)

Stashbot mentioned this in T201560: NewPagesFeed in AFC mode shows each page 4 times when all four "predicted issues" checkboxes are checked.Aug 15 2018, 12:12 AM
Stashbot mentioned this in T201373: New Pages Feed: "created date" value changes depending on sort.
Stashbot mentioned this in T201253: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts.
Etonkovidova closed this task as Resolved.Aug 16 2018, 4:53 PM
Etonkovidova subscribed.

Checked - the most recent test run is ok (https://integration.wikimedia.org/ci/job/mwext-php70-phan-seccheck-docker/4678/).

gerritbot added a comment.Aug 20 2018, 1:06 AM

Change 452617 merged by jenkins-bot:
[integration/config@master] Revert "Drop Echo dependency for PageTriage, causes tests to fail"

https://gerrit.wikimedia.org/r/452617

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits