Page MenuHomePhabricator

Fix warning for unrecognized API params (mode, timestamp)
Closed, ResolvedPublic

Description

When toggling back and forth between NPP and AfC as a logged-in user, you can observe this warning in the response from the MediaWiki API:

{"warnings":{"main":{"*":"Unrecognized parameters: timestamp, mode."}},"pagetriagelist":{"result":"success","pages":[]}}

In ext.pageTriage.article.js encodeFilterParams() we could probably remove params.mode = this.getMode();. (ApiPageTriageList uses namepace parameter for determining what to show, not mode)

In ext.pageTriage.article.js url() we could remove timestamp: d.getTime() from the params object.

Event Timeline

kostajh created this task.Aug 17 2018, 12:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2018, 12:33 PM

Change 453885 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/PageTriage@master] Fix unrecognized API parameter warnings for mode and timestamp

https://gerrit.wikimedia.org/r/453885

Change 453885 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Fix unrecognized API parameter warnings for mode and timestamp

https://gerrit.wikimedia.org/r/453885

Etonkovidova closed this task as Resolved.Aug 22 2018, 5:15 PM
Etonkovidova claimed this task.
Etonkovidova added a subscriber: Etonkovidova.

Checked in testwiki (wmf.18).