Page MenuHomePhabricator
Create Task
Maniphest T202427

[Bug] Adding a second Gloss in the same language overwrites existing Gloss
Closed, ResolvedPublic
Actions

Assigned To
Addshore
Authored By
Lydia_Pintscher
Aug 21 2018, 4:33 PM
Tags
Referenced Files
F25751944: image.png
Sep 10 2018, 3:41 PM
F25751935: image.png
Sep 10 2018, 3:41 PM
F25751927: image.png
Sep 10 2018, 3:41 PM
F25614144: Screenshot_20180902_144327.png
Sep 2 2018, 12:52 PM
F25614145: Screenshot_20180902_144354.png
Sep 2 2018, 12:52 PM
Subscribers
Addshore
gerritbot
KaMan
Ladsgroup
Lea_Lacroix_WMDE
Lucas_Werkmeister_WMDE
Lydia_Pintscher
• Pablo-WMDE

Description

Problem:
It is possible to add a second Gloss in the same language to a Sense. The edit then overwrites the existing Gloss. It should not be possible to add a second Gloss for the same language.

Screenshot:
How this looks for the spelling variant check on Lemma and Representation:

Screenshot_20180902_144354.png (484×1 px, 45 KB)

Screenshot_20180902_144327.png (643×1 px, 57 KB)

BDD
GIVEN a Sense has a Gloss in language A
AND I try to add another Gloss in language A
THEN the language field is marked in red
AND a a message appears saying "It is not possible to enter multiple Glosses with the same language."
AND the "publish" link is grayed out

Acceptance criteria:

  • I can not store a second Gloss for the same language on the same Sense

Notes:

  • Also check this for the API.
  • The desired behavior is already in place for spelling variant of Lemma and Representation.

Details

SubjectRepoBranchLines +/-
Senses: Prevent redundant gloss languagesmediawiki/extensions/WikibaseLexememaster+146 -4
WIP: Warn about sense glosses with duplicate language codesmediawiki/extensions/WikibaseLexememaster+25 -2
Check for duplicate gloss language codesmediawiki/extensions/WikibaseLexememaster+22 -2
[WIP] Throw error when two glosses in a sense have the same languagemediawiki/extensions/WikibaseLexememaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Lydia_Pintscher created this task.Aug 21 2018, 4:33 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 21 2018, 4:33 PM
Lydia_Pintscher updated the task description. (Show Details)Aug 28 2018, 9:49 AM
Ladsgroup added a project: Wikidata-Senses-Iteration3.Aug 28 2018, 11:09 AM
Ladsgroup set the point value for this task to 3.
Ladsgroup subscribed.Aug 28 2018, 3:08 PM

This is a little bit more complex than it looks because the frontend sends exactly the same request when someone adds a gloss with duplicated language (invalid) or just changes the gloss (valid). So handling it in backend seems tricky or not even needed. We need to do the check in frontend anyway.

gerritbot subscribed.Aug 28 2018, 4:25 PM

Change 455863 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Throw error when two glosses in a sense have the same language

https://gerrit.wikimedia.org/r/455863

gerritbot added a project: Patch-For-Review.Aug 28 2018, 4:25 PM
Ladsgroup mentioned this in rEWLE5d25043c24aa: [WIP] Throw error when two glosses in a sense have the same language.Aug 28 2018, 4:28 PM
Lydia_Pintscher merged a task: T202985: Shouldn't be possible to add two glosses of single sense with the same language.Aug 28 2018, 6:11 PM
Lydia_Pintscher added subscribers: KaMan, Lea_Lacroix_WMDE, Wikidata Lexicographical data.
• Pablo-WMDE subscribed.Aug 29 2018, 10:21 AM

This sounds a lot like T195372 - are we making sure that the resulting user experience is comparable?

Addshore moved this task from incoming to in progress on the Wikidata board.Aug 30 2018, 9:13 AM
Lydia_Pintscher removed the point value for this task.Sep 2 2018, 12:45 PM

Excellent point. Will adapt the task description. Also removing story points as it will probably need to be reestimated.

Lydia_Pintscher updated the task description. (Show Details)Sep 2 2018, 12:52 PM
Addshore added a project: Wikidata-Senses-Iteration4.Sep 4 2018, 11:34 AM
Lucas_Werkmeister_WMDE claimed this task.Sep 4 2018, 2:48 PM
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Wikidata-Senses-Iteration4 board.
gerritbot added a comment.Sep 4 2018, 2:55 PM

Change 457919 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Check for duplicate gloss language codes

https://gerrit.wikimedia.org/r/457919

Lucas_Werkmeister_WMDE mentioned this in rEWLE6724e10504bd: Check for duplicate gloss language codes.Sep 4 2018, 2:56 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration4 board.Sep 4 2018, 2:59 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEd6e895650502: Check for duplicate gloss language codes.Sep 4 2018, 3:33 PM
gerritbot added a comment.Sep 4 2018, 4:29 PM

Change 455863 abandoned by Ladsgroup:
[WIP] Throw error when two glosses in a sense have the same language

https://gerrit.wikimedia.org/r/455863

Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Senses-Iteration4 board.Sep 4 2018, 5:15 PM
gerritbot added a comment.Sep 10 2018, 1:47 PM

Change 457919 abandoned by Lucas Werkmeister (WMDE):
Check for duplicate gloss language codes

Reason:
This clearly goes against whatever we’re currently doing for similar cases elsewhere, whether I like it or not.

https://gerrit.wikimedia.org/r/457919

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Sep 10 2018, 1:47 PM
Lucas_Werkmeister_WMDE subscribed.
Lucas_Werkmeister_WMDE moved this task from Doing to To Do on the Wikidata-Senses-Iteration4 board.Sep 10 2018, 2:47 PM
Lucas_Werkmeister_WMDE claimed this task.Sep 10 2018, 3:21 PM
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Wikidata-Senses-Iteration4 board.
Addshore subscribed.Sep 10 2018, 3:41 PM

@Lydia_Pintscher & WMDE-Design how does this look?

image.png (318×906 px, 21 KB)

The Forms version looks like this:

image.png (300×966 px, 20 KB)

I could also switch the order of the add button and the error:

image.png (350×898 px, 23 KB)

gerritbot added a comment.Sep 10 2018, 3:42 PM

Change 459564 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] WIP Senses: Prevent redundant gloss languages

https://gerrit.wikimedia.org/r/459564

Addshore claimed this task.Sep 10 2018, 3:42 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptSep 10 2018, 3:42 PM
Addshore mentioned this in rEWLE8e72eb1f1048: WIP Senses: Prevent redundant gloss languages.Sep 10 2018, 3:46 PM
gerritbot added a comment.Sep 10 2018, 3:48 PM

Change 459569 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] WIP: Warn about sense glosses with duplicate language codes

https://gerrit.wikimedia.org/r/459569

Lucas_Werkmeister_WMDE mentioned this in rEWLEedab4d0c6c01: WIP: Warn about sense glosses with duplicate language codes.Sep 10 2018, 3:49 PM
Addshore mentioned this in rEWLE4498f9ef25eb: WIP Senses: Prevent redundant gloss languages.Sep 11 2018, 9:36 AM
Addshore mentioned this in rEWLEded77f7bb24e: WIP Senses: Prevent redundant gloss languages.Sep 11 2018, 9:52 AM
Addshore mentioned this in rEWLE2294cd1cde9c: WIP Senses: Prevent redundant gloss languages.Sep 11 2018, 10:02 AM
Addshore mentioned this in rEWLEb666b05621c3: WIP Senses: Prevent redundant gloss languages.Sep 11 2018, 12:18 PM
Addshore mentioned this in rEWLE5ca14c0cdd2f: WIP Senses: Prevent redundant gloss languages.Sep 11 2018, 12:48 PM
Addshore mentioned this in rEWLE8aa44dc3e7c4: WIP Senses: Prevent redundant gloss languages.Sep 11 2018, 1:17 PM
Addshore moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration4 board.Sep 11 2018, 1:37 PM
Addshore mentioned this in rEWLE415cacf7a617: Senses: Prevent redundant gloss languages.Sep 11 2018, 1:38 PM
Addshore mentioned this in rEWLEd46be58dabb3: WIP Senses: Prevent redundant gloss languages.
Addshore mentioned this in rEWLE8467d8b5adf2: Senses: Prevent redundant gloss languages.Sep 11 2018, 2:02 PM
hoo mentioned this in rEWLE12fb5bd1f46b: Senses: Prevent redundant gloss languages.Sep 14 2018, 3:30 PM
gerritbot added a comment.Sep 17 2018, 12:53 PM

Change 459564 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Senses: Prevent redundant gloss languages

https://gerrit.wikimedia.org/r/459564

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Senses-Iteration4 board.Sep 17 2018, 12:54 PM
gerritbot added a comment.Sep 17 2018, 12:55 PM

Change 459569 abandoned by Lucas Werkmeister (WMDE):
WIP: Warn about sense glosses with duplicate language codes

Reason:
Superseded by Ifa48f76dff.

https://gerrit.wikimedia.org/r/459569

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 17 2018, 1:00 PM
Addshore moved this task from Unsorted 💣 to Closing ✔️ on the User-Addshore board.Sep 20 2018, 1:08 PM
Lydia_Pintscher closed this task as Resolved.Sep 26 2018, 9:29 AM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration4 board.

\o/

Aklapper removed a subscriber: Wikidata Lexicographical data.May 16 2023, 10:22 AM
Maintenance_bot removed a project: Patch-For-Review.May 16 2023, 10:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL