Page MenuHomePhabricator

[Regression wmf.18] "Falling back to DifferenceEngineSlotDiffRenderer" logspam
Closed, ResolvedPublicPRODUCTION ERROR


This is log message has severity NOTICE which means it is a non-error, however it seems either this is a real error with the wrong severity, or it should be disabled in production.

+145,000 hits in the last 24 hours, during enablement of 1.32.0-wmf.18. In the diff channel.


Falling back to DifferenceEngineSlotDiffRenderer

Example url that triggers the message in the logs server-side,

Event Timeline

This is not an error. SlotDiffRenderer has been split out of DifferenceEngine for handling slot-level functionality (i.e. single-content diff, as opposed to full-page diff which can soon include multiple content slots), this is a warning when some extension still tries to use DifferenceEngine for slot-level functionality (so the ContentHandler puts it into a compatibility wrapper).

For now this is fully expected for extensions which provide custom diff implementations. Eventually it should become a deprecation warning but we need to update all extensions in WMF production first. Probably we should downgrade it to INFO?

Change 455403 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Make warning about deprecated SlotDiffRenderer wrapper less noisy

Change 455403 merged by jenkins-bot:
[mediawiki/core@master] Make warning about deprecated SlotDiffRenderer wrapper less noisy

Krinkle claimed this task.
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM