Related to T189636
Notice: Undefined variable: subtitle in /srv/mediawiki/php-1.32.0-wmf.19/extensions/Collection/Collection.php on line 447
Description
Description
Related Objects
Related Objects
- Mentioned In
- T224922: Code Stewardship Review: Collection Extension
T203595: wfAjaxCollectionSetTitles expects at least 2 parameters, 1 given - Mentioned Here
- rECOL3299642a484a: Move most php files under includes/
T203595: wfAjaxCollectionSetTitles expects at least 2 parameters, 1 given
T45086: Capture PHP warnings with stacktraces in MediaWiki and save to logstash
T189636: Undefined 'subtitle' and 'title' indexes in CollectionPageTemplate.php
Event Timeline
Comment Actions
Would be good to have a strack trace as well. Can by found on Fatal-Monitor by looking for a similar entry with type=mediawiki/channel=error instead of type=hhvm. They're both on Fatal-Monitor (which means errors are duplicated), but only the mediawiki ones have traces. Expand the row and look for exception.trace.
Comment Actions
Yes, all notices and warnings have traces. Since 2015, MediaWiki has a listener for php errors, generates a backtrace, and logs them to Logstash directly. These entries have the same message as the entry reported by php/hhvm internally, except with the added joy of request context and traces. Both are included on Fatal-Monitor, so make sure to look expand a row from type "mediawiki", instead of rows from type "hhvm".
(There's a todo at T45086 for figuring out whether there are cases where mediawiki is unable to log it directly, if not, we may turn off the ones from HHVM.)
Comment Actions
Strange. I don't know what I'm doing wrong, but I can only find the error on the hhvm channel.
Comment Actions
T203595 is related to this, because the function is called with less parameters as needed, and than the parameter is undefined
Comment Actions
False alarm, they're still here. What changed is that 3299642a4 moved the classes out into their own file, and thus bypassed the Logstash filter.
[{exception_id}] {exception_url} ErrorException from line 1010 of /srv/mediawiki/php-1.34.0-wmf.13/extensions/Collection/includes/Specials/SpecialCollection.php: PHP Notice: Undefined index: title
[{exception_id}] {exception_url} ErrorException from line 1013 of /srv/mediawiki/php-1.34.0-wmf.13/extensions/Collection/includes/Specials/SpecialCollection.php: PHP Notice: Undefined index: subtitleComment Actions
Nope, not for 90 days at least. Checked both Undefined index: subtitle and Undefined index: title. The latter does have hits for something in MassMessage, but that's unrelated.