Maniphest T203712

Formalize getQueryInfo() usage
Open, LowPublic
Actions

Assigned To

None

Authored By

	Legoktm
	Sep 6 2018, 8:13 PM

Description

phan-taint-check-plugin assumes that methods named getQueryInfo() are returning an array with tables/fields/conds/etc. We should formalize that definition somehow. I'm not exactly sure what formalizing this would mean, could be an interface or just documenting in [[mw:CC]] that methods named this should have that kind of return value. Or maybe returning a typed object instead of an array (implementing ArrayAccess for b/c)?

Details

	Subject	Repo	Branch	Lines +/-
	[WIP] Introduce QueryInfo	mediawiki/core	master	+538 -275

Customize query in gerrit

Related Objects

Mentioned In: T243051: A query builder for MediaWiki core

Event Timeline

Legoktm created this task.Sep 6 2018, 8:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2018, 8:13 PM

Note that not all getQueryInfo() methods are named that: Revision and RevisionStore have getArchiveQueryInfo(), and RevisionStore also has getSlotsQueryInfo().

Also QueryPage has a getQueryInfo() method that uses a slightly different structure for the return array from the getQueryInfo() present in other classes: "join_conds" rather than "joins" and some extra fields not present in the rest.

Hmm, thanks. An interface won't work then, so I think returning a typed object would work.

Change 459242 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] [WIP] Introduce QueryInfo

https://gerrit.wikimedia.org/r/459242

gerritbot added a project: Patch-For-Review.Sep 8 2018, 4:00 PM

Legoktm claimed this task.Sep 12 2018, 12:38 AM

Legoktm added a project: Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).

CCicalese_WMF edited projects, added Platform Team Legacy (Designing); removed Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).Oct 1 2018, 1:35 PM

CCicalese_WMF moved this task from Inbox to Doing on the Platform Team Legacy (Designing) board.

CCicalese_WMF added a project: Platform Engineering.Oct 2 2018, 2:14 PM

CCicalese_WMF moved this task from Inbox to Needs Cleaning - Code Health (TEC13) on the Platform Engineering board.Oct 3 2018, 2:24 PM

CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Code Health (TEC13)); removed Platform Engineering.

CCicalese_WMF edited projects, added Platform Team Workboards (Doing); removed Platform Team Legacy (Designing).Oct 14 2018, 4:01 PM