Maniphest T204347

Duration of query recent changes in Check user tool
Open, MediumPublic
Actions

Assigned To

None

Authored By

	alaa
	Sep 14 2018, 12:42 PM

Description

Hello,

Can we add the selected duration to the check user log?

For example, if I selected to check 0.0.0.0/16 recent changes in (last week or last two weeks or last 30 days or all), then in the log it'll appear like this:

03:40, 14 September 2018, alanajjar got users for 0.0.0.0/16 (reason)

So, I think it'll be better, if we add the duration, to be like this:

03:40, 14 September 2018, alanajjar got users in last week for 0.0.0.0/16 (reason)

03:40, 14 September 2018, alanajjar got users for 0.0.0.0/16 (reason) - last 30 days

Benefits
It'll help to follow any CU abuse or misuse. As you know, if the duration changed then the results will changed too.
Also, I think every inputs in CU tool should appear in the log.

Is it controversial proposal? I think no.

Details

Subject	Repo	Branch	Lines +/-
Add cul_period_id to the cu_log table	mediawiki/extensions/CheckUser	master	+317 -1
Add cul_period to cu_log	mediawiki/extensions/CheckUser	master	+311 -0
Show the selected period in the CheckUser Log	mediawiki/extensions/CheckUser	master	+350 -44
Show the queried duration in CheckUser logs	mediawiki/extensions/CheckUser	master	+64 -43
[WIP] Show duration of query recent changes in checkuser	mediawiki/extensions/CheckUser	master	+70 -236

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T204347 Duration of query recent changes in Check user tool
		Declined		None	T309982 Add cu_log.cul_reason_id, cu_log.cul_reason_plaintext_id and cu_log.cul_actor to the cu_log table

Event Timeline

alaa created this task.Sep 14 2018, 12:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2018, 12:42 PM

alaa added a project: Stewards-and-global-tools.Sep 14 2018, 12:45 PM

So, to clarify, you want that when somebody checks an IP or user not for the whole standard duration but for a limited period of time (last week, last two weeks, etc.), the logs say so. Right?

In T204347#4585893, @MarcoAurelio wrote:

So, to clarify, you want that when somebody checks an IP or user not for the whole standard duration but for a limited period of time (last week, last two weeks, etc.), the logs say so. Right?

Exactly

• MR70 subscribed.Oct 4 2018, 5:25 AM

Change 464472 had a related patch set uploaded (by MR70; owner: MR70):
[mediawiki/extensions/CheckUser@master] [WIP] Show duration of query recent changes in checkuser

https://gerrit.wikimedia.org/r/464472

gerritbot added a project: Patch-For-Review.Oct 4 2018, 8:37 PM

• MR70 triaged this task as High priority.Oct 4 2018, 9:04 PM

• MR70 added a project: DBA.

• MR70 moved this task from General / Unsorted to Patches for review on the CheckUser board.

• MR70 added a subscriber: Huji.

I don't think there's anything to do for the DBAs here

Change 479151 had a related patch set uploaded (by MR70; owner: MR70):
[mediawiki/extensions/CheckUser@master] [WIP] Show duration of query recent changes in checkuser

https://gerrit.wikimedia.org/r/479151

Change 464472 abandoned by MR70:
[WIP] Show duration of query recent changes in checkuser

Reason:
merge-conflict issue

https://gerrit.wikimedia.org/r/464472

Hi @Huji , Could you please take a look at the commit ?

Jalexander lowered the priority of this task from High to Medium.Dec 12 2018, 7:54 PM

Change 479151 abandoned by WMFOffice:
Show the queried duration in CheckUser logs

Reason:
abandoning patch sets of globally banned user

https://gerrit.wikimedia.org/r/479151

Meno25 subscribed.Mar 23 2019, 8:30 PM

stwalkerster subscribed.Jul 26 2019, 7:39 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2019, 8:10 PM

Bradv subscribed.Oct 8 2020, 9:04 PM

Niharika added a project: Anti-Harassment.Oct 14 2020, 12:10 AM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

phuedx moved this task from Triage/To be Estimated to Untriaged on the Anti-Harassment board.Oct 18 2021, 2:01 PM

phuedx moved this task from Untriaged to CheckUser on the Anti-Harassment board.Oct 18 2021, 2:06 PM

Dreamy_Jazz moved this task from Patches for review to General / Unsorted on the CheckUser board.May 16 2022, 1:51 AM

Change 799430 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Show the selected period in the CheckUser Log

https://gerrit.wikimedia.org/r/799430

gerritbot added a project: Patch-For-Review.May 25 2022, 11:41 PM

Dreamy_Jazz subscribed.May 25 2022, 11:42 PM

Dreamy_Jazz added a project: Schema-change.May 25 2022, 11:46 PM

I've written a patch for this. As this changes the cu_log table and I'm not entirely sure on the policy for updating the DB for extensions please say if I have missed anything.

Dreamy_Jazz moved this task from General / Unsorted to Patches for review on the CheckUser board.May 25 2022, 11:55 PM

Dreamy_Jazz moved this task from Unsorted to Add / Create on the Schema-change board.May 31 2022, 2:41 AM

Dreamy_Jazz claimed this task.May 31 2022, 12:50 PM

Change 799430 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Show the selected period in the CheckUser Log

Reason:

Needs to be split into smaller changes.

https://gerrit.wikimedia.org/r/799430

Change 803302 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add cul_period_id to the cu_log table

https://gerrit.wikimedia.org/r/803302

Dreamy_Jazz moved this task from Patches for review to General / Unsorted on the CheckUser board.Jun 6 2022, 5:36 PM