Maniphest T204866

MFA: Remove mobile.startup/user
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	Jdlrobson
	Sep 19 2018, 7:09 PM

Description

While porting this to webpack, I couldn't help but notice how redundant this is.

It adds indirection to our code and provides additional convenience methods such as inUserBucketA, getGroups and getEditCount

We should explore porting those 3 methods to core if they are useful or removing them from our codebase entirely.

Acceptance criteria

inUserBucketA not used by Minerva or MobileFrontend. Remove it.
getGroups not used by Minerva or MobileFrontend. Remove it.
Update existing usages of the user module to use mw.user

Developer notes

It seems the edit count is most frequently used for bucketed editing counts. A bucketed and standardised edit count in core would be super useful to support existing and future schemas. Instead of upstreaming getEditCount we might instead choose to upstream getEditBucket from Popups. We'd need to update MobileWebMainMenuClickTracking to use an edited bucket count. See T210106.

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved	None	T204866 MFA: Remove mobile.startup/user

Event Timeline

Jdlrobson created this task.Sep 19 2018, 7:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2018, 7:09 PM

Jdlrobson triaged this task as Low priority.Sep 19 2018, 7:09 PM

Jdlrobson edited projects, added MobileFrontend (MobileFrontend and MinervaNeue architecture); removed MobileFrontend.

Jdlrobson moved this task from Backlog to Post-initial migration on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Sep 25 2018, 10:18 PM

Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.

Jdlrobson raised the priority of this task from Low to Medium.Oct 10 2018, 6:52 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.

Jdlrobson added a parent task: T195478: [EPIC] Speed up unit test execution and increase code coverage.Oct 18 2018, 4:38 PM

• Niedzielski updated the task description. (Show Details)Oct 24 2018, 4:47 PM

• Niedzielski updated the task description. (Show Details)

• Niedzielski added a project: Technical-Debt.Oct 24 2018, 4:55 PM

Estimation doesn't completely cover the risk in upstreaming to core. If we hit problems with this, we should split this out into a new ticket. The important thing is to remove our user module.

Centralising the definition for edit count buckets has obvious advantages. Both QuickSurveys and Popups would benefit:

Jdlrobson moved this task from Upcoming to Readers-Web-Kanbanana-Board-2018-19-Q2 on the Web-Team-Backlog board.Nov 15 2018, 6:13 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.

Jdlrobson renamed this task from Deprecate mobile.startup/user to MFA: Deprecate mobile.startup/user.Nov 15 2018, 6:58 PM

Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 21 2018, 6:30 PM

Jdlrobson updated the task description. (Show Details)Nov 21 2018, 7:13 PM

Change 475133 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Update usages of user module to mw.user

https://gerrit.wikimedia.org/r/475133

gerritbot added a project: Patch-For-Review.Nov 21 2018, 7:14 PM

Jdlrobson renamed this task from MFA: Deprecate mobile.startup/user to MFA: Remove mobile.startup/user.Nov 21 2018, 7:29 PM

Change 475138 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Wean editor off getEditCount in preparation for user deprecation

https://gerrit.wikimedia.org/r/475138

Change 475139 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove the user object from MobileFrontend

https://gerrit.wikimedia.org/r/475139

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 21 2018, 7:34 PM

Change 475133 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Update usages of user module to mw.user

https://gerrit.wikimedia.org/r/475133

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 23 2018, 8:00 PM

(Tagging internally for historical record, so that we easily find this task when attempting to correlate a ticket with the date a perf graph changes.)

Change 475138 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Wean editor off getEditCount in preparation for user deprecation

https://gerrit.wikimedia.org/r/475138

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 27 2018, 7:00 PM

Change 475139 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove the user object from MobileFrontend

https://gerrit.wikimedia.org/r/475139

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 27 2018, 10:17 PM

LGTM

pmiazga closed this task as Resolved.Nov 28 2018, 11:13 PM

pmiazga removed a project: Patch-For-Review.

pmiazga updated the task description. (Show Details)