Page MenuHomePhabricator

Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.33 release
Closed, ResolvedPublic

Description

T204863: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.32 release || T220656: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.34 release

This is a list of potential deprecated code to drop. Not all of it will be dropped before 1.33 (and we'll move entries to a parallel ticket for 1.34). Found by manually looking for hard deprecations; soft-deprecated code isn't listed here (yet?).

  • From 1.16
    • Language – LanguageGetMagic and LanguageGetSpecialPageAliases hooks – T199291
  • From 1.26
    • RestbaseVirtualRESTService and ParsoidVirtualRESTService::onParsoid1Requestgerrit
  • From 1.27
    • The AbortAutoAccount, AbortNewAccount, AbortLogin, LoginUserMigrated, UserCreateForm, and UserLoginForm hooks, and the LoginForm class and related material – T193755
    • AuthManager migration stuff
      • The AuthPluginAutoCreate hook
      • SessionManager::autoCreateUser()
      • Setting $wgSessionsInObjectCache = false
      • Setting $wgSessionHandler at all
    • MWExceptionHandler::getLogId()
    • EmailNotification::updateWatchlistTimestamp()
    • ResourceLoaderFileModules::readStyleFiles() without a ResourceLoader context
  • From 1.28
    • Linking things
      • Linker::formatTemplates() and ::formatSize()
    • The MimeMagic fallback class for MimeAnalyzer
  • From 1.29
    • User
      • ::getGroupName()
      • ::getGroupMember()

Event Timeline

Change 462804 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove deprecated "Parsoid v1 API" compatibility thunks

https://gerrit.wikimedia.org/r/462804

Change 462804 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated "Parsoid v1 API" compatibility thunks

https://gerrit.wikimedia.org/r/462804

Jdforrester-WMF updated the task description. (Show Details)

Given that the release is happening soon, I'll call this Resolved. I've made 1.34's parallel ticket.