Page MenuHomePhabricator

2010 wikitext editor does not log timings for most Edit events
Open, NormalPublic


The 2010 wikitext editor does not log any timing values for init, saveSuccess, saveAttempt, and saveFailure events, although it does log them for abort, ready, and loaded events.

Event Timeline

Neil_P._Quinn_WMF triaged this task as Normal priority.Sep 21 2018, 9:11 PM
Neil_P._Quinn_WMF created this task.
Neil_P._Quinn_WMF renamed this task from 2010 wikitext editor does not log saveSuccess_timing to 2010 wikitext editor does not log timings for most Edit events.Sep 21 2018, 9:57 PM
Neil_P._Quinn_WMF edited projects, added WikiEditor; removed VisualEditor-MediaWiki.
Neil_P._Quinn_WMF updated the task description. (Show Details)

Looks like client-side events get timings, server side ones don't. In fairness... this is tricky.

Though, I thought that init didn't give a timing in any editor, since it's what some of the timings are based on.

Informational aside:

  • ready.timing: timestamp - init.timestamp
  • loaded.timing: timestamp - init.timestamp
  • saveIntent.timing: timestamp - ready.timestamp
  • saveAttempt.timing: timestamp - saveIntent.timestamp
  • saveSuccess/saveFailure.timing: -1 (there's a comment explaining this to be deliberate sabotage to make you work it out from other data)
  • abort.timing: depends on exactly when you abort. It's timestamp - [init.timestamp/ready.timestamp/saveAttempt.timestamp] depending.
Neil_P._Quinn_WMF added a comment.EditedOct 2 2018, 1:37 AM

Changing the parent tasks here since this doesn't block our immediate metrics work, since event timestamps are precise enough to calculate overall session duration.