Page MenuHomePhabricator
Create Task
Maniphest T205651

Unexpected error localisation for HTTP timeout in log message
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

etwiki
message:

[W60SdwrAAFIAALwNXzMAAABP] /rpc/RunSingleJob.php   RuntimeException from line 109 of /srv/mediawiki/php-1.32.0-wmf.23/extensions/ORES/includes/ORESService.php: Failed to make ORES request to [http://ores.discovery.wmnet:8081/v3/scores/etwiki/?models=damaging%7Cgoodfaith&revids=###&precache=1&format=json], HTTP-päring aegus.


exception:
Failed to make ORES request to [http://ores.discovery.wmnet:8081/v3/scores/etwiki/?models=damaging%7Cgoodfaith&revids=###&precache=1&format=json], HTTP-päring aegus.
	#0 /srv/mediawiki/php-1.32.0-wmf.23/extensions/ORES/includes/ScoreFetcher.php(55): ORES\ORESService->request(array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.23/extensions/ORES/includes/FetchScoreJob.php(89): ORES\ScoreFetcher->getScores(integer, array, boolean, array)
#2 /srv/mediawiki/php-1.32.0-wmf.23/extensions/EventBus/includes/JobExecutor.php(64): ORES\FetchScoreJob->run()
#3 /srv/mediawiki/rpc/RunSingleJob.php(67): JobExecutor->execute(array)
wikidatawiki
message:
[W60SswrAEGwAAFWB37UAAADN] /rpc/RunSingleJob.php   RuntimeException from line 109 of /srv/mediawiki/php-1.32.0-wmf.23/extensions/ORES/includes/ORESService.php: Failed to make ORES request to [http://ores.discovery.wmnet:8081/v3/scores/wikidatawiki/?models=damaging%7Cgoodfaith&revids=###&precache=1&format=json], HTTP request timed out.

exception:
Failed to make ORES request to [http://ores.discovery.wmnet:8081/v3/scores/wikidatawiki/?models=damaging%7Cgoodfaith&revids=###&precache=1&format=json], HTTP request timed out.
#0 /srv/mediawiki/php-1.32.0-wmf.23/extensions/ORES/includes/ScoreFetcher.php(55): ORES\ORESService->request(array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.23/extensions/ORES/includes/FetchScoreJob.php(89): ORES\ScoreFetcher->getScores(integer, array, boolean, array)
#2 /srv/mediawiki/php-1.32.0-wmf.23/extensions/EventBus/includes/JobExecutor.php(64): ORES\FetchScoreJob->run()
#3 /srv/mediawiki/rpc/RunSingleJob.php(67): JobExecutor->execute(array)

Not sure whether this is an issue in the HTTP library of MediaWiki core or an issue with how ORES uses it, but, the normalized message should not be localised in Logstash. This make grouping and detecting harder than it should be.

Details

SubjectRepoBranchLines +/-
Log error messages in Englishmediawiki/extensions/ORESwmf/1.32.0-wmf.23+1 -1
Log error messages in Englishmediawiki/extensions/ORESmaster+1 -1
Customize query in gerrit

Event Timeline

Krinkle created this task.Sep 27 2018, 5:41 PM
Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptSep 27 2018, 5:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Sep 27 2018, 5:41 PM
Anomie subscribed.Sep 28 2018, 2:10 PM

includes/ORESService.php line 95 should probably use ->inLanguage( 'en' ) since it's constructing an exception message to pass to new RuntimeException().

Ladsgroup claimed this task.Sep 28 2018, 2:29 PM
Ladsgroup edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 28 2018, 2:29 PM
Anomie removed a project: Core-Platform-Team-Old.Sep 28 2018, 2:31 PM
gerritbot subscribed.Sep 28 2018, 2:34 PM

Change 463483 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Log error messages in English

https://gerrit.wikimedia.org/r/463483

gerritbot added a project: Patch-For-Review.Sep 28 2018, 2:34 PM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Sep 28 2018, 2:37 PM
gerritbot added a comment.Sep 28 2018, 4:42 PM

Change 463483 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Log error messages in English

https://gerrit.wikimedia.org/r/463483

Ladsgroup moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Sep 28 2018, 4:43 PM
gerritbot added a comment.Sep 28 2018, 4:46 PM

Change 463510 had a related patch set uploaded (by Krinkle; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@wmf/1.32.0-wmf.23] Log error messages in English

https://gerrit.wikimedia.org/r/463510

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Sep 28 2018, 5:00 PM
gerritbot added a comment.Sep 29 2018, 1:06 AM

Change 463510 merged by jenkins-bot:
[mediawiki/extensions/ORES@wmf/1.32.0-wmf.23] Log error messages in English

https://gerrit.wikimedia.org/r/463510

Krinkle closed this task as Resolved.Sep 29 2018, 1:12 AM
Krinkle triaged this task as Medium priority.
Krinkle removed a project: Patch-For-Review.
Stashbot subscribed.Sep 29 2018, 1:13 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-29T01:13:07Z] <krinkle@deploy1001> Synchronized php-1.32.0-wmf.23/extensions/ORES/includes/ORESService.php: T205651 - I1beaeab732a31d (duration: 00m 59s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)); removed MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Sep 29 2018, 2:00 AM
Halfak moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Aug 19 2019, 4:44 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Krinkle moved this task from Mar 2021 to Untriaged on the Wikimedia-production-error board.Feb 10 2021, 7:25 PM
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Feb 10 2021, 8:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL