Some edit submits get fatal InvalidArgumentException "The title does not refer to an existing page" from TwoColConflict extension
Closed, ResolvedPublic5 Story Points

Description

Error

Request ID: W7K0JQrAIE0AADr6LLUAAABU

message
InvalidArgumentException:
The title "Gunnison River Bridge I" does not refer to an existing page
stacktrace
#0 /srv/mediawiki/php-1.32.0-wmf.23/extensions/TwoColConflict/includes/TwoColConflictHooks.php(66): TwoColConflict\InlineTwoColConflict\InlineTwoColConflictHelper->__construct(Title, OutputPage, BufferingStatsdDataFactory, string)
#1 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(4680): Closure$TwoColConflict\TwoColConflictHooks::onAlternateEdit(string)
#2 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(4612): EditPage->getEditConflictHelper()
#3 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(3064): EditPage->addExplainConflictHeader(OutputPage)
#4 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(2779): EditPage->showHeader()
#5 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(702): EditPage->showEditForm()
#6 /srv/mediawiki/php-1.32.0-wmf.23/includes/actions/EditAction.php(60): EditPage->edit()
#7 /srv/mediawiki/php-1.32.0-wmf.23/includes/actions/SubmitAction.php(38): EditAction->show()
#8 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(501): SubmitAction->show()
#9 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#10 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(868): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(525): MediaWiki->main()
#12 /srv/mediawiki/php-1.32.0-wmf.23/index.php(42): MediaWiki->run()

Notes

This error first appeared on 21 September with 1.32.0-wmf.20. Logs from previous production branches did not contain this error.

Krinkle created this task.Oct 2 2018, 1:01 AM
Lea_WMDE set the point value for this task to 5.Oct 2 2018, 12:19 PM
Lea_WMDE added a subscriber: Lea_WMDE.

The points are considered investigation + fixing points together.

Still seen on 1.33-wmf.3, with a slightly different stack trace. For example:

UnexpectedValueException:
The title "Translations:Wikimedia Apps/24/pl" does not refer to an existing page

#0 /srv/mediawiki/php-1.33.0-wmf.3/extensions/TwoColConflict/includes/SplitTwoColConflict/SplitTwoColConflictHelper.php(196): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->getRevisionRecord()
#1 /srv/mediawiki/php-1.33.0-wmf.3/extensions/TwoColConflict/includes/SplitTwoColConflict/SplitTwoColConflictHelper.php(162): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->buildEditConflictView()
#2 /srv/mediawiki/php-1.33.0-wmf.3/includes/EditPage.php(2924): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->getEditFormHtmlBeforeContent()
#3 /srv/mediawiki/php-1.33.0-wmf.3/includes/EditPage.php(702): EditPage->showEditForm()
#4 /srv/mediawiki/php-1.33.0-wmf.3/includes/actions/EditAction.php(60): EditPage->edit()
#5 /srv/mediawiki/php-1.33.0-wmf.3/includes/actions/SubmitAction.php(38): EditAction->show()
#6 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(501): SubmitAction->show()
#7 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(862): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(517): MediaWiki->main()
#10 /srv/mediawiki/php-1.33.0-wmf.3/index.php(42): MediaWiki->run()

Thanks for the update! Please keep us informed. We have some ideas what is causing this (e.g. the page got deleted the moment the user submitted the conflicting edit) and will fix it, but it's a bit down in our queue and will take a while.

Change 472170 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472170

Change 472175 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

Change 472170 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472170

Change 472411 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

Change 472175 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:29:33Z] <zfilipin@deploy1001> Synchronized php-1.33.0-wmf.3/extensions/TwoColConflict: SWAT: [[gerrit:472175|Fix harmless edits turning into conflicts (T205942 T208840 T209012 T209036)]] (duration: 00m 55s)

Change 472431 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

Change 472431 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:53:22Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on group0 only T205942 T208840 T209012 T209036 (duration: 00m 54s)

Change 472434 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

Change 472434 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

Mentioned in SAL (#wikimedia-operations) [2018-11-08T13:07:46Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on dewiki - T205942 T208840 T209012 T209036 (duration: 00m 53s)

Change 472411 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

Mentioned in SAL (#wikimedia-operations) [2018-11-08T19:35:40Z] <thcipriani@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:472411|Revert "Disable wmgUseTwoColConflict everywhere"]] T205942 T208840 T209012 T209036 (duration: 00m 54s)

Krinkle closed this task as Resolved.
Krinkle claimed this task.