Page MenuHomePhabricator
Create Task
Maniphest T205942

Some edit submits get fatal InvalidArgumentException "The title does not refer to an existing page" from TwoColConflict extension
Closed, ResolvedPublic5 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

Request ID: W7K0JQrAIE0AADr6LLUAAABU

message
InvalidArgumentException:
The title "Gunnison River Bridge I" does not refer to an existing page
stacktrace
#0 /srv/mediawiki/php-1.32.0-wmf.23/extensions/TwoColConflict/includes/TwoColConflictHooks.php(66): TwoColConflict\InlineTwoColConflict\InlineTwoColConflictHelper->__construct(Title, OutputPage, BufferingStatsdDataFactory, string)
#1 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(4680): Closure$TwoColConflict\TwoColConflictHooks::onAlternateEdit(string)
#2 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(4612): EditPage->getEditConflictHelper()
#3 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(3064): EditPage->addExplainConflictHeader(OutputPage)
#4 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(2779): EditPage->showHeader()
#5 /srv/mediawiki/php-1.32.0-wmf.23/includes/EditPage.php(702): EditPage->showEditForm()
#6 /srv/mediawiki/php-1.32.0-wmf.23/includes/actions/EditAction.php(60): EditPage->edit()
#7 /srv/mediawiki/php-1.32.0-wmf.23/includes/actions/SubmitAction.php(38): EditAction->show()
#8 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(501): SubmitAction->show()
#9 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#10 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(868): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(525): MediaWiki->main()
#12 /srv/mediawiki/php-1.32.0-wmf.23/index.php(42): MediaWiki->run()

Notes

This error first appeared on 21 September with 1.32.0-wmf.20. Logs from previous production branches did not contain this error.

Details

SubjectRepoBranchLines +/-
Revert "Disable wmgUseTwoColConflict everywhere"operations/mediawiki-configmaster+1 -3
Re-enable wmgUseTwoColConflict on dewikioperations/mediawiki-configmaster+1 -0
Re-enable wmgUseTwoColConflict on group0 onlyoperations/mediawiki-configmaster+1 -0
Fix harmless edits turning into conflictsmediawiki/extensions/TwoColConflictwmf/1.33.0-wmf.3+1 -0
Fix harmless edits turning into conflictsmediawiki/extensions/TwoColConflictmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Oct 2 2018, 1:01 AM
Krinkle moved this task from Untriaged to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.
Lea_WMDE set the point value for this task to 5.Oct 2 2018, 12:19 PM
Lea_WMDE subscribed.

The points are considered investigation + fixing points together.

Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Two-Column-Edit-Conflict-Merge board.Oct 2 2018, 12:19 PM
Krinkle added a comment.Nov 7 2018, 12:29 AM

Still seen on 1.33-wmf.3, with a slightly different stack trace. For example:

UnexpectedValueException:
The title "Translations:Wikimedia Apps/24/pl" does not refer to an existing page

#0 /srv/mediawiki/php-1.33.0-wmf.3/extensions/TwoColConflict/includes/SplitTwoColConflict/SplitTwoColConflictHelper.php(196): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->getRevisionRecord()
#1 /srv/mediawiki/php-1.33.0-wmf.3/extensions/TwoColConflict/includes/SplitTwoColConflict/SplitTwoColConflictHelper.php(162): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->buildEditConflictView()
#2 /srv/mediawiki/php-1.33.0-wmf.3/includes/EditPage.php(2924): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->getEditFormHtmlBeforeContent()
#3 /srv/mediawiki/php-1.33.0-wmf.3/includes/EditPage.php(702): EditPage->showEditForm()
#4 /srv/mediawiki/php-1.33.0-wmf.3/includes/actions/EditAction.php(60): EditPage->edit()
#5 /srv/mediawiki/php-1.33.0-wmf.3/includes/actions/SubmitAction.php(38): EditAction->show()
#6 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(501): SubmitAction->show()
#7 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(862): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(517): MediaWiki->main()
#10 /srv/mediawiki/php-1.33.0-wmf.3/index.php(42): MediaWiki->run()
thiemowmde added a comment.Nov 7 2018, 8:43 AM

Thanks for the update! Please keep us informed. We have some ideas what is causing this (e.g. the page got deleted the moment the user submitted the conflicting edit) and will fix it, but it's a bit down in our queue and will take a while.

gerritbot subscribed.Nov 7 2018, 3:34 PM

Change 472170 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472170

gerritbot added a project: Patch-For-Review.Nov 7 2018, 3:34 PM
thiemowmde mentioned this in rESCC38db0852faff: Fix harmless edits turning into conflicts.Nov 7 2018, 3:37 PM
gerritbot added a comment.Nov 7 2018, 3:46 PM

Change 472175 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

thiemowmde mentioned this in rESCC1bd3fa286aaa: Fix harmless edits turning into conflicts.Nov 7 2018, 3:50 PM
gerritbot added a comment.Nov 7 2018, 3:59 PM

Change 472170 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472170

thiemowmde mentioned this in rESCC1057c93ba400: Fix harmless edits turning into conflicts.Nov 8 2018, 10:49 AM
thiemowmde mentioned this in rESCC5dddd52fcf45: Fix harmless edits turning into conflicts.Nov 8 2018, 10:54 AM
gerritbot added a comment.Nov 8 2018, 10:55 AM

Change 472411 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

gerritbot added a comment.Nov 8 2018, 12:23 PM

Change 472175 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

Stashbot subscribed.Nov 8 2018, 12:29 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:29:33Z] <zfilipin@deploy1001> Synchronized php-1.33.0-wmf.3/extensions/TwoColConflict: SWAT: [[gerrit:472175|Fix harmless edits turning into conflicts (T205942 T208840 T209012 T209036)]] (duration: 00m 55s)

Stashbot mentioned this in T208840: Monitor user reports about imaginary conflicts.Nov 8 2018, 12:29 PM
Stashbot mentioned this in T209012: Preview on a new site breaks and leads to loose of the site content.
Stashbot mentioned this in T209036: The title "Foo" does not refer to an existing page.
gerritbot added a comment.Nov 8 2018, 12:48 PM

Change 472431 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

gerritbot added a comment.Nov 8 2018, 12:51 PM

Change 472431 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

Stashbot added a comment.Nov 8 2018, 12:53 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:53:22Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on group0 only T205942 T208840 T209012 T209036 (duration: 00m 54s)

gerritbot added a comment.Nov 8 2018, 1:02 PM

Change 472434 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

gerritbot added a comment.Nov 8 2018, 1:04 PM

Change 472434 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

Stashbot added a comment.Nov 8 2018, 1:07 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T13:07:46Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on dewiki - T205942 T208840 T209012 T209036 (duration: 00m 53s)

gerritbot added a comment.Nov 8 2018, 7:26 PM

Change 472411 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

Stashbot added a comment.Nov 8 2018, 7:35 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T19:35:40Z] <thcipriani@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:472411|Revert "Disable wmgUseTwoColConflict everywhere"]] T205942 T208840 T209012 T209036 (duration: 00m 54s)

Krinkle closed this task as Resolved.Nov 15 2018, 1:18 AM
Krinkle claimed this task.
Krinkle removed a project: Patch-For-Review.
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Resolved on the Wikimedia-production-error board.Mar 25 2019, 10:35 PM
Daimona mentioned this in T219727: UnexpectedValueException: The title "Discussioni utente:Barstein" does not refer to an existing page.Mar 31 2019, 9:11 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL