The title "Foo" does not refer to an existing page
Closed, ResolvedPublic

Description

People complaining that when they try to edit a non-exciting page, they get fatal:

Logstash gives this:

#0 /srv/mediawiki/php-1.33.0-wmf.3/extensions/TwoColConflict/includes/SplitTwoColConflict/SplitTwoColConflictHelper.php(196): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->getRevisionRecord()
#1 /srv/mediawiki/php-1.33.0-wmf.3/extensions/TwoColConflict/includes/SplitTwoColConflict/SplitTwoColConflictHelper.php(162): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->buildEditConflictView()
#2 /srv/mediawiki/php-1.33.0-wmf.3/includes/EditPage.php(2924): TwoColConflict\SplitTwoColConflict\SplitTwoColConflictHelper->getEditFormHtmlBeforeContent()
#3 /srv/mediawiki/php-1.33.0-wmf.3/includes/EditPage.php(702): EditPage->showEditForm()
#4 /srv/mediawiki/php-1.33.0-wmf.3/includes/actions/EditAction.php(60): EditPage->edit()
#5 /srv/mediawiki/php-1.33.0-wmf.3/includes/actions/SubmitAction.php(38): EditAction->show()
#6 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(501): SubmitAction->show()
#7 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(862): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.33.0-wmf.3/includes/MediaWiki.php(517): MediaWiki->main()
#10 /srv/mediawiki/php-1.33.0-wmf.3/index.php(42): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

And It's happening too often: https://logstash.wikimedia.org/goto/f9cb4383b0042c1c5d0f4c80448342e6

Ladsgroup triaged this task as Unbreak Now! priority.
Restricted Application changed the subtype of this task from "Release" to "Task". · View Herald TranscriptNov 8 2018, 10:47 AM
Restricted Application added a subscriber: TerraCodes. · View Herald Transcript
Restricted Application added a project: TCB-Team. · View Herald TranscriptNov 8 2018, 10:47 AM

Change 472175 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

Change 472411 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

Change 472175 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:29:33Z] <zfilipin@deploy1001> Synchronized php-1.33.0-wmf.3/extensions/TwoColConflict: SWAT: [[gerrit:472175|Fix harmless edits turning into conflicts (T205942 T208840 T209012 T209036)]] (duration: 00m 55s)

Change 472431 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

Change 472431 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:53:22Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on group0 only T205942 T208840 T209012 T209036 (duration: 00m 54s)

Change 472434 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

Change 472434 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

Mentioned in SAL (#wikimedia-operations) [2018-11-08T13:07:46Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on dewiki - T205942 T208840 T209012 T209036 (duration: 00m 53s)

Change 472411 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

Mentioned in SAL (#wikimedia-operations) [2018-11-08T19:35:40Z] <thcipriani@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:472411|Revert "Disable wmgUseTwoColConflict everywhere"]] T205942 T208840 T209012 T209036 (duration: 00m 54s)

thcipriani closed this task as Resolved.Nov 8 2018, 8:18 PM
thcipriani assigned this task to thiemowmde.
thcipriani added a subscriber: thiemowmde.

Mentioned in SAL (#wikimedia-operations) [2018-11-08T19:35:40Z] <thcipriani@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:472411|Revert "Disable wmgUseTwoColConflict everywhere"]] T205942 T208840 T209012 T209036 (duration: 00m 54s)

After a re-deploy, I no longer see the errors mentioned on this task anywhere, closing train blocker and rolling forward. Thanks for the work here @thiemowmde !