Maniphest T206226

mobile.startup
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

PageGateway.test.jshas already been migrated to webpack's control, but its associated tests proved to be challenging to migrate due to tight coupling with dependencies ( e.g. jQuery) and a lot of stubbing in its place. It was thus decided to leave its test file as is and migrate it in a future card (this one).

What with T204786 this should hopefully be trivial.

Acceptance criteria

PageGateway.test.jsis migrated to tests/node-qunit/mobile.startup and can be run from headless qunit
Move large test MW API responses to their own files as wanted to avoid cluttering the tests

Note: Adding additional test coverage is out of scope and will be added separately.

Sign off steps

Measure and record code coverage on the wiki page

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved	None	T206226 Migrate PageGateway.test.js to tests/node-qunit/mobile.startup

Event Timeline

Jdlrobson created this task.Oct 4 2018, 2:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2018, 2:50 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Oct 4 2018, 4:55 PM

Jdlrobson triaged this task as High priority.Oct 4 2018, 11:02 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Oct 5 2018, 5:47 PM

• Niedzielski updated the task description. (Show Details)Oct 9 2018, 4:42 PM

ovasileva set the point value for this task to 2.Oct 9 2018, 4:46 PM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.

ovasileva added a project: MobileFrontend (MobileFrontend and MinervaNeue architecture).

Jdrewniak claimed this task.Oct 9 2018, 9:42 PM

Jdrewniak moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Change 466606 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/MobileFrontend@master] Porting PageGateway tests to node-qunit

https://gerrit.wikimedia.org/r/466606

gerritbot added a project: Patch-For-Review.Oct 11 2018, 1:34 PM

Jdrewniak mentioned this in T205128: Bundle Hogan.js.Oct 11 2018, 7:36 PM

Jdlrobson moved this task from Doing to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 16 2018, 10:04 PM

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 17 2018, 9:21 PM

Jdlrobson added a parent task: T195478: [EPIC] Speed up unit test execution and increase code coverage.Oct 18 2018, 4:36 PM

Change 468494 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Use ES6 template strings for test HTML templates

https://gerrit.wikimedia.org/r/468494

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 19 2018, 6:25 PM

Change 468624 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove jQuery usage inside PageGateway tests

https://gerrit.wikimedia.org/r/468624

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 19 2018, 7:08 PM

Jdrewniak moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 22 2018, 2:00 PM

Change 466606 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Porting PageGateway tests to node-qunit

https://gerrit.wikimedia.org/r/466606

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 22 2018, 10:01 PM

Jdlrobson reassigned this task from Jdrewniak to • nray.Oct 23 2018, 5:20 PM

Jdlrobson added a subscriber: Jdrewniak.

pmiazga removed • nray as the assignee of this task.Oct 24 2018, 1:00 AM

pmiazga removed a project: Patch-For-Review.

pmiazga moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

pmiazga added a subscriber: • nray.

Change 468494 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use ES6 template strings for test HTML templates

https://gerrit.wikimedia.org/r/468494

Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 24 2018, 1:16 AM

Change 468624 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Remove jQuery usage inside PageGateway tests

https://gerrit.wikimedia.org/r/468624

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.2; 2018-10-30); removed MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 24 2018, 2:02 AM

Change 469456 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Remove left over files from PageGateway migration

https://gerrit.wikimedia.org/r/469456

gerritbot added a project: Patch-For-Review.Oct 24 2018, 4:24 PM

• nray moved this task from Ready for Signoff to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 24 2018, 4:25 PM

• nray moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 24 2018, 4:59 PM

Change 469456 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove leftover files from PageGateway migration

https://gerrit.wikimedia.org/r/469456

Jdlrobson closed this task as Resolved.Oct 24 2018, 10:59 PM

Jdlrobson updated the task description. (Show Details)