Maniphest T206265

Bug: Section edit links should be hidden for blocked users
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 4 2018, 9:20 PM

Description

When I login as a blocked user I see edit icons that invite me to edit even though I cannot edit.

Expected: All edit pencils are marked as locked.
Actual: Only top edit pencil is marked as locked.

Screen Shot 2018-10-04 at 2.13.03 PM.png (586×1 px, 100 KB)

Developer notes

We used to hide section edit links in this situation, but don't do that any more.
Should we hide them, or should they also show the locked icon?
Hide them appears to be the answer! (T206265#4806240)

Related bug we fixed before: T190834

Reproduction steps

setup

Create account BlockedUser You can create a block locally for that account with an admin account by visiting Special:BlockUser.
- Make sure to untick all boxes - in particular "Prevent this user from editing their own talk page while blocked" unticked (for test) and for your sanity do not "Prevent account creation" or "Automatically block the last IP address used by this user, and any subsequent IP addresses they try to edit from" (if you do you'll need to delete the block in ipblocks table in your database.
Disable wgMFContentProvider if configured.

Test

Login as BlockedUser
Visit any page with sections.

Acceptance criteria

For protected articles we exclude the edit icons from sections. When a user is blocked these edit icons should also be hidden - only the icon at the top of the page will be present.

QA Results

AC	Status	Details
1	✅	T206265#5496047

Details

	Subject	Repo	Branch	Lines +/-
	[edit] [UI] hide edit section links for blocked users	mediawiki/skins/MinervaNeue	master	+48 -27

Customize query in gerrit

Related Objects

Mentioned In: T234868: Mobile VE no longer restores section hash fragment after section editing
rSKIN29077dc20135: Update git submodules
Mentioned Here: T190834: Edit icon should show as locked when user is blocked from editing.

Event Timeline

Jdlrobson created this task.Oct 4 2018, 9:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2018, 9:20 PM

This should be a quick question for you @alexhollender !

Seems like for protected articles we exclude the edit icons from sections. I think we should follow that pattern. Moving out of design.

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Dec 11 2018, 4:53 PM

Jdlrobson updated the task description. (Show Details)Dec 11 2018, 5:51 PM

Jdlrobson added a project: good first task.

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jan 7 2019, 6:51 PM

Jdlrobson updated the task description. (Show Details)Jan 16 2019, 5:19 PM

ovasileva renamed this task from Bug: Section edit links are not marked as locked for blocked users to Bug: Section edit links should be hidden for blocked users.Jan 16 2019, 5:20 PM

@Volker_E @Niedzielski pointed out that the locked edit pencil is out of sync with edit icon graphic. Icon standardisation team to the rescue (?)

<li id="ca-edit" class="mw-ui-icon mw-ui-icon-element mw-ui-icon-minerva-edit" title="Edit the lead section of this page"><a href="http://localhost:8888/w/index.php?title=Singapore&amp;action=edit&amp;section=0" class="edit-page">Edit</a></li>

Screen Shot 2019-01-16 at 9.22.04 AM.png (71×62 px, 7 KB)

ovasileva set the point value for this task to 3.Jan 16 2019, 5:24 PM

Jdlrobson moved this task from Upcoming to Readers-Web-Kanbanana-Board-2018-19-Q4 on the Web-Team-Backlog board.Apr 4 2019, 10:07 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog.

Jdlrobson added a project: MinervaNeue.Apr 8 2019, 5:18 PM

MBinder_WMF edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4).Jul 3 2019, 5:42 PM

ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue.Jul 24 2019, 5:23 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 24 2019, 5:39 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jul 30 2019, 7:33 PM

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Jul 30 2019, 8:07 PM

Jdlrobson moved this task from Triaged but Future to Readers-Web-Kanbanana-2019-20-Q1 on the Web-Team-Backlog board.Jul 31 2019, 7:01 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Aug 19 2019, 4:27 PM

• Niedzielski claimed this task.Aug 26 2019, 3:52 PM

• Niedzielski moved this task from Ready for Development to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Change 532794 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] [edit] [UI] hide edit section links for blocked users

https://gerrit.wikimedia.org/r/532794

gerritbot added a project: Patch-For-Review.Aug 27 2019, 8:56 PM

@pmiazga, given your experience, I think you're in an ideal spot to review this change. I refactored some of the "loose" page permission checks into the MinervaPagePermissions implementation as it seemed quite appropriate. What I'm most unsure of is if any special work is needed when adding new permission actions (a special config in skin.json). (I'm not sure why this is configurable.) The distinction from the plain old "EDIT" action was needed as some parts of the code only care whether the page content model is editable and others care whether the active user can edit.

• Niedzielski moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Aug 27 2019, 9:01 PM

sure, I'll check it

MBinder_WMF added a project: MobileFrontend.Aug 28 2019, 5:19 PM

Change 532794 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] [edit] [UI] hide edit section links for blocked users

https://gerrit.wikimedia.org/r/532794

Restricted Repository Identity mentioned this in rSKIN29077dc20135: Update git submodules.Sep 4 2019, 4:57 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 4 2019, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2019, 5:10 PM

pmiazga reassigned this task from pmiazga to Edtadros.Sep 4 2019, 8:40 PM

pmiazga moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

@pmiazga where do you want me to test this? I may need assistance blocking myself :)

@Edtadros can beta cluster, can be staging. Let's proceed with staging, please share the user name that has to be blocked,

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

Login as BlockedUser
Visit any page with sections.
✅ AC1: For protected articles we exclude the edit icons from sections. When a user is blocked these edit icons should also be hidden - only the icon at the top of the page will be present.

Edtadros updated the task description. (Show Details)Sep 16 2019, 2:40 PM

All done!

matmarex mentioned this in T234868: Mobile VE no longer restores section hash fragment after section editing.Oct 8 2019, 12:07 AM

	F27912614: Screen Shot 2019-01-16 at 9.22.04 AM.png
	Jan 16 2019, 5:23 PM

	F26310927: Screen Shot 2018-10-04 at 2.13.03 PM.png
	Oct 4 2018, 9:20 PM

	F30372190: T206265.gif
	Sep 16 2019, 2:39 PM

Bug: Section edit links should be hidden for blocked usersClosed, ResolvedPublic3 Estimated Story PointsActions