Page MenuHomePhabricator
Create Task
Maniphest T206344

MenuSelectWidget lost escape key support
Closed, ResolvedPublic
Actions

Description

With the latest change to v0.29.1 the MenuSelectWidget seems to have lost (parts of) its onKeyDown handling, the "escape" key does not close the suggestion menu as before.
This behavior can be reproduced on the demo page. Typing any value, e.g. "asd" in the ComboBoxInputWidget field (selects the first value), then hitting escape - this does not close the menu as observed in earlier versions (e.g. v0.28.2).

This can be reproduced in both latest Firefox and Chromium.

The defective code is not immediately obvious to me but was introduced during https://gerrit.wikimedia.org/r/c/oojs/ui/+/437960

Background: We first experienced this in a browser test for WikibaseLexeme on Special:NewLexeme when specifying a fallback lemma language (initially hidden), worked around it by not using escape any more.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.29.2mediawiki/coremaster+107 -50
Follow-up Ib00d6720: Fix KeyDown listener name in MenuSelectWidgetoojs/uimaster+4 -4
Customize query in gerrit

Event Timeline

• Pablo-WMDE created this task.Oct 5 2018, 5:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2018, 5:01 PM
• Pablo-WMDE updated the task description. (Show Details)Oct 5 2018, 5:03 PM
matmarex assigned this task to • Esanders.Oct 5 2018, 5:40 PM
• Petar.petkovic subscribed.Oct 7 2018, 9:53 PM

This goes beyond escape key on MenuSelectWidget. Could be that all of document keydown events are misbehaving for all widgets that are using SelectWidget in some way.

On Content Translation dashboard, there is no way to navigate through the list of results in "New translation" dialog. After noticing bug on CX dashboard, I went on to enwiki beta to edit some page using VE. There is no way to arrow through the list of results while searching for category to add.

Then, I went to check OOUI demo page for DropdownWidget. Opening the popup menu and pressing down arrow makes the code enter infinite loop and block the entire page. This can be reproduced on Special:AllPages.

Volker_E triaged this task as Unbreak Now! priority.Oct 8 2018, 6:37 AM

Seconding @Petar.petkovic's observation. Doesn't freeze the page on OS X/Chrome, but behaves very obscure.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptOct 8 2018, 6:37 AM
Volker_E added a project: Regression.Oct 8 2018, 3:54 PM
gerritbot subscribed.Oct 8 2018, 4:07 PM

Change 465189 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Follow-up Ib00d6720: Fix key down listener name in MenuSelectWidget

https://gerrit.wikimedia.org/r/465189

gerritbot added a project: Patch-For-Review.Oct 8 2018, 4:07 PM
• Esanders added a project: VisualEditor (Current work).Oct 8 2018, 4:19 PM
• Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
• Esanders removed a project: VisualEditor (Current work).
gerritbot added a comment.Oct 8 2018, 4:34 PM

Change 465189 merged by jenkins-bot:
[oojs/ui@master] Follow-up Ib00d6720: Fix KeyDown listener name in MenuSelectWidget

https://gerrit.wikimedia.org/r/465189

Volker_E moved this task from Backlog to OOUI-0.29.2 on the OOUI board.Oct 8 2018, 8:10 PM
Volker_E edited projects, added OOUI (OOUI-0.29.2); removed OOUI.
Volker_E removed a project: Patch-For-Review.Oct 8 2018, 8:19 PM
Volker_E removed a subscriber: gerritbot.
gerritbot added a comment.Oct 8 2018, 11:52 PM

Change 465297 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Update OOUI to v0.29.2

https://gerrit.wikimedia.org/r/465297

gerritbot added a project: Patch-For-Review.Oct 8 2018, 11:52 PM
gerritbot added a comment.Oct 9 2018, 2:32 AM

Change 465297 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.2

https://gerrit.wikimedia.org/r/465297

Volker_E closed this task as Resolved.Oct 9 2018, 2:34 AM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 9 2018, 3:00 AM
Liuxinyu970226 unsubscribed.Oct 27 2018, 8:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits