Page MenuHomePhabricator
Create Task
Maniphest T206838

WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode
Closed, ResolvedPublic
Actions

Description

When e.g. inserting the following WikiText using the EditFormPreloadText hook ...

* ABC
* DEF

... and VisualEditor starts in WikiText mode (e.g. because visual mode is disabled for target namespace), VisualEditor shows ...

<ul id="mwAQ"><li id="mwAg"> ABC</li>
<li id="mwAw"> DEF</li></ul>

... in the edit area. This is due to a missing check for paction parameter in ApiVisualEditor.php

There is a patch for REL1_31 available: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/466665/

If accepted, this should probably be cherry-picked to master and REL1_32.

Details

SubjectRepoBranchLines +/-
Fix parse wikitext fragment in `paction` wikitext.mediawiki/extensions/VisualEditormaster+1 -1
Fix parse wikitext fragment in `paction` wikitext.mediawiki/extensions/VisualEditorREL1_31+1 -1
Customize query in gerrit

Event Timeline

Osnard created this task.Oct 12 2018, 8:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2018, 8:46 AM
Mglaser subscribed.Oct 12 2018, 8:57 AM
gerritbot subscribed.Oct 12 2018, 3:31 PM

Change 466665 had a related patch set uploaded (by Esanders; owner: Nasty):
[mediawiki/extensions/VisualEditor@REL1_31] Fix parse wikitext fragment in paction wikitext.

https://gerrit.wikimedia.org/r/466665

gerritbot added a project: Patch-For-Review.Oct 12 2018, 3:31 PM
Esanders updated the task description. (Show Details)Oct 12 2018, 3:33 PM
gerritbot added a comment.Oct 12 2018, 7:17 PM

Change 466949 had a related patch set uploaded (by Bartosz Dziewoński; owner: Nasty):
[mediawiki/extensions/VisualEditor@master] Fix parse wikitext fragment in paction wikitext.

https://gerrit.wikimedia.org/r/466949

Jdforrester-WMF added a project: VisualEditor-MediaWiki.Oct 12 2018, 7:19 PM
matmarex subscribed.Oct 12 2018, 7:23 PM

There is no REL1_32 branch yet, as far as I can see. I don't think it has been cut yet, so the patch in master should be automatically included in it.

Jdforrester-WMF subscribed.Oct 12 2018, 7:24 PM
In T206838#4662266, @matmarex wrote:

There is no REL1_32 branch yet, as far as I can see. I don't think it has been cut yet, so the patch in master should be automatically included in it.

It'll get cut in five days' time.

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Oct 12 2018, 7:38 PM
gerritbot added a comment.Oct 12 2018, 7:47 PM

Change 466949 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix parse wikitext fragment in paction wikitext.

https://gerrit.wikimedia.org/r/466949

gerritbot added a comment.Oct 12 2018, 7:47 PM

Change 466665 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@REL1_31] Fix parse wikitext fragment in paction wikitext.

https://gerrit.wikimedia.org/r/466665

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.Oct 12 2018, 7:49 PM

I've looked at extensions using the EditFormPreloadText hook and it turns out this problem can be reproduced on Wikimedia projects as well, so asking for QA review.

The only case I've found is creating an info page for a new Wikimedia project on Incubator, for example: https://incubator.wikimedia.org/w/index.php?title=Wp/qaa&action=edit (please don't actually save that page, I have no idea how Incubator works, they might get upset).

image.png (980×1 px, 254 KB)

Expected preloaded content is like this (using old wikitext editor here):

image.png (980×1 px, 131 KB)

(Among Wikimedia-deployed extensions, 'EditFormPreloadText' hook is also used by the ProofreadPage, extension but it appears you can't load the new wikitext editor on pages that would be affected.)

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 12 2018, 8:00 PM
JTannerWMF added a project: Editing QA.Nov 6 2018, 5:30 PM
Ryasmeen moved this task from QA to Engineering QA on the VisualEditor (Current work) board.Nov 7 2018, 3:37 AM
JTannerWMF moved this task from Inbox to High Priority on the Editing QA board.Nov 8 2018, 6:46 PM
Ryasmeen added subscribers: JTannerWMF, Ryasmeen.Nov 9 2018, 9:39 PM

@JTannerWMF/@matmarex I need clearer QA steps to understand what to test here.

matmarex moved this task from High Priority to Low Priority on the Editing QA board.Nov 14 2018, 4:36 PM
matmarex added a comment.Nov 14 2018, 4:39 PM

Steps to reproduce:

  1. Visit https://incubator.wikimedia.org/w/index.php?title=Wp/qaa&action=edit

Previously (incorrect):

image.png (980×1 px, 254 KB)

Now (correct):
image.png (980×1 px, 116 KB)

matmarex removed projects: Editing QA, Patch-For-Review.Nov 14 2018, 4:41 PM
matmarex moved this task from Engineering QA to Product owner review on the VisualEditor (Current work) board.
• marcella closed this task as Resolved.Nov 19 2018, 7:27 PM
• marcella claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 19 2018, 7:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits