Page MenuHomePhabricator
Create Task
Maniphest T206979

compact(): Undefined variable in LocalisationCache on PHP 7.3
Closed, ResolvedPublic
Actions

Description

PHP Notice:  compact(): Undefined variable: messages in /usr/share/mediawiki/includes/cache/localisation/LocalisationCache.php on line 531
PHP Notice:  compact(): Undefined variable: minimumGroupingDigits in /usr/share/mediawiki/includes/cache/localisation/LocalisationCache.php on line 531
PHP Notice:  compact(): Undefined variable: digitGroupingPattern in /usr/share/mediawiki/includes/cache/localisation/LocalisationCache.php on line 531
PHP Notice:  compact(): Undefined variable: pluralRules in /usr/share/mediawiki/includes/cache/localisation/LocalisationCache.php on line 531
PHP Notice:  compact(): Undefined variable: pluralRuleTypes in /usr/share/mediawiki/includes/cache/localisation/LocalisationCache.php on line 531
PHP Notice:  compact(): Undefined variable: compiledPluralRules in /usr/share/mediawiki/includes/cache/localisation/LocalisationCache.php on line 531

In PHP 7.3, compact now emits a notice if the variable is undefined.

This was caught by Debian's autopkgtest CI system.

Details

SubjectRepoBranchLines +/-
LocalisationCache: Avoid use of compact()mediawiki/coreREL1_31+14 -2
LocalisationCache: Avoid use of compact()mediawiki/coremaster+12 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Oct 15 2018, 7:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2018, 7:06 AM
Legoktm added a project: MW-1.31-release.Oct 15 2018, 7:10 AM
Legoktm added a subscriber: MaxSem.

Hmm, seems this was suppressed in ae314346d5dddf07f7dcac956db6160ceae46e8c.

Wouldn't it be cleaner to not use compact?

gerritbot subscribed.Oct 15 2018, 7:19 AM

Change 467265 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] LocalisationCache: Avoid use of compact()

https://gerrit.wikimedia.org/r/467265

gerritbot added a project: Patch-For-Review.Oct 15 2018, 7:19 AM
Legoktm added a comment.Oct 15 2018, 7:19 AM

In any case, I'd like something to be backported to 1.31 to fix this.

Legoktm moved this task from Backlog to MediaWiki core on the PHP 7.3 support board.Oct 15 2018, 6:03 PM
Jdforrester-WMF added a parent task: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.Oct 15 2018, 10:06 PM
gerritbot added a comment.Oct 15 2018, 10:34 PM

Change 467265 merged by jenkins-bot:
[mediawiki/core@master] LocalisationCache: Avoid use of compact()

https://gerrit.wikimedia.org/r/467265

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 15 2018, 11:00 PM
gerritbot added a comment.Oct 16 2018, 12:14 AM

Change 467545 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@REL1_31] LocalisationCache: Avoid use of compact()

https://gerrit.wikimedia.org/r/467545

gerritbot added a comment.Oct 16 2018, 12:34 AM

Change 467545 merged by jenkins-bot:
[mediawiki/core@REL1_31] LocalisationCache: Avoid use of compact()

https://gerrit.wikimedia.org/r/467545

ReleaseTaggerBot added a project: MW-1.31-release-notes.Oct 16 2018, 1:00 AM
Krinkle closed this task as Resolved.Oct 20 2018, 5:48 AM
Krinkle assigned this task to Legoktm.
Krinkle moved this task from Backlog to Core on the MW-1.31-release board.
valerio.bozzolan subscribed.Feb 19 2021, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits