Page MenuHomePhabricator

As a new user of the reading lists feature, I would like to be able to easily read the empty state text on my first visit to the Reading lists tab
Closed, ResolvedPublic1 Estimated Story Points

Description

Why are we doing this?

Currently with the floating article bar and the CTA to sync reading lists on the reading lists tab, it is hard to read the empty state text

User story

As a new user of the reading lists feature, I would like to be able to easily read the empty state text on my first visit to the Reading lists tab

Potential solution

Place an emphasis on the empty state text by removing the empty state image, therefore allowing the text to be shown above the floating article bar and below the CTA to sync reading lists.

Event Timeline

cmadeo triaged this task as Medium priority.Oct 26 2018, 3:22 PM
cmadeo created this task.
Charlotte set the point value for this task to 1.Nov 6 2018, 5:45 PM

I am working on this.... unable to edit the task..

Change 472029 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Remove ReadingLists Empty Image

https://gerrit.wikimedia.org/r/472029

Change 472029 merged by jenkins-bot:
[apps/android/wikipedia@master] Remove ReadingLists Empty Image

https://gerrit.wikimedia.org/r/472029

ABorbaWMF subscribed.

This one looks like it is still occurring to me on 2.7.264-alpha-2018-11-07

I'm not sure, but the continue reading bar obscures the latter half of the sentence at the bottom of the screen and the page cannot be scrolled vertically.

Screenshot_20181107-132844.png (1×1 px, 185 KB)

image.png (1×1 px, 133 KB)

Change 473645 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Make ReadingLists empty text visible

https://gerrit.wikimedia.org/r/473645

Change 473645 abandoned by Sharvaniharan:
Make ReadingLists empty text visible

Reason:
Scrolling is complex - we need to find a better solution to make text visible on landscape mode
https://phabricator.wikimedia.org/T208057

https://gerrit.wikimedia.org/r/473645

@ABorbaWMF I made it scrollable thinking it would solve the issue, but when there is a floating button for continue reading, it still doesn't work : https://youtu.be/0aLFDsAqwXQ spoke to @cmadeo ... we feel this needs more thought into the design, to find a way to have the sync dialog , reading list, and the empty message all visible on the screen, while the continue reading floating button is visible. So could we please pass this now, and have a separate ticket to design what is needed?