| Jdlrobson | |
| Oct 28 2018, 12:21 AM |
| F29279600: Screen Shot 2019-05-30 at 6.11.07 PM.png | |
| May 30 2019, 2:49 PM |
| F29254726: image.png | |
| May 27 2019, 7:32 AM |
| F29254741: image.png | |
| May 27 2019, 7:32 AM |
Visit https://en.wikipedia.org/wiki/Special:ContentTranslation?page=Comoment&from=fr&to=en&targettitle=Comoment&version=1&useskin=minerva (tool in desktop minerva) and ContentTranslation loads and is usable.
It seems many ContentTranslation modules are not being loaded on mobile. There seems no reason why this should be the case.
Please ensure
"targets": [ "desktop", "mobile" ],
is defined on all modules.
Mobile site is loaded on tablet devices, so it seems important for this to work.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make CX functional in Minerva skin | mediawiki/extensions/ContentTranslation | master | +42 -23 |
Change 512633 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Make CX functional in Minerva skin
Minerva does not have the personal tools rendered on the screen. An invalid assumption about the presence of personal tools was causing a js error while rendering the (custom) header. This was resulting blank page. In this patch, I check for the presence of personal tools and render it. It it is not present, like the case of Minerva, in the place of personal menu, just add a button that shows user name and icon. Clicking on that takes the user to user page.
We can think about making the user menu same as other skins, but as follow up.
| Screenshot in Vector | Minerva, after the fix |
 |  |
Same problem in Persian Wikipedia (fawiki): https://fa.m.wikipedia.org/wiki/Special:ContentTranslation.
Change 512633 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Make CX functional in Minerva skin
Checked in betalabs - Minerva desktop is successfully loaded:
TypeError: Cannot set property 'activator' of null
at createMainMenuThat error is not coming from Content Translation code, but from code in MinervaNeue skin. The error does not prevent page from loading, not sure if there are some implications in other places and if bug should be reported.