Page MenuHomePhabricator
Create Task
Maniphest T209494

Style "In more languages" and "all entered languages" link
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
• Lea_WMDE
Authored By
WMDE-leszek
Nov 14 2018, 3:21 PM
Tags
Referenced Files
F28148381: Screenshot 2019-02-07 at 17.28.00.png
Feb 7 2019, 4:49 PM
F26302597: Bildschirmfoto 2018-10-04 um 09.14.16.png
Nov 22 2018, 2:24 PM
F26217393: Termbox-Milestone1-collapsed.jpg
Nov 22 2018, 2:24 PM
Subscribers
Aklapper
gerritbot
• Hanna_Petruschat_WMDE
Jakob_WMDE
• Lea_WMDE
• Matthias_Geisler_WMDE
• Pablo-WMDE
WMDE-leszek

Description

Motivation
Users should be able to easily identify and use the links to more languages. This ticket is about making them visible, easily clickable, and about the arrow reflecting the current state of expansion.

Mocks
Expanded:

Bildschirmfoto 2018-10-04 um 09.14.16.png (622×354 px, 84 KB)

Collapsed
Termbox-Milestone1-collapsed.jpg (667×376 px, 84 KB)

Acceptance criteria:

  • The links ("show more languages", "all entered languages") are styled as shown on the mock ups, with an arrow next to the text, and the horizontal lines stretching link for the whole width of the screen
  • The click area is not just the link text but the whole area indicated in the mock ups.
  • The arrows are flipped, once the languages are expanded, and flipped back to pointing down if they are collapsed

Details

SubjectRepoBranchLines +/-
Adjust toggle button borderwikibase/termboxmaster+2 -3
toggleButton: arrow icons are only 32 squarewikibase/termboxmaster+3 -3
Polish toggle button styleswikibase/termboxmaster+6 -3
Update termboxmediawiki/extensions/Wikibasemaster+1 -1
Add toggle button styleswikibase/termboxmaster+88 -14
Customize query in gerrit

Related Objects

Event Timeline

WMDE-leszek created this task.Nov 14 2018, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2018, 3:21 PM
WMDE-leszek added a subscriber: • Lea_WMDE.Nov 14 2018, 3:22 PM
WMDE-leszek set the point value for this task to 5.Nov 14 2018, 3:42 PM
• Lea_WMDE triaged this task as Medium priority.Nov 22 2018, 2:24 PM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE moved this task from Backlog to MVP tickets: In preparation on the Wikidata-Termbox board.
• Pablo-WMDE mentioned this in T210408: Add "in all languages" link.Nov 26 2018, 2:26 PM
• Lea_WMDE renamed this task from Style "In more languages" link to Style "In more languages" and "all entered languages" link.Jan 9 2019, 10:57 AM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE changed the point value for this task from 5 to 3.
• Lea_WMDE changed the point value for this task from 3 to 2.Jan 9 2019, 11:07 AM
• Lea_WMDE updated the task description. (Show Details)Jan 14 2019, 1:22 PM
• Lea_WMDE moved this task from MVP tickets: In preparation to MVP things: Ready for pickup on the Wikidata-Termbox board.
Jakob_WMDE added subscribers: • Matthias_Geisler_WMDE, Jakob_WMDE.Jan 29 2019, 3:39 PM

@Lea_WMDE: @Matthias_Geisler_WMDE just discovered that Opera Mini which apparently has somewhere between 1,5% and 4,5% mobile browser market share, does not allow CSS transformations. So far we only used them for flipping SVGs, e.g. the pen and soon the arrows on the buttons. Are we ok with having non-flipped SVGs in Opera mini or should we add the flipped versions of the images so that they work there, too?

gerritbot subscribed.Jan 29 2019, 4:30 PM

Change 487049 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Add troggle button styles

https://gerrit.wikimedia.org/r/487049

gerritbot added a project: Patch-For-Review.Jan 29 2019, 4:30 PM
• Matthias_Geisler_WMDE edited projects, added Wikidata-Termbox-Iteration-8; removed Wikidata-Termbox.Jan 29 2019, 4:59 PM
• Matthias_Geisler_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-8 board.
• Matthias_Geisler_WMDE claimed this task.Jan 29 2019, 5:48 PM
• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-8 board.
gerritbot added a comment.Jan 30 2019, 4:39 PM

Change 487049 merged by jenkins-bot:
[wikibase/termbox@master] Add toggle button styles

https://gerrit.wikimedia.org/r/487049

gerritbot added a comment.Jan 30 2019, 4:45 PM

Change 487147 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/487147

• Matthias_Geisler_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-8 board.Jan 30 2019, 5:11 PM
gerritbot added a comment.Jan 30 2019, 5:38 PM

Change 487147 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/487147

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 30 2019, 6:00 PM
Jakob_WMDE moved this task from Test (Product Review) to Peer Review on the Wikidata-Termbox-Iteration-8 board.Jan 31 2019, 10:12 AM
gerritbot added a comment.Jan 31 2019, 10:14 AM

Change 487342 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Adjust z-index of the toggle-button line

https://gerrit.wikimedia.org/r/487342

• Lea_WMDE added a comment.Feb 1 2019, 1:44 PM
In T209494#4916769, @Jakob_WMDE wrote:

@Lea_WMDE: @Matthias_Geisler_WMDE just discovered that Opera Mini which apparently has somewhere between 1,5% and 4,5% mobile browser market share, does not allow CSS transformations. So far we only used them for flipping SVGs, e.g. the pen and soon the arrows on the buttons. Are we ok with having non-flipped SVGs in Opera mini or should we add the flipped versions of the images so that they work there, too?

Sorry for the delayed reply! Let's start with not doing anything special for Opera Mini, but I will ask Hanna as well (and we would write another ticket if that request comes up)

gerritbot added a comment.Feb 4 2019, 3:52 PM

Change 487868 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] toggleButton: arrow icons are only 32 square

https://gerrit.wikimedia.org/r/487868

gerritbot added a comment.Feb 4 2019, 3:54 PM

Change 487342 merged by jenkins-bot:
[wikibase/termbox@master] Polish toggle button styles

https://gerrit.wikimedia.org/r/487342

gerritbot added a comment.Feb 4 2019, 4:52 PM

Change 487868 merged by jenkins-bot:
[wikibase/termbox@master] toggleButton: arrow icons are only 32 square

https://gerrit.wikimedia.org/r/487868

Jakob_WMDE removed • Matthias_Geisler_WMDE as the assignee of this task.Feb 5 2019, 1:04 PM
Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-8 board.
• Pablo-WMDE subscribed.Feb 7 2019, 10:30 AM

@Lea_WMDE Please find the button styles at e.g. https://wikidata.beta.wmflabs.org/w/index.php?title=Item:Q11&useformat=mobile&uselang=de

• Hanna_Petruschat_WMDE subscribed.EditedFeb 7 2019, 4:38 PM

Thanks for the Update. I found one functional remark, one question and two minor style notes.

  1. When all entered languages are expanded, the aliases still run into the "interactive sidebar". see screenshot below
  2. Did we decide that we "remember in which state the termbox has been throughout the pages? If so, the all entered languages section does not remain its state but goes back to be collepsed when switching items
  3. the line weight of the devider is currently 2px but supposed to be one
  4. Can we have the font in medium instead of bold? I didn't pay attention to that anymore after we had the font discussion.

Screenshot 2019-02-07 at 17.28.00.png (708×2 px, 149 KB)

Jakob_WMDE added a comment.Feb 7 2019, 5:13 PM

@Hanna_Petruschat_WMDE Thanks for the review!

  1. Yes, that's a known issue. If it's ok with you, I would rather make this part of T214898 because it doesn't have much to do with the buttons.
  2. Nope, that's T209496.
  3. Whoops, will fix!
  4. Yes, we can change that. Following the IRL discussion: medium = somewhere between bold and normal in CSS font-weight. Can do, but in fonts like Arial it'll still come out bold.
• Hanna_Petruschat_WMDE added a comment.Feb 7 2019, 5:16 PM

Ah, thnaks for pointing out the other two tickets.

Regarding the font: Let's postpone this and assume we can have an overall check later and adapt if really needed. For now this should be on the lower end on the list of priorities.

gerritbot added a comment.Feb 7 2019, 5:20 PM

Change 488968 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Adjust toggle button border

https://gerrit.wikimedia.org/r/488968

gerritbot added a comment.Feb 7 2019, 9:18 PM

Change 488968 merged by jenkins-bot:
[wikibase/termbox@master] Adjust toggle button border

https://gerrit.wikimedia.org/r/488968

• Lea_WMDE closed this task as Resolved.Feb 8 2019, 10:14 AM
• Lea_WMDE claimed this task.
• Lea_WMDE mentioned this in T214898: Adjust termbox break points to minerva skin breakpoints.
• Lea_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Termbox-Iteration-8 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits