Maniphest T209497

Update the TOC to include section hierarchy: As a user of the Android app I want to be able to see section hierarchy reflected in the TOC
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	cmadeo
	Nov 14 2018, 4:05 PM

Description

Why are we doing this

We've received some user feedback around the lack of hierarchy in the new TOC and as @RHo had already designed mocks that included section hierarchy, now seems like a good time to implement these designs.

History

This was discussed in https://phabricator.wikimedia.org/T165964#4715285

User story

As a user of the Android app I want to be able to see section hierarchy reflected in the TOC

Mocks


Zeplin: https://zpl.io/a3qD66W	Zeplin: https://zpl.io/aRY0vNE

Design details

Header style	Font	Size	Default	Dark	Black
`H1` (Article title)	Droid Serif	24pts	Base0	Base100	Base100
`H2`	Droid Serif	18pts	Base0	Base100	Base100
`H3` and below	Roboto	14pts	Base10	Base90	Base90

Details

	Subject	Repo	Branch	Lines +/-
	Update the TOC to include section hierarchy	apps/android/wikipedia	master	+12 -9

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T195264 [EPIC] Improve app and article navigation
		Resolved		Sharvaniharan	T209497 Update the TOC to include section hierarchy: As a user of the Android app I want to be able to see section hierarchy reflected in the TOC

Event Timeline

cmadeo triaged this task as Medium priority.Nov 14 2018, 4:05 PM

cmadeo created this task.

cmadeo moved this task from Backlog to Ready for dev on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.

cmadeo updated the task description. (Show Details)Nov 14 2018, 4:23 PM

FYI this was part of the unresolved items on https://phabricator.wikimedia.org/T165964#4715285

• Charlotte set the point value for this task to 1.Nov 14 2018, 5:15 PM

cmadeo added a subscriber: Sharvaniharan.Nov 14 2018, 6:39 PM

Sharvaniharan claimed this task.Nov 14 2018, 6:41 PM

Sharvaniharan moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.

cmadeo updated the task description. (Show Details)Nov 14 2018, 7:32 PM

@cmadeo Could you please give me colors for all themes..

Right now, all h1,h2 and h3 are light : base10, dark and black: base90

cmadeo updated the task description. (Show Details)Nov 14 2018, 8:54 PM

cmadeo updated the task description. (Show Details)Nov 14 2018, 8:57 PM

@Sharvaniharan updated :) Thanks!

Thank you @cmadeo :)

Change 473648 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Update the TOC to include section hierarchy

https://gerrit.wikimedia.org/r/473648

gerritbot added a project: Patch-For-Review.Nov 15 2018, 1:00 AM

Sharvaniharan moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Nov 15 2018, 1:45 AM

Change 473648 merged by jenkins-bot:
[apps/android/wikipedia@master] Update the TOC to include section hierarchy

https://gerrit.wikimedia.org/r/473648

Sharvaniharan moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Nov 16 2018, 3:43 AM