Page MenuHomePhabricator
Create Task
Maniphest T209660

The references list dialog's Apply changes action is always enabled
Closed, ResolvedPublic
Actions

Description

The references list dialog's Apply changes action is always enabled.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Citemaster+51 -4ve.ui.MWReferencesListDialog: Disable 'Apply' button until changes are made
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Nov 15 2018, 11:34 PM
matmarex mentioned this in T206000: Apply changes action is enabled on several dialogs before any changes are made.
gerritbot added a subscriber: gerritbot.Nov 15 2018, 11:49 PM

Change 473953 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Cite@master] ve.ui.MWReferencesListDialog: Disable 'Apply' button until changes are made

https://gerrit.wikimedia.org/r/473953

gerritbot added a project: Patch-For-Review.Nov 15 2018, 11:49 PM
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Nov 16 2018, 12:12 AM
Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 20 2018, 3:42 PM
gerritbot added a comment.Nov 20 2018, 3:54 PM

Change 473953 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] ve.ui.MWReferencesListDialog: Disable 'Apply' button until changes are made

https://gerrit.wikimedia.org/r/473953

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 20 2018, 4:00 PM
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-References; removed Patch-For-Review.Nov 20 2018, 4:26 PM
Ryasmeen added a project: Editing QA.Nov 26 2018, 6:53 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Nov 27 2018, 3:36 AM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
marcella closed this task as Resolved.Dec 14 2018, 4:21 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL