Page MenuHomePhabricator

Fix or add keyboard shortcut for saving changes on Persian keyboard layout (Alt+Shift+S doesn't work?)
Open, Needs TriagePublic

Description

Currently the keyboard shortcut for saving changes is Alt+Shift+S, but unlike other shortcuts like Ctrl+I (italic) which works on any keyboard layout, this one does not work on Persian keyboard layout.

So currently in order to save the page using keyboard shortcuts, I have to:

  1. switch my keyboard layout from Persian (I mostly edit on fawiki)
  2. Press Alt+Shift+S
  3. Switch the layout to Persian
  4. write an edit summary
  5. Switch the layout to English (it's Alt+Shift on Windows)
  6. Press Alt+Shift+S Again

So I thought maybe you could add Ctrl+S (KeyS as the javascript event.code, not the event.key) as shortcut to make life for non-English users a bit easier:

  1. Press Ctrl+S
  2. write an edit summary
  3. Press Ctrl+S Again

Event Timeline

Dalba created this task.Nov 28 2018, 1:40 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 28 2018, 1:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ctrl+S is already a shortcut in the browser, to save the page as HTML. Where possible we try to avoid overriding browser shortcuts.

We should however address the issue of this shortcut not working with a Persian keyboard.

JTannerWMF added a subscriber: JTannerWMF.

We should perhaps decline the original request and create a separate ticket for the Persian keyboard issue. Lets discuss this and the lift it will take.

Needs investigation

matmarex renamed this task from Add a Ctrl+S as a keyboard shortcut for saving changes to Fix or add keyboard shortcut for saving changes on Persian keyboard layout (Alt+Shift+S doesn't work?).Jan 16 2019, 7:14 PM

I volunteer myself if you need any help from a native Persian speaker who loves VE. I'm Amir1 at IRC.

@Ladsgroup can you confirm this issue, and if there are any other shortcut issues with a Persian keyboard?

@Ladsgroup can you confirm this issue, and if there are any other shortcut issues with a Persian keyboard?

Can I get a list of VE shortcuts?

I tried all keyboard shorutcuts in the page " Clear formatting " brought me the help page for keyboard shortcuts instead but everything else worked. But for saving, None of "Shift + Alt + S" didn't work both for Persian and English and both with firefox and chrome.