Page MenuHomePhabricator
Create Task
Maniphest T210569

Fix or add keyboard shortcut for saving changes on Persian keyboard layout (Alt+Shift+S doesn't work?)
Open, Needs TriagePublic
Actions

Description

Currently the keyboard shortcut for saving changes is Alt+Shift+S, but unlike other shortcuts like Ctrl+I (italic) which works on any keyboard layout, this one does not work on Persian keyboard layout.

So currently in order to save the page using keyboard shortcuts, I have to:

  1. switch my keyboard layout from Persian (I mostly edit on fawiki)
  2. Press Alt+Shift+S
  3. Switch the layout to Persian
  4. write an edit summary
  5. Switch the layout to English (it's Alt+Shift on Windows)
  6. Press Alt+Shift+S Again

So I thought maybe you could add Ctrl+S (KeyS as the javascript event.code, not the event.key) as shortcut to make life for non-English users a bit easier:

  1. Press Ctrl+S
  2. write an edit summary
  3. Press Ctrl+S Again

Event Timeline

Dalba created this task.Nov 28 2018, 1:40 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 28 2018, 1:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders subscribed.Nov 29 2018, 12:19 PM

Ctrl+S is already a shortcut in the browser, to save the page as HTML. Where possible we try to avoid overriding browser shortcuts.

We should however address the issue of this shortcut not working with a Persian keyboard.

Esanders added a subscriber: dchan.Nov 29 2018, 12:20 PM
JTannerWMF moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.Dec 12 2018, 2:38 PM
JTannerWMF subscribed.

We should perhaps decline the original request and create a separate ticket for the Persian keyboard issue. Lets discuss this and the lift it will take.

JTannerWMF moved this task from Needs Discussion/Analysis to FY 18-19 Q3/Q4 on the VisualEditor board.Dec 12 2018, 5:59 PM

Needs investigation

matmarex renamed this task from Add a Ctrl+S as a keyboard shortcut for saving changes to Fix or add keyboard shortcut for saving changes on Persian keyboard layout (Alt+Shift+S doesn't work?).Jan 16 2019, 7:14 PM
• Whatamidoing-WMF added a subscriber: Ladsgroup.Jan 16 2019, 7:18 PM
Ladsgroup added a comment.Jan 18 2019, 12:09 PM

I volunteer myself if you need any help from a native Persian speaker who loves VE. I'm Amir1 at IRC.

Esanders added a comment.Jan 18 2019, 6:24 PM

@Ladsgroup can you confirm this issue, and if there are any other shortcut issues with a Persian keyboard?

Ladsgroup added a comment.Jan 21 2019, 10:48 AM
In T210569#4893085, @Esanders wrote:

@Ladsgroup can you confirm this issue, and if there are any other shortcut issues with a Persian keyboard?

Can I get a list of VE shortcuts?

• Whatamidoing-WMF subscribed.Feb 8 2019, 12:25 AM

https://www.mediawiki.org/wiki/VisualEditor/Portal/Keyboard_shortcuts has a list, but I'm not sure that it's 100% current.

Ladsgroup added a comment.Feb 16 2019, 7:33 PM

I tried all keyboard shorutcuts in the page " Clear formatting " brought me the help page for keyboard shortcuts instead but everything else worked. But for saving, None of "Shift + Alt + S" didn't work both for Persian and English and both with firefox and chrome.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits