Maniphest T211910

Don't show misleading messages on Special:Contributions for IP ranges outside the CIDR limit
Closed, ResolvedPublic
Actions

Description

When viewing the contributions for an IP range that is beyond the CIDR limt — e.g., https://en.wikipedia.org/wiki/Special:Contributions/143.228.1.1/12 — MediaWiki:Sp-contributions-footer-anon is shown at the bottom instead of showing MediaWiki:Sp-contributions-footer-anon-range or simply nothing, as is done with unregistered usernames.

Additionally, block and block log links (for sysops) and suppressed user contributions (for oversighters) remain when a range is shown instead of a single address, but likewise don't make much sense for ranges outside the limit.

Details

	Subject	Repo	Branch	Lines +/-
	Don't show action links for IP ranges outside block limit	mediawiki/core	master	+170 -67

Customize query in gerrit

Related Objects

Mentioned In: T276306: CVE-2021-30156: Special:Contributions toolbar reveals existence of hidden users
T206954: Enable wgRelevantUserName for IP ranges

Event Timeline

Amorymeltzer created this task.Dec 13 2018, 6:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2018, 6:36 PM

Amorymeltzer updated the task description. (Show Details)Dec 13 2018, 6:40 PM

Krinkle removed a project: MediaWiki-User-management.Jan 25 2019, 10:01 PM

matej_suchanek moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Feb 3 2019, 12:49 PM

matej_suchanek added a project: TestMe.Feb 27 2020, 10:40 AM

The footer is no longer displaying the wrong message, but the user links are still there

Change 589659 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Don't show action links for IP ranges outside block limit

https://gerrit.wikimedia.org/r/589659

gerritbot added a project: Patch-For-Review.Apr 17 2020, 5:37 PM

GeneralNotability subscribed.Oct 5 2020, 6:54 PM

Ammarpad added a project: Platform Engineering.Oct 8 2020, 8:35 AM

Naike edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Oct 13 2020, 8:21 PM

BPirkle moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (External Code Reviews) board.Nov 19 2020, 3:10 PM

Amorymeltzer mentioned this in T206954: Enable wgRelevantUserName for IP ranges.Dec 19 2020, 12:58 PM

Change 589659 merged by jenkins-bot:
[mediawiki/core@master] Don't show action links for IP ranges outside block limit

https://gerrit.wikimedia.org/r/589659

• Clarakosi moved this task from External Code Review In Progress to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Jan 5 2021, 9:07 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2021, 9:11 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 5 2021, 10:00 PM