Page MenuHomePhabricator

Overlapping blocks may display incorrect block notice
Open, NormalPublic3 Story Points

Description

Problem
When T206163 is complete, the restrictions on overlapping partial blocks will be merged together and the user could get a block notice for a block that doesn't cover the restriction.

This can cause confusion if the user wants to know why they are blocked from a page, because they wont be able to specify which block it was that caused them to not be able to edit.

Example
User has two blocks that are applied to them (ip ranges, etc.) one for Saturn and another for Mars. The first block selected is the one for Saturn but they are trying to edit Mars. The user will be prevented from editing, but the block notice that is displayed will be for the block that applies to Saturn

Event Timeline

dbarratt created this task.Dec 19 2018, 6:22 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptDec 19 2018, 6:22 PM
TBolliger moved this task from Untriaged to Backlog on the Anti-Harassment board.Dec 19 2018, 6:34 PM
TBolliger triaged this task as Low priority.
TBolliger added a subscriber: TBolliger.

This is not that important to fix. The important work is T206163.

Niharika raised the priority of this task from Low to Normal.
Niharika moved this task from Backlog to Cards ready to be estimated on the Anti-Harassment board.

From the estimation meeting:

  • Add the block IDs
  • Make sure it looks fine on mobile
  • Show the expiry (last expiry from the blocks)
  • Show the reason (if we can)
Niharika set the point value for this task to 3.Thu, Jun 13, 7:00 PM