Page MenuHomePhabricator

Fix block message for CompositeBlocks
Closed, ResolvedPublic2 Story Points

Description

The message currently looks like this:

We should remove the link to the user and the ID, and add a reason that explains that multiple blocks are being enforced. We can mirror what System blocks display and add a custom reason.

Event Timeline

Tchanders updated the task description. (Show Details)Jun 13 2019, 6:55 PM
Niharika set the point value for this task to 2.Jun 13 2019, 6:55 PM
Niharika triaged this task as Normal priority.Jun 13 2019, 7:05 PM
Niharika updated the task description. (Show Details)
Niharika moved this task from Untriaged to Lāmed - ל on the Anti-Harassment board.
Niharika edited projects, added Anti-Harassment (Lāmed - ל); removed Anti-Harassment.

Change 517010 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Add a custom block message for composite blocks

https://gerrit.wikimedia.org/r/517010

For testing/reviewing, this change affects:

  • the error shown on trying to edit a page if at least one of the blocks applies to that page
  • the error shown on Special:EmailUser if at least one of the blocks prevents email

Change 517010 merged by jenkins-bot:
[mediawiki/core@master] Add a custom block message for composite blocks

https://gerrit.wikimedia.org/r/517010

Are we fixing the mobile message in this bug?

On Mobile:

  • Block message reports the blocking user as "MediaWiki default"
  • The "Details" link takes you to /w/index.php?title=Special:BlockList&wpTarget=%23null

@dom_walden I think this bug probably doesn't cover these problems, since they both apply to the existing SystemBlock messages too. However, they should be fixed. Filed as: T225939

dbarratt moved this task from Review to QA/Testing on the Anti-Harassment (Lāmed - ל) board.
Niharika closed this task as Resolved.Jun 18 2019, 4:19 PM
Niharika moved this task from QA/Testing to Done on the Anti-Harassment (Lāmed - ל) board.