There is no point in showing the tab on file pages which don’t exist locally, like https://www.mediawiki.org/wiki/File:Abcdefg.png. It should be hidden, just like on files which come from Commons (e.g. https://www.mediawiki.org/wiki/File:Example.svg).
Acceptance Criteria
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't show export tab on nonexistent pages | mediawiki/extensions/FileExporter | master | +57 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | thiemowmde | T223523 Newcomer-friendly FileImporter tasks at the Hackathon 2019 | |||
| Resolved | awight | T214076 Don’t show “Move to Commons” tab on non-existent files |
Change 513045 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileExporter@master] [WIP] Don't show export tab on nonexistent pages
Change 513045 merged by jenkins-bot:
[mediawiki/extensions/FileExporter@master] Don't show export tab on nonexistent pages
Not sure how I can test this, i.e. create a file page without a file. So far I did not manage to "get rid of the file". Could you either prepare a page for me on a test wiki, or I double check once it is deployed?
@Lea_WMDE does https://test.wikipedia.org/wiki/File:Example321.jpg do the trick? Its a file page without a file attached to it
Any file page which doesn't exist would also trigger the bug, e.g.
https://test.wikipedia.org/wiki/File:Nonexistent.jpg