Page MenuHomePhabricator

Giving "Thanks" on mobile site doesn't show "Thanked" label (and allows for multiple incomplete "Thanks")
Open, Needs TriagePublic

Description

Summary

As it says on the tin. When using the mobile web interface (Minerva Neue and/or MobileFrontend?) and giving another contributor a "Thanks" the "Thanks" label doesn't change to "Thanked" upon a successful "Thank".

Description

This behavior persists in both Flow discussions and in pages like Special:MobileDiff. Wherever a "Thank" label appears.

This does not happen on desktop using the Vector skin. I can "Thank" someone and the "Thanked" label remains as it should.

Note: This does not send multiple notifications. Notifications are only given upon the first "Thanks". Subsequent thanks do not fire off email or web notifications.

Expectation

When giving Thanks to someone the "Thanked" label should persist so as to not confuse the user that more "Thanks" are able to be given for the same action – and to clarify that the "Thank" was successfully sent.

Steps to reproduce

  1. Use the mobile web interface while logged in.
  2. Visit a page where a "Thank" label appears.
  3. Tap or click the "Thank" button.
  4. A notification at the bottom of the screen will appear saying you have thanked someone. The "Thank" button changes to "Thanked"
    1. A similar process happens with the "Thank" link in Flow boards.
  5. Refresh the page.
  6. The "Thank" button is reset. Repeat process x∞

I was using an iPhone Xr and mobile Safari. I was also able to reproduce on a Mac using Safari and Chrome.

You can thank either my personal or staff if you want to test. Here are some example URLs.

Thanks on mobile Flow: https://m.mediawiki.org/wiki/Topic:Uhrkpqsyuvuk7yy0
Thanks on desktop Flow: https://www.mediawiki.org/wiki/Topic:Uhrkpqsyuvuk7yy0

Diff with Minerva: https://m.mediawiki.org/wiki/Special:MobileDiff/2813207
Diff with Vector: https://www.mediawiki.org/w/index.php?diff=2813207&diffmode=source

A short video showing this in a page revision.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2019, 6:02 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 23 2019, 6:12 PM

Possibly fixed by T63737

Jdlrobson moved this task from Backlog to Tracking on the MinervaNeue board.
Jdlrobson edited projects, added MinervaNeue (Tracking); removed MinervaNeue.